pepfar-datim / datim-approvals Goto Github PK

View Code? Open in Web Editor NEW

0.0 29.0 4.0 14.27 MB

Data approval app for PEPFAR.

CSS 0.01% JavaScript 7.48% HTML 0.01% TypeScript 92.51% Makefile 0.01%

datim-approvals's Introduction

Repo Owner: Ben Guaraldi @benguaraldi

datim-approvals's People

Contributors

Watchers

Forkers

xsls jason-p-pickering tomzemp ilimikato

datim-approvals's Issues

Action buttons invisible for super-user

Inter-Agency vs Global... Mechanism status

I found a weird bug...

Inter-Agency sees status:

However, Global can see a different status:

Random test errors

I've started having a bunch of random errors...

probably some race conditions....

Write tests for Approvals as Agency, Inter-Agency, Agency HQ

test submit, accept, recall, return

Status viewed as Partner vs Agency

Partner can't see that mechanism was submitted by agency.....

We should make that obvious so it's not confusing,...

promoting / demoting mechanisms also on another levels

we have a test only as partner
let's do next step... agency, agency hq, inter-agency

Mechanism Submit function

User Story: Partner user should be able to Submit pending mechanism to Agency...

Let's do this via REACT Router as a a separate page.

JavaScript not working on rendered forms...

Improve form design

Check MER Tide project and what it would take to redesign the forms using react

Cypress tests for `Agency\India` user

let's setup automated tests for the app..

status wrong in list vs action

vs.

Better `no results`

In case there is no results available we should be more user friendly

(new app only)

Mechanism Status

Add Mechanism status to the results table...

loading dialog during promote / demote

when you click red submit / recall button you don't know what's going on..

it should show loading progress so user knows they should wait...

Test for SUBMIT as Inter-Agency

Approvals refresh.. list of global approvals

In order to do the Approvals app refresh I'll ask with a simple task to just display a list of Global approvals

Prod deployment

Since we have an alpha-version of approvals.
Try to deploy it to prod...

Sort datasets for a given period alphabetically in drop down

Data sets are currently not sorted alphabetically in drop down (https://github.com/pepfar-datim/Global/issues/3332#issuecomment-453236975). change to make alphabetical

Missing Tests

Uff.. I think we getting close to finish.
Missing tests to implement:

Workflow:

Inter-Agency Recall Submitted Mechanism by self
Global Return Submitted Mechanism by Inter-Agency
Global Accept Mechanism
Global Recall Accepted Mechanism

Status:
Status in List for Pending, Accepted, Submitted mechanism for ALL user types

Form rendering issues

Now with displaying various different forms we've started having issues... let's fix them:

Form render not init issue....

Weird error. If you run scripts slowly the form doesn't get initialized...

If you run them very quickly it is just fine..

after some digging...

If the dataset is not initialized STELLA will re-initialize automatically.

If it has the dataset => fail

Submit Mechanism not working for MER Targets

Results working fine. Not targets.

Investigate and solve rapid requests by the approvals app

Here is a recent analysis of the DATIM server logs:

# A tibble: 13,913 x 5
   endpoint                                 Referrer                                                        Status      n hit_rate
   <chr>                                    <chr>                                                            <dbl>  <int>    <dbl>
 1 /dhis-web-commons-stream/ping.action     https://www.datim.org/dhis-web-dataentry/index.action              204 476642   0.285 
 2 /api/system/info                         https://www.datim.org/api/apps/Data-Approval/index.html?v=1.5.2    200 192419   0.115 
 3 /api/system/info                         https://www.datim.org/api/apps/Data-Approval/index.html?v=1.5.1    302 150905   0.0903
 4 /api/dataValues                          https://www.datim.org/dhis-web-dataentry/index.action              201 141482   0.0846
 5 /dhis-web-commons/security/login.action  https://www.datim.org/api/apps/Data-Approval/index.html?v=1.5.1    200 115367   0.0690
 6 /api/system/info                         https://www.datim.org/api/apps/Data-Approval/index.html?v=1.5.2    302  86900   0.0520
 7 /dhis-web-commons/security/login.action  https://www.datim.org/api/apps/Data-Approval/index.html?v=1.5.2    200  73036   0.0437

This is from a 24 hour period and note that the app is for some reason, making numerous and very rapid requests to two end points: 1) login.action and 2) api/system/info. Combined, these add up to almost 37% of the hits on the server in one day, which is well not good.

This actually places a significant load on the Tomcat server, since both of these requests (unlike the `ping.action) actually get through to the Tomcat server.

There is no good reason for this to happen, but the actual cause of it is unclear. We need to get to the bottom of this as soon as possible and prevent the app from making rapid and repeated requests to the server.

If the user is not logged in (due to their session being deactivated) then the app should simply stop working and not continue to do anything.

Requests to the api/system/info are OK, but should not be regarded as absolutely critical, since people are able to get this information from the "About" menu. If we are not able to prevent this from making a request or two, then we should just remove this functionality entirely.

@benguaraldi please elevate this issue as high as you can with the development team, as it is putting a very high load on the server.

FYI @nhobby @mdezalia @Markionium

Vendor.js not included in app compile from 4535 branch

When running gulp build-prod on https://github.com/pepfar-datim/datim-approvals/tree/4535, app compiles without errors, but /vendor/vendor.js was not included in zip file. This script loads angular, so without it, the app does not install properly.

App compiled successfully with vendor.js script on https://github.com/pepfar-datim/datim-approvals/tree/3332 and only relevant changes were to remove angular component on 4535: b2d263d

@benguaraldi @jakub-bao

Listing for India shows Global mechanisms

Limit drop-down choices

If I am an Agency User from India. I shouldn't see Botswana in drop-down menu.

If there is only one OU choice make it selected by default.

Path for font awesome font files

It's incorrect when doing a clean install with bower

Show different datasets in Action page

we're missing this drop-down...

View Mechanism Form

Let's add the feature which displays mechanism form content before submitting it...

Reset http call for status when changing the org unit

Currently the old request does not get canceled.

visual clue on mechanism state...

something like a generated picture saying in which status it is....

pending - > submitted by partner -> accepted by agency-> submitted by agency-> accepted by global

Progress Info

We have this stepper on mechanism detail page...

However, the problem is that lower levels (partner, agency) are not supposed to see what's happening with their mechanism after being accepted by level above... (DHIS2 rule)

e.g. all partner can see is this: