perkovec / gulp-sass-unicode Goto Github PK

Your last change caused several problems for us.

e.g.
content: "\2022"; is now transformed into content:"\5c\32\30\32\32";
"\f26e" is now transformed into "\5c\66\32\36\65"
"myString" is now transformed into "\6d\79\53\74\72\69\6e\67"

We had to get back to 1.0.1 version.

Currently content properties containing multiple characters are not replaced.

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

If we use the "compressed" output mode in SASS, and there are any matching quotes later in the file, gulp-sass-unicode will match from the opening quote of content to the last quote it finds.

Here's a simple example. We start with this SCSS:

.sample-class::after {
    content: "";
}

.sample-class2 {
    font-family: "Roboto";
}

This is compressed to:
.sample-class::after{content:""}.sample-class2{font-family:"Roboto"}

gulp-sass-unicode then outputs this:
.sample-class::after{content: "\22\7d\2e\73\61\6d\70\6c\65\2d\63\6c\61\73\73\32\7b\66\6f\6e\74\2d\66\61\6d\69\6c\79\3a\22\52\6f\62\6f\74\6f"}

I believe updating the regex to be non-greedy should be enough to fix this.

Hi, I have some characters (Æ Ø Å æ ø å) that were just fine in the compiled sass, but when installing gulp-sass-unicode to make my icons work, it also replaced ie. ø with \f8 - which is not working in the browser.
Any way to exclude some characters?

I tried this, and it works, but would be nice to be able to pass this array in the gulp-file:

var excludeList = ['Å','Æ','Ø','ø','å','æ'];

if (codePoint > 127 && !excludeList.includes(p2[i])) {
						
     content += "\\" + p2.codePointAt(i).toString(16);
} else {
     content += p2.charAt(i);
}

Gulp deprecated gutil and wants all plugins to replace it with something else.
https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

It looks like the only parts of gutil being used are PluginError and File:

gutil.PluginError => https://www.npmjs.com/package/plugin-error
gutil.File => https://www.npmjs.com/package/vinyl

Thank you!

Can you please add an MIT License or something to the project just so that it has one?