petehunt / react-classset

React.addons.classSet() packaged in npm

react-classset

Note: this library is now deprecated. Please use JedWatson/classnames instead.

react-classset's Issues

Allow objects when using multiple arguments

It would be nice to treat plain object arguments the same way as when used as a single argument, when they are passed along with strings or other values. That way we can pass strings for class names that are always true, and an object just for things that are conditionally rendered.

Example:

var className = cx({
  button: true,
  'button-primary': type == 'primary'
});

// This would be equivalent to the previous one:
var className = cx('button', {'button-primary: type == 'primary'});

If you think this makes sense, I can submit a PR with this, just wanted to know if you though about some issues beforehand with this approach.

Ignore falsy values when using cx('a', 0, 'b')

Should 0 be excluded?

react-classset/classSet.js

Lines 29 to 30 in 627166a

	// We should technically exclude 0 too, but for the sake of backward
	// compat we'll keep it (for now)

Deprecate this repo

facebook/react#2910 (comment)