Comments (4)
Hi @bgilbert
There is only one case where the action causes a pull request to close. That is when there is no longer a diff with the base branch. The action updates the PR branch and when GitHub sees that it has no diff anymore GitHub automatically closes the PR.
If you want to handle this case and add a comment in the PR, this is how I would recommend achieving it.
permissions:
pull-requests: write
...
- name: Create Pull Request
id: cpr
uses: peter-evans/create-pull-request@v5
- if: steps.cpr.outputs.pull-request-operation = 'closed'
uses: peter-evans/create-or-update-comment@v3
with:
issue-number: ${{ steps.cpr.outputs.pull-request-number }}
body: Pull request was closed because there was no longer a diff with the base branch.
from create-pull-request.
That approach sounds reasonable to me, but it currently doesn't work: pull-request-number
and pull-request-url
aren't set when pull-request-operation
is closed
.
from create-pull-request.
Oh, you're right. 🤦♂️
After thinking about this some more, I think this case is not easy to handle in the action because the action only indirectly causes the PR to close. I can't be 100% sure that when the branch is updated it caused the PR to close. A user could have closed it before that and left the branch undeleted. Sorry, but I don't think I have a good solution.
from create-pull-request.
In the updated
case, we query the API for the PR corresponding to the head branch. Would it make sense to also do that before deleting the branch, and if a PR is found, put its details in pull-request-{number,url}
?
from create-pull-request.
Related Issues (20)
- Using environment variables in `body-path` file HOT 1
- bit
- I'm confused what the `base` option is supposed to do HOT 1
- Don't require a deep fetch for forks HOT 11
- Token generated from GitHub App not working with push-to-fork HOT 4
- Default to "Squash and Merge" HOT 1
- I get error "protected branch hook declined" when I try to create a draft pull request into protected branch HOT 1
- Force update the branch of existing pull request HOT 1
- Empty PRs being created, is this expected? HOT 4
- Error creating new PR HOT 2
- `title-path` and `commit-message-path` inputs HOT 1
- `base` also does a checkout to that branch HOT 1
- Update multiple repositories HOT 2
- ignore untracked HOT 2
- NO PR created and branch changes to new branch and updates from main HOT 5
- Required checks are not being triggered after the PR creation HOT 1
- Error: Input 'token' not supplied. Unable to continue.
- Changes from test folder doesn't added to the PR
- Node version - Warning HOT 1
- Permission denied (publickey) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-pull-request.