Comments (2)
Hi @stevemao
Thanks for raising this issue.
The simple workaround for this is just to rename the branch
input to something that doesn't clash with an existing tag. (Which I can see you have already done 👍 ).
Also, in general I would advise not creating branches and tags with the same ref name. It does create ambiguous situations for git and makes operations more complicated.
As for whether the action should actually support this situation, I'm leaning towards not attempting to add support for it because the workaround is so straightforward (and best practice, in my opinion). I've only had a couple of users ever bump into this kind of issue where tags clash with branch names, so it's pretty rare I think. To support it, and other similar cases where tags clash with branch names, I think it would make the git operations in this action quite a bit more complicated.
I'm going to close this issue as "won't fix," but I might reopen it in future if many users are running into this issue.
from create-pull-request.
Yes exactly what I thought. And I did.
Perhaps add this and related issues to the faq?
FYI: There are new commands such as git switch which only works on branches but not tags.
Thanks for the detailed explanation!
from create-pull-request.
Related Issues (20)
- Using environment variables in `body-path` file HOT 1
- bit
- I'm confused what the `base` option is supposed to do HOT 1
- Don't require a deep fetch for forks HOT 11
- Token generated from GitHub App not working with push-to-fork HOT 4
- Default to "Squash and Merge" HOT 1
- I get error "protected branch hook declined" when I try to create a draft pull request into protected branch HOT 1
- Force update the branch of existing pull request HOT 1
- Empty PRs being created, is this expected? HOT 4
- Error creating new PR HOT 2
- `title-path` and `commit-message-path` inputs HOT 1
- `base` also does a checkout to that branch HOT 1
- Update multiple repositories HOT 2
- ignore untracked HOT 2
- NO PR created and branch changes to new branch and updates from main HOT 5
- Required checks are not being triggered after the PR creation HOT 1
- Error: Input 'token' not supplied. Unable to continue.
- Changes from test folder doesn't added to the PR
- Node version - Warning HOT 1
- Permission denied (publickey) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-pull-request.