peterbourgon / how-i-start-go Goto Github PK

Went thru this tutorial today and enjoyed it!
I especially like how it gave a practical example for using goroutines & channels.

Only problem I noticed is that near the end of the tutorial here: http://howistart.org/posts/go/1
your code won't compile because you use the "time" and "log" variables without ever specifying the import statements for either one. This isn't necessarily the worst thing in the world, since it gets people to think more carefully about what they're doing (kinda like my college professors LOVED to do). But just in case you weren't aware, I thought I'd post here.

Hey @peterbourgon

Thanks for the excellent article. ❤️
It taught me a lot about developing clean handlers in Go.

In general, I had a conceptual question regarding the handling erroneous goroutines i.e. goroutines returning an error.

Suppose I have 10 different weatherProviders and I use concurrency to fetch the temperature from all of them using 10 goroutines. Now, if the fastest of these providers return an error, the multiWeatherProvider returns according to the current implementation.
However, all the other 9 goroutines are still running in background, right?

• Does this not result in a resource leak in terms of memory?
• Should we not wait for all of them to complete and then decide upon the response?
• What should be the best practice here?

That'd help for responsive view!

This function won't work anymore as is without API key:

func (w openWeatherMap) temperature(city string) (float64, error) {
resp, err := http.Get("http://api.openweathermap.org/data/2.5/weather?q=" + city)
if err != nil {
return 0, err
}

Any chance of updating this for Go modules at a minimum?

This is an extremely good introductory tutorial to Go, Peter. IMHO, it has the perfect mix of "how to" for beginners and introducing more essential topics/concepts (like interfaces). The result is making the reader want to know more. Thanks for sharing.

Might be worth updating your post which is very good to note:

• api keys ~~~(and you probably shouldn't store them in version control)~~~ #-- you do this in your code
• weather underground is always returning zero because the api either changed or didn't work this way:

An example of how to call it now: https://github.com/karlhungus/dweeb/blob/0f1f795e9c301a89916e5a6d25d5e375de1aefdf/weather.go#L47