peterzen / kohola Goto Github PK

After some startups,WebKitNetworkProcess eats 100% CPU. Can't always reproduce - it happens around 50% or so of the time, not after all startups.

May have something to do with a race condition in exchangeratebot/coingecko.go but needs further investigation/profiling.

32321 peter     20   0 82.425g  50980  37108 R  98.7  0.3   0:31.05 WebKitNetworkProcess

On the frontend, the user should be able to add labels to UTXOs and transactions (both on existing transactions and in the Receive dialog - in the latter case the label should be associated with the generated receive address and later linked to the incoming TX).

The labels should be stored in a local database which does not exist yet; perhaps LevelDB.

Reimplement app config unlock passphrase input using OS native dialog: https://github.com/gen2brain/dlgs

• Hide CSPP transactions from Recent transactions table
• Add separate Mixer stats tab to Privacy page
• Implement denomination filter/date based grouping
• Add mixing stats chart to Mixer stats

The timestamp field currently used as key prop, but that isn't unique.

When the dropdown is changed, the below warning is logged:

2react-dom.development.js:89 Warning: Cannot update a component from inside the function body of a different component.
    in ExchangeRateChart (created by ConnectFunction)
    in ConnectFunction (created by Market)
    in div (created by CardBody)
    in CardBody (created by Market)
    in div (created by Card)
    in Card (created by Market)
    in div (created by Market)
    in div (created by Col)
    in Col (created by Market)
    in div (created by Row)
    in Row (created by Market)
    in div (created by Market)
    in Market (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)
    in withRouter(Connect(Market)) (created by Context.Consumer)
    in Route (created by App)
    in Switch (created by App)
    in div (created by Container)
    in Container (created by App)
    in div (created by AppSidebar)
    in div (created by AppSidebar)
    in div (created by AppSidebar)
    in AppSidebar (created by ConnectFunction)
    in ConnectFunction (created by App)
    in main (created by App)
    in Router (created by ConnectedRouter)
    in ConnectedRouter (created by Context.Consumer)
    in ConnectedRouterWithContext (created by ConnectFunction)
    in ConnectFunction (created by App)
    in App (created by ConnectFunction)
    in ConnectFunction (created by HotExportedConnect(App))
    in AppContainer (created by HotExportedConnect(App))
    in HotExportedConnect(App)
    in Provider
    in AppContainer

The charts in the market section in a proof of concept state right now, they need to be fixed up:

• Y axis values are off at the moment, probably due to the value normalization in frontend/src/features/market/marketSlice.ts. We probably need to adjust the displayed axis values through the recharts API
• X axis labels currently show raw UNIX timestamps, these should be rendered as dates (resolution depending on the selected time frame setting)
• Time frame should be selectable (for all charts) from a dropdown:
  • 1 day
  • 3 days
  • 7 days
  • 1 month

• Get rid of submodules & replace's in go.mod

The TB and mixer default settings templates are currently not linked to an endpoint ID in the configuration. This leads to the wrong template to be loaded after the user switches to a different endpoint.

Solution: save the templates in the WalletPreferences object.

• protobuf needs to be upgraded to google.golang.org/protobuf/proto
• necessary changes throughout the backend code

Should we let users disable the config file encryption?

Cons:

• once a file changes in a filesystem that's being backed up (which $HOME usually is), TimeCapsule and other snapshot/backup schemes pick it up and back it up right away -> if a user disables the encryption by mistake, they will have to roll their wallet credentials over to undo the damage.

Pros:

• ?

Should we let our users shoot themselves in the foot? If this is really needed, they can manually remove the config file and create a new one without the encryption turned on.

• Implement CreateTransaction method
• Integrate UTXO selection UI into SendTransaction
• Implement TX size estimator based on CreateTransaction

Using https://github.com/buildo/react-placeholder, implement skeleton screens in the top level components.

• Implement placeholder components for subcomponents (as a rule of thumb, there should be one placeholder for <Card>...</Card> comps, in the same file.
• Wrap subcomponents with <ReactPlaceholder...>
• Some components data loading mechanics will have to be changed so that we have a loading prop that can be passed to ReactPlaceholder

• Upgrade webpack 5
• Bump frontend deps

Design/implement ROI charts

• It should visualize the table on the same page:

Purchased and Voted stats are flat:

Add UTXO selection ability to the Send transaction GUI flow

• CreateRawTransaction implementation in dcrwallet
• Implement GUI

In the app back-end, implement a background process that continuously fetches DCR-BTC, DCR-USD and potentially, other fiat pairs from a set of (configurable) exchanges.

The exchange API endpoints should be configurable in the frontend Settings page.

The implementation may use the dcrrates server but this is TBD - though if it is an overkill in terms of resources used.

Starting point: https://github.com/decred/dcrdata/blob/master/exchanges/bot.go

For self contained, cross platform builds that do not require Chrome to be installed, Webview should be implemented, in addition to the existing lorca approach. The current Lorca implementation should ideally be kept, and there would be an abstraction layered developed so that the use of lorca vs webview can be decided at build time. (Lorca is much faster to develop with so we want to keep that.)

https://github.com/zserge/webview

• Implement abstraction layer - *ExportAPI Go functions
• Add Webview layer

• Implement dark mode using https://github.com/Clashsoft/bootstrap-darkmode
• Add switch control to Preferences
• Persist setting in appConfiguration

Implement a backend API method that opens https:// URLs using the system default browser.

Implement an OS native systray menu using https://github.com/getlantern/systray

The menu items in the first iteration should be:

• Show window
• Quit

Show window should bring the main window to the focus, Quit should exit the app.

• Initialization in main.go
• Find out how to control desktop windows in a cross platform way (i.e. how to focus the Webview window)
• Update build dependencies in README, build scripts, Dockerfile

• Think about and come up with a generic implementation for FeeChooserInput.tsx
• Implement Solo staking persistence into a PurchaseTicketsRequest

At the moment, the configuration stores the full pathname to the rpc client cert. This should be changed so that the cert blob is directly stored in the config file so that it does not have to lay around in the file system unprotected (=>with the config file being encrypted that will also protect the cert.)

• Activate the cert_blob input: https://github.com/peterzen/dcrwalletgui/blob/a0d1cb395a2b89afa52bb099d217bf2f9ab8382e/frontend/src/features/appconfiguration/RPCEndpointConfigForm.tsx#L169

This should enable the user to paste in the cert (which they obtained through an SSH session from the server so that the cert never has to leave that machine).

• The existing file browse option should be kept also, except that instead of populating cert_file_name, appconfig.go / SetConfig would read the cert contents.

The app configuration JSON file should be encrypted using a user provided passphrase, if the user chooses to enable this. The encryption process should happen in the backend and be transparent to the frontend.

The wallet and account totals component needs to be redesigned into something that makes sense. (The existing layout is a placeholder.)

It should:

• give the user a friendly way to see totals (in DCR as well as alternative currencies)
• display the ratios of the values in various states (locked, spendable etc) as a pie chart
• display sparkline charts of key exchange rates - DCR/BTC, DRC/USD - at the end of the day there should ideally be a single chart so as not to make the layout too busy

Implement the PublishUnminedTransactions API call. On the frontend, the function should be added as a button on the tx details modal:

Add scripts that build a single executable binary.

https://github.com/zserge/lorca/tree/master/examples/counter

• Add sweepAccount func to walletapi.go (constructTransaction is a good starting template to use)
• Add bind code to ExportWalletAPI
• Implement frontend middleware in lorca.ts
• Add redux reducers/actions in src/features/transactions
• Implement GUI as a modal (ConstructTxDialog is a good starting point as SweepAccount has similar inputs. The modal should be accessible from a (to be added) Tools menu, similarly to that on the Staking page (StakingToolsMenu.tsx):
  

API doc: https://github.com/decred/dcrwallet/blob/master/rpc/documentation/api.md#sweepaccount

TX notifications are displayed more than once, due to dcrwallet sending multiple unminedTx messages.

processTransactionNotification should only process those messages that are actually informative (for instance, it should not send notifications for the 0 DCR transactions that are associated with ticket purchases. There are also 2 notifications when sending funds.)

The duplicated messages dcrwallet is sending are correct; but processTransactionNotification should know better which ones to notify the user about.

https://github.com/peterzen/dcrwalletgui/blob/a0d1cb395a2b89afa52bb099d217bf2f9ab8382e/frontend/src/features/app/fixtures/Toasts.tsx#L16

The exchange rate sparkline chart disappeared between commits 55499395a6a22438830017e16c87f280e137fe50 and 1c7654a6ce5ecbf17ea430c0a091898d54421348, it does not currently render as before:

When the config file encryption is enabled, the dark mode activates only after the passphrase prompt. To fix that, the theme config option should be cached within the browser window itself (localStorage, cookie, etc).

The cache needs to work in production mode when the webview renderer is used (

Implement desktop notifications using beeep:

https://github.com/gen2brain/beeep

• Add protobuf messages in dcrwallet.proto
• Implement Lorca endpoints inwalletgui/notifications.go
• Implement TS middleware in appbackend.ts
• Implement sendDesktopNotification redux action in features/app/appSlice.ts
• Send TX notifications from frontend/src/features/transactions/actions.ts:75

When mistyping the config unlock password no error message is being shown. The error condition is being handled correctly.