petlyh / js-dict

Japanese-English dictionary app powered by Jisho.org.

JS-Dict

Japanese-English dictionary app powered by Jisho.org.

Screenshots

License

JS-Dict is Free Software: You can use, study, share, and improve it at will. Specifically you can redistribute and/or modify it under the terms of the GNU General Public License version 3 as published by the Free Software Foundation.

js-dict's Issues

Suggestions disappears in Mozc-based IMEs

Thanks for the fixes so far and the work. I have an issue with input into the search box. I do not know whether it is only related to JS-Dict application or has something to do with the Keyboard I'm using. However, I use many apps and I have only encountered this with JS-Dict on my system.

My keyboard: OyaMozc (Google Play)

Here's a video: https://github.com/petlyh/JS-Dict/assets/3247063/d6a1b221-1388-4a12-9c5d-46978720e067

As you can see, the prediction box opens and immediately closes again in most cases. I'm not sure why, but this happens so far only in this application for me.

OCR integration

Hey, first of all thanks a lot for developing this app, it is awesome!
This is a feature request for ocr in this app, this would be a pretty nice feature e.g. for reading physical manga or just for characters on physical stuff that you can't just easily copy-paste.
I would love to integrate this on my own but unfortunately do not have to necessary android dev knowledge to do so. I did however find a library for doing this: https://developers.google.com/ml-kit/vision/text-recognition/v2 this is from google's ml-kit, which is used in things like google lens, it runs on device and it seems like it has an relatively easy API to integrate.
Tell me what you think about this!

Incorrectly displayed furigana

some furiganas are displayed furiously, amamihanasakigaeru for example

Ruby displayed incorrectly for example sentences

As far as I can see this only affects example sentences.

Certain compound entries lead to the wrong word

Certain entries for compound words found on kanji pages opens the wrong word when clicked.

Steps to reproduce:

1. Search for and open the kanji 直.
2. Open the On reading compounds panel and click the first entry (直 【チョク】).

Expected behavior: opens the word 直 ちょく
Actual behavior: opens the word 値 あたい

Disappearing suggestions in Mozc for Android on LineageOS 21 (Android 14)

Suggestions for words for mozc android often disappear after kana input in js-dict on android 14.
Sometimes they stay in the word candidate section on top of the keyboard but often disappear immediately after a word update.
Apparently the space key used to select among the candidates does not trigger the disappeqrence of the top bar.
Here is a short recording, typing two different words the issue presents itself in slightly different ways:

screen-20240608-181749.mp4

This is how it's supposed to work instead:

screen-20240608-183840.mp4

I know mozc for android is relatively old and unmaintained, and that it targets old android APIs but it's the only foss japanese ime available on android without gapps or gboard, specifically with 12 keys input, and works in every app with text input I tried on android 14 showing this strange beheaviour only in js-dict so this might be solved with relatively low effort.
I can't reproduce the issue on android 9 (LineageOS 16) where it works as intended.

Add Themed adaptive icon

@petlyh Add material themed icon

Chinese version of kanji

Generally my Android device is set up correctly for Japanese, but both in the screenshots provided here in the repository as well as on my personal device, kanji are not rendered with their Japanese variant but instead look like Chinese.

Try out 曜 or 直 for some easy to discern examples.

Text selection pop-up action button, reaults cache, and furigana for kanji

Hi!
First I'd like to thank you so much for making this app! It has been very helpful! Sadly I have no programming skills and would like to request the following features to make this app better:

1. A temporary storage of results, as you can see in the first video attachment that the results are losing each time I tap on a previously loaded result. I think it is fetching results from the site each time. The loading delay begins to get quite uncomfortable after a while. Additionally, it may also be increasing the stress on the servers by pulling the same results so many times. I think the results can be stored on device temporary for 2 minutes or indefinitely or something like that.

1st_feature_request.mp4

2. I think it will be very useful to implement the functionality as seen for the Translate You app in the second video attachment. It pops up in the text selection pop-up and allows us to quickly see a translation in a pop-up window, without disrupting the workflow. Here is the github for the Translate You app that can be seen in the video attachment demonstrating the feature: https://github.com/you-apps/TranslateYou

2nd_feature_request.mp4

3. I think it will also be very useful to see the Furigana like the Jisho.org website does for Kanji as seen in the screenshot attachment, circled in green above the Kanji.

Thank you!!