pfalcon / berkeley-db-1.xx Goto Github PK

The include/db.h file includes sys/cdefs.h which is an internal glibc header that may not exist in other libc implementations and thus should not be used.

Compilation with musl libc fails:

In file included from ../../lib/berkeley-db-1.xx/btree/bt_seq.c:48:0:
../../lib/berkeley-db-1.xx/PORT/include/db.h:40:23: fatal error: sys/cdefs.h: No such file or directory
compilation terminated.
In file included from ../../lib/berkeley-db-1.xx/btree/bt_split.c:48:0:
../../lib/berkeley-db-1.xx/PORT/include/db.h:40:23: fatal error: sys/cdefs.h: No such file or directory
compilation terminated.
In file included from ../../lib/berkeley-db-1.xx/btree/bt_utils.c:47:0:
../../lib/berkeley-db-1.xx/PORT/include/db.h:40:23: fatal error: sys/cdefs.h: No such file or directory
compilation terminated.
In file included from ../../lib/berkeley-db-1.xx/mpool/mpool.c:46:0:
../../lib/berkeley-db-1.xx/PORT/include/db.h:40:23: fatal error: sys/cdefs.h: No such file or directory
compilation terminated.
[...other files of berkeley-db include db.h too...]

Hello,

To enable duplicate key in btree, one can call
btree.open(flags=1)

after some tests we detected a coredump in bt_delete.c

You will find attached the patch:
bt_delete.patch.txt

When some duplicated keys are searched, the first loop scans left to right, the second loop scans right to left.
In the case where the btree leef h->upper == t->psize, i.e. when the free space is up to the right page limit, the first do while loop shall not be entered. Only the second loop is necessary to remove from right to left.

The test program uses a dbm module that could be in micropython-lib, if you need it i could provide it.