phanx-wow / gofish Goto Github PK

Hi!
Started to use your Addon yesterday. Mainly fishing at Margoss's retreat.
Found it a bit weird, that the music always goes up when the fish cast is over, just to be silenced 2 seconds later when i cast fishing again.

Maybe the calls to Enhance/RestoreSound should be done when entering/leaving Fishing Mode (i.e. at /gofish).

Mouseover does not work.

1x GoFish\Options-Options.lua:92: Usage: PlaySound(soundKitID, optional["SFX","Music","Ambience", "Dialog" or "Master"], [forceNoDuplicates, runFinishCallback]) [C]: in function PlaySound'
GoFish\Options-Options.lua:92: in function <GoFish\Options.lua:90>

Locals:
(*temporary) = nil
`
There are several lines in Options.lua that call PlaySound() and all of them will cause an error. I could not find SOUNDKIT versions of SOUND_ON or SOUND_OFF but perhaps you can find something appropriate from the list.

The only reason I'm trying to find fishing addons is for the sound effects, but yours like many others doesn't actually change anything about the sound with any configuration.

Hi,
Due, no doubt, to api changes in the pre-patch I get a spectacularly unhelpful error message about usage for line 389, about UnitBuff.
Replacing
or (IsMounted() and not (UnitBuff("player", FROSTWOLF_WAR_WOLF) or UnitBuff("player", TELAARI_TALBUK)))
with:
or (IsMounted() and not (AuraUtil.FindAuraByName(FROSTWOLF_WAR_WOLF, "player") or AuraUtil.FindAuraByName(TELAARI_TALBUK, "player")))
seems to have fixed the issue.

Can you please add In combat fishing so this addon wouldn't turns itself off every time I'm in combat. I even created a macro to switch it on but its all so frustrating that every time I aggro some spawned mob around fishing spots I need to press it (cause hovering over pools isn't working in 50% of the time)

You can no longer hear fish biting with sounds off, it wasn't the case before, while other addons still have this functionality (weakaura etc), gofish lost it.

I like to play with sounds off, and ability to hear fish bites was the main reason i have used this addon.

I hope for a fix, tnx

In FishingBuddy.lua

• This updates the wow version check for both version 8 (BfA) and version 9 (SL)
  Change line 10 to 'local IS_WOW_8 = GetBuildInfo():match("[8-9]")'

• Even though the fishing spell ID is 131474
  If using a fishing rod the cast spell ID will be 131490
  If not using a fishing rod the cast spell ID will be 131476

Change line 14 to 'local FISHING_ID = Insert your correct cast spell id here'

It'd be nice if there was an option to turn on background sound when going into fishing mode so I can hear the bobber when alt tabbed.