Comments (6)
No worries. Do you normal release schedule. I can work with my fork. In the long run, i once want to switch to your release build rather than using the local fork.
Thanks alot for your quick reaction on all these issues & PRs i put :)
from ph-css.
That's a tricky one, because that means, that I need to use different data types internally, which will bloat the data model a bit more. But I can understand why it would make sense. As a heurisitc you can say everything that starts with '
or "
is a String, whereas the other things are identifiers. Does that help? I could also provide you with a quick sanity method in CSSExpressionMemberTermSimple
if needed...
from ph-css.
That's what i acutally do, i check whether the value is surrounded by '
or "
to identify it as a String. I ofcourse understand your concerns, and i already realized this is being a rather big change.
Perhaps having an enum, whether it's a String or an Ident value in the CSSExpressionMemberTermSimple
, which is resolved upon construction of this member would already help?
from ph-css.
Here's a PR (if you like)
#76
from ph-css.
Thanks for providing this patch - is that urgent for you? Than I can build a 6.4.2 version
from ph-css.
Great thanks. Closing this issue for now.
from ph-css.
Related Issues (20)
- :not Selector parsed incorrectly HOT 2
- Unexpected rule '@': Unknown rule in the middle of a rule-set is not allowed! HOT 4
- Previous sibling selectors incorrectly parsed without whitespace HOT 12
- Unable to add declarations where property contains "--" or "@" HOT 3
- Strange exception when creating own shorthand descriptors HOT 2
- :lang with empty expression list parsed incorrectly HOT 3
- :host and ::slotted pseudo class/element functions are parsed incorrectly (used in shadow DOM) HOT 2
- :host and ::slotted parsing sort of wrong HOT 6
- CSSReaderDeclarationList missing methods to pass in CReaderSettings as argument HOT 1
- Scientific number notation not supported by parser HOT 4
- Add :host-context pseudo class function to the Parser HOT 3
- Scientific notation can also contain '.' HOT 7
- *IDENT (<=IE6 hack) in style declaration block, drops all declarations after this one (in browser compliant mode) HOT 7
- Class selector not supported inside :where HOT 5
- :nth-child(expr) is parsed as CSSSelectorSimpleMember HOT 1
- Support `@supports` HOT 1
- CSSParserHelper.unescapeURL not following the css escape diagram HOT 7
- Support for CSS nesting module HOT 3
- Can't parse Bulma 1.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ph-css.