GithubHelp home page GithubHelp logo

Comments (7)

shagkur avatar shagkur commented on June 10, 2024

This would be my approach/proposal to fix this issue:
#85

from ph-css.

phax avatar phax commented on June 10, 2024

In the PR you are throwin a ParseException in case of error. What is your goal? Just drop that particular property?

from ph-css.

phax avatar phax commented on June 10, 2024

For the input CSS

div {
max-width: 100px;
*zoom: 1;
position: relative;
}

in browser compliant mode I would expect this as an output:

div {
max-width: 100px;
position: relative;
}

in non-browser compliant mode I would expect this as an output:

div {
max-width: 100px;
}

from ph-css.

shagkur avatar shagkur commented on June 10, 2024

In the PR you are throwin a ParseException in case of error. What is your goal? Just drop that particular property?

Yeees. It should drop that particular property in browser compliant mode (which should be achieved by the catch clause in the styleDeclaration() rule then) otherwise it should throw thru the exception (and will/should then be catched in styleDeclarationBlock() rule). If i understood everything right.

And then it should, depending on the mode, result on what you described in the next post.

from ph-css.

phax avatar phax commented on June 10, 2024

Stupid one - please confirm. If so, I will release

from ph-css.

shagkur avatar shagkur commented on June 10, 2024

Sorry for answering late....
Works great. This is a way better solution, especially regarding the error reporting.
Thanks alot for putting your time into this :)

from ph-css.

phax avatar phax commented on June 10, 2024

Part of 6.5.0 release that I will be creating now

from ph-css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.