philippdormann / bludit-auto-update Goto Github PK

I was on Bludit 3.9.2, uploaded the plugin and activated it.
Immediatly after activating the plugin I got the following:

Warning: rmdir(./auto-updater-temp//bludit-3-10-0): Directory not empty in /customers/a/f/3/uwcc.uk/httpd.www/practice/bl-plugins/bludit-auto-update/auto_update.php on line 107

Warning: rmdir(./auto-updater-temp/): Directory not empty in /customers/a/f/3/uwcc.uk/httpd.www/practice/bl-plugins/bludit-auto-update/auto_update.php on line 107

Bludit was updated to 'bludit-3-10-0'.
This plugin automatically downloads and installs the latest Bludit version offered on the official > Bludit site.
Warning: This will overwrite your bludit installation.

I can confirm that the folder auto-updater-temp has been created and that it contains the latest current version (v3.10.0).

The only file it contains is a .htaccess file. It is otherwise empty.

I can also confirm that I can see new functionality in admin and the about admin confirms the new version.

The first point is that when the plugin is de-active, the only option is to click on Activate and the following highlighted text is irrelevant:

Having subsequently entered Settings again I get a clean page, however, the warning, "Warning: This will overwrite your bludit installation." is a bit late in the day and a moot point, or it that pointless... Sorry, excuse me, I don't mean to be facetious.

First Issue: The plugin should not upgrade anything on just activating it.

Second Issue: Maybe a debatable point, but one I feel strongly about, is that clicking on Settings should not trigger an upgrade.
We should end up on a screen that at least displays the current version, the expected upgrade version and some very clear instructions about what is going to happen covering stuff like "Try first in DEV" and "Have you taken a full backup?".
Then after some simple text box confirmation that the user types in, eg bludit-3-10-0, are they allowed to click an Upgrade Now button.

Third Issue: The temp folder still exists - it should be cleaned up. Not much more to be said on that other than maybe offer the clean up as an option in settings. After all, one may wish to download and check the files used for the upgrade.

Fourth Issue: None of the Plugins or themes seem to have been upgraded. At least not according to their version number:

Fifth Issue: After downloading the latest release from bludit and running a compare, as i would when doing a manual upgrade, I can't see that any of the files have been upgraded... at least not by date. I admit that this is very strange because I can see new functionality, eg the custom fields.

Closing comment:
I am really sorry to blast in like this; I am actually very impressed and with the new functionally doubtless added, it was a lot simpler than manually downloading and then uploading and checking everything.

Once the above issues are resolved I'll be very pleased to use this on a live site.

Then, as an enhancement, it would be good to see a list of the files that are going to be replaced/deleted by the upgrade.

I installed the plugin for the V 3.71
i'm in V 3.5
https://www.sucrepop.com
when I activate the plugin i'm on a blank page
there are no parameters available