GithubHelp home page GithubHelp logo

Comments (2)

winwinashwin avatar winwinashwin commented on June 15, 2024 1

From their blog post, github seems to recommend using pre/post job hooks for cleanup. Currently the terraform does not allow the user to override or extend the pre job hook created by the terraform.

  1. The pre job script is overridden and not appended to.
  2. The script does not execute any additional user configurable scripts.
  3. The start-runner.sh is executed after both pre and post user-data scripts which the user can provide as inputs to the terraform.

All these make it really difficult to extend the pre job hook.

@npalm Can we add a feature where the user can extend or replace the pre job script?

from terraform-aws-github-runner.

sykhro avatar sykhro commented on June 15, 2024

This is the standard behaviour when using self-hosted runners with GitHub Actions. You are responsible for cleanup in your own workflows

from terraform-aws-github-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.