GithubHelp home page GithubHelp logo

phillyopen / cycle-philly-ios Goto Github PK

View Code? Open in Web Editor NEW

This project forked from cledantec/cycle-atlanta-ios

2.0 2.0 8.0 21.66 MB

CyclePhilly for iPhone

Home Page: www.cyclephilly.org

License: GNU General Public License v3.0

Objective-C 99.60% C++ 0.40%

cycle-philly-ios's People

Contributors

acricaa avatar cledantec avatar emelleme avatar flibbertigibbet avatar guoanhong avatar kclough avatar mchoimis avatar pschmied avatar themightychris avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

cycle-philly-ios's Issues

Terms of Service

Issue: We need to add a privacy policy and disclaimer language the first time a user launches the app.

Proposed Design: After splash screen loads > pop-up prompt > presents terms of service labeled "Terms of Service". Right now put in placeholder text that can scroll to accomodate lots of text. After scrolling done, present "I Accept", "I do not Accept" buttons.

If user accepts, record acceptance associated with unique phone identifier on server

If user does not accept, crash app.

Corey will provide legally binding language to replace placeholder text.

Typo - Need new build

Exercise was spelled wrong in the ride upload chooser. I corrected the spelling and committed the change to git but we need to push a new build of the corrected version to testflight.

My version of Xcode won't build it reliably, can someone push it to testflight?

My Trips Text Overlap

When you select the "My Trips" icon on the bottom of the screen it will display a list of trips. Depending on the user behavior, if you select a trip and then go back to the list, or scroll up and down the list a few times, some of the trip names start to overlap. See attached photo. Kevin, let me know if you might be able to help with this.

img_2343

Crash on selecting "note this"

Reported by tester.

It seems to work in the emulator, but in looking in the debug messages, I see the following:

2014-01-25 21:33:30.157 Cycle Philly[1530:70b] Save Detail
2014-01-25 21:33:30.160 Cycle Philly[1530:70b] Note Added details: Testing
2014-01-25 21:33:30.160 Cycle Philly[1530:70b] Added image, Size of Image(bytes):0
2014-01-25 21:33:30.161 Cycle Philly[1530:70b] saving using protocol version 4
2014-01-25 21:33:30.162 Cycle Philly[1530:70b] deviceUniqueIdHash is feea0c2489e347265462f0b3657994ed
2014-01-25 21:33:30.162 Cycle Philly[1530:70b] img_url: 
Jan 25 21:33:30 kats-mbp Cycle Philly[1530] <Error>: CGBitmapContextCreate: unsupported parameter combination: 0 integer bits/component; 0 bits/pixel; 0-component color space; kCGImageAlphaNoneSkipLast; 0 bytes/row.
Jan 25 21:33:30 kats-mbp Cycle Philly[1530] <Error>: CGContextDrawImage: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
Jan 25 21:33:30 kats-mbp Cycle Philly[1530] <Error>: CGBitmapContextCreateImage: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
2014-01-25 21:33:30.163 Cycle Philly[1530:70b] Size of Image(bytes):0
2014-01-25 21:33:30.164 Cycle Philly[1530:70b] there's an image
2014-01-25 21:33:30.165 Cycle Philly[1530:70b] note save and parent
2014-01-25 21:33:30.165 Cycle Philly[1530:70b] Save note
2014-01-25 21:33:30.445 Cycle Philly[1530:70b] 617 bytesWritten, 617 totalBytesWritten, 617 totalBytesExpectedToWrite
2014-01-25 21:33:30.446 Cycle Philly[1530:70b] didReceiveResponse: <NSHTTPURLResponse: 0x282a6aa0> { URL: http://mytracks.phillyopen.org/post/ } { status code: 201, headers {
    Connection = close;
    "Content-Length" = 173;
    "Content-Type" = "text/html; charset=UTF-8";
    Date = "Sun, 26 Jan 2014 02:36:39 GMT";
    Server = "Apache/2.2.22 (Fedora)";
    "X-Powered-By" = "PHP/5.4.3";
} }
2014-01-25 21:33:30.446 Cycle Philly[1530:70b] Upload complete: Your trip has been uploaded successfully. Thank you.
2014-01-25 21:33:30.446 Cycle Philly[1530:70b] +++++++DEBUG didReceiveResponse http://mytracks.phillyopen.org/post/: {
    Connection = close;
    "Content-Length" = 173;
    "Content-Type" = "text/html; charset=UTF-8";
    Date = "Sun, 26 Jan 2014 02:36:39 GMT";
    Server = "Apache/2.2.22 (Fedora)";
    "X-Powered-By" = "PHP/5.4.3";
}
2014-01-25 21:33:30.448 Cycle Philly[1530:70b] +++++++DEBUG: Received 173 bytes of data
2014-01-25 21:33:30.449 Cycle Philly[1530:70b] <br />
<b>Notice</b>:  Undefined variable: timeStamp in <b>/home/lloyd/public_html/mytracks/cycleatlanta.org/post/index.php</b> on line <b>103</b><br />
{"status":"success"}

Trip Purpose List

img_2631

On iOS6 phones it looks like the item names are pushed all the way to the left. Not sure if we should do anything to this if it is going to affect the iOS7 version that is currently working fine.

Name change to one word: CyclePhilly

Change name to "CyclePhilly" (one word).

Current the app is named "Cycle Philly" with a space between the two words. Before we submit to Apple we should change it to the one word name we have been using as a reference on the website and elsewhere.

Need to link to Cycle Philly site

There is no place in the iOS app to link to the Cycle Philly site/map so the user can compare his or her rides to fellow cyclists.

The link should probably go directly to the map.

Upload Failure

I am getting an upload error with each trip on the iOS version. Do we need to update the version to point to a new server or something?

I
photo

Recording continues after 'Save' selected

Coordinates continue to be added to the trip after the user presses 'Save' (which should end recording) until all additional details are entered and the trip is submitted or discarded.

References to Cycle Atlanta in Code

I updated most of the references to Cycle Atlanta or otherwise noted that Cycle Atlanta's app was adapted for Philadelphia deployment.

However, the following references to Cycle Atlanta are embedded in the Code and may need to be updated to Cycle Philly references:

CycleAtlantaAppDelegate.h
Cycleatl-Protocol-Version
cycle******notedata******atlanta
application/vnd.cycleatl.trip-v3+form

makeSubtreePerformSelector crashes

TestFlight has logged three crashes with the error:

-[UIView(Hierarchy) _makeSubtreePerformSelector:withObject:withObject:copySublayers:]

Terms of Service

Issue: We need to add a privacy policy and disclaimer language the first time a user launches the app.

Proposed Design: After splash screen loads > pop-up prompt > presents terms of service labeled "Terms of Service". Right now put in placeholder text that can scroll to accomodate lots of text. After scrolling done, present "I Accept", "I do not Accept" buttons.

If user accepts, record acceptance associated with unique phone identifier on server

If user does not accept, crash app.

Corey will provide legally binding language to replace placeholder text.

Public Transportation

At our DVRPC meeting yesterday we discussed adding an option for the user to indicate whether they took public transportation at some point in their trip. SEPTA finds this information highly valuable.

Can we split the "Detail" page into two parts:

"Did you use public transportation at some point before, during or after this trip?" [YES][NO] - big fat buttons.

"Anything else you would like to note?"

(see attached)

The "save" should remain active regardless of whether or not someone selects any of those options.

public transport screen

I think we can accomplish this by just converting this screen:

img_2791

Calorie counting

When a user completes a trip, the app creates a summary of the data collected for that trip which the user can access under "my trips." One of the items is a "kCal" estimate of calories burned.

Based on other apps I have used, the numbers the app estimates are much higher than what they should be.

I can't tell what part of the app is calculating calories but it is probably doing it based on some formula. I have done some research and all of the formulas for calculating calories require a person's weight for the calculation. If someone can point me to the code in the app that is calculating the calories, I may be able to figure out how to modify it for a more accurate calorie count.

"Pavement issue" generated automatically.

If I hit "note", then hit "cancel", I would assume that nothing is generated. However, when I go to "My notes", I noticed that a new "Pavement issue" is generated.
photo 2

'Discard' button not implemented

The 'discard trip' option presented after completing a trip doesn't actually do anything, apart from reset the trip recorder. The recorded trip still shows in the list of saved trips.

Noting Issues with Route

Right now when the app is tracking your route live, it does not plot your position, it is only after you have completed your ride that it plots your route. However, there is a "note issue" feature that allows you to make notes about pavement issues, traffic issues etc. The "note issue" function does not work after you complete a ride.

It would be a nice if a user were able to drop pins on the route they just completed to note issues they encountered after the route and then have the app upload that data to the server.

Kevin mentioned he could look into adding this functionality...

One killer feature would be if we could automatically link the "pavement issue" note to the Philly 311 system so that it would automatically upload a repair request to 311! See http://www.phila.gov/311/requestsubmission.html

"Server Unreachable"

Upload error for trips that are at least > 5 minutes. I am able to upload very short trips.

serverunreachable

Readying for iOS7

I have the app installed on my phone and running on iOS7. I want to ready it to submit to the app store and was wondering if any of the warnings I am getting in Xcode would prevent that.

Also, if it were a simple fix, we might want to just update the map UI to the iOS 7 specifications. It looks like the new Xcode pretty much does that but there are some errors.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.