phmatray / talibstandard

TaLib in C# for .NET Standard

Hello 👋, I'm Philippe Matray!

AI doesn't change the game, it just changes the way we play.

I'm Philippe Matray, a Technical Solutions Architect and Coach with a deep passion for innovative technologies and architectures. I guide teams in developing effective solutions and relish in the challenge of turning complex problems into simple, scalable solutions. When I'm not immersed in the tech world, you can find me playing my favorite musical pieces.

🧰 2023 Technology Stack

🎯 My Focus

I am particularly excited about emerging technologies such as Prompt Engineering, DevOps, open source, blockchain, cross-platform and progressive web applications. I utilize my skills in solution architecture and coaching to guide development teams to build high quality, effective solutions.

As a firm believer in the value of methodologies like SCRUM, DDD, TDD, and BDD, as well as Clean Code and Hexagonal architectures, I relish in teaching and instilling these principles into developers' practices to help them reach their full potential.

🌱 How I Work

A developer is first and foremost a creative person... and a creative person's ideas don't necessarily arrive during office hours. 😁 That's why I prefer working remotely, be it day or night, always fueled by caffeine. ☕

💡 My Motto

"A day without learning is a day lost."

📝 MBTI Personality

I'm an INTP (Logician) - my approach to solutions is deeply analytical and I thrive on challenging the status quo.

📫 How to reach me

You can find me on LinkedIn, or send me an Email. Feel free to reach out!

⚙️ 𝗦𝘁𝗮𝘁𝘀

talibstandard's Issues

Request for implement ZigZag indicator

I love this indicator for following Long and Short Time. The rols like this

https://www.investopedia.com/terms/z/zig_zag_indicator.asp

Thx

Could you public to Nuget package?

Not sure, but seems a bug to me

TaLibStandard/src/TechnicalAnalysis.Candles/Candle3WhiteSoldiers/Candle3WhiteSoldiers.cs

Line 75 in 6d23694

return new CandleIndicatorResult(Success, outBegIdx, outNBElement, outInteger);

I'm trying identify patterns right after market opens, in 5 minutes candles. For instance, when I run GetLookback() for Candle3WhiteSoldiers, I got 12, so What I understand is that I have to have 12 5 minute candles to be able to identify this pattern. In other words, I can only identify it after 60 minutes, and I wanted to identify it in the first 20 to 30 minutes. Is it possible to change it to a shorter interval?

The bug I think exists is:

If we don't have enough candles to identify the pattern, it shouldn't return a success message here, but an error message, am I right?

    // Identify the minimum number of price bar needed to calculate at least one output.
    int lookbackTotal = GetLookback();

    // Move up the start index if there is not enough initial data.
    if (startIdx < lookbackTotal)
    {
        startIdx = lookbackTotal;
    }

    // Make sure there is still something to evaluate.
    if (startIdx > endIdx)
    {
        return new CandleIndicatorResult(**Success**, outBegIdx, outNBElement, outInteger);
    }

If I'm wrong, I apologize, I'm a little rusty with programming.
Thanks, and nice job

Bug: Invalid conditions in CandleEngulfing pattern recognition

There are invalid conditions:

These conditions always false except of float, double values (that can be different due to conversion)
In theory these conditions are always false.
I Suggest removing lines 108 and 115.