phoreproject / pm-desktop

OpenBazaar 2.0 Desktop Client (talks to openbazaar-go server daemon)

Phore Marketplace Client v2

This is the reference client for the Phore Marketplace network. It is an interface for your Phore Marketplace node, to use it you will need to run an Marketplace node either locally or on a remote server.

For full installable versions of the Phore Marketplace app, with the server and client bundled together, go to the Marketplace download page.

Getting Started

To create a local development copy of the reference client, clone the client repository into a directory of your choice:

• git clone https://github.com/phoreproject/pm-desktop

Make sure you have Node.js and NPM installed. Node versions older than 8.9.2 or NPM versions older than 5.5.1 may not work.

This client uses Babel to compile ES6 JavaScript. You should be familiar with ES6 before modifying its code.

Installation

1. Navigate to the directory you cloned the repo into.
2. Enter npm install

Running

npm start will:

• compile your Sass / re-compile on changes
• run BrowserSync in watch mode so the app automatically refreshes on JS and HTML changes and dynamically injects any CSS / Sass changes**.
• launch the Electron app

** At this time, the app will not refresh on main.js (or other root folder JS changes). This would require the entire Electron app to refresh and BrowserSync is only refreshing our browser.

Linux Troubleshooting

If you see an ENOSPC error after trying npm start and you are using Linux, you may need to do the following:

1. Enter this on the command line: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p

For Arch Linux add this line to /etc/sysctl.d/99-sysctl.conf: fs.inotify.max_user_watches=524288

2. Execute: sysctl --system

This will prevent your system from having errors due to too many files being watched.

Linting

npm run lint will run eslint on the JS files.

npm run lint:watch will run eslint on any JS file changes.

Testing

npm run test will execute test files in the test folder.

npm run test:watch will execute the tests on any file changes.

Built With

• Electron
• Backbone
• Babel

Contributing

We welcome contributions to the reference client. The best way to get started is to look for an issue with the Help Wanted label.

You can also look for issues with the bug label. These are confirmed bugs that need to be fixed.

Contributions are expected to match the coding style already present in this repo, and must pass es-lint with no errors.

Contributions that make visual changes are also expected to match the repo's current style.

If you want to help with translations, please request to join the translation team at https://www.transifex.com/ob1/openbazaar.

You can request new languages there, and contribute to the translation of existing languages.

New languages are usually added when they reach 80% or more completion, and not removed from the client unless they fall below 60% for several releases.

License

This project is licensed under the MIT License. You can view LICENSE.MD for more details.

pm-desktop's Issues

GUI method to restore seed words

I'd like to see a method added to restore seed words from a prior installation of the Phore Marketplace using the GUI, rather than the current command line method. The current method is:

Have your seed words written down in order, delete your PhoreMarketPlace data directory, download the latest version of PhoreMarketplace, run through the initial setup, close the Marketplace, and do the following (based on Windows):

To restore your wallet seed on Windows:

1. In the Windows search box, enter cmd.exe and click it to open the Command Prompt
2. To find the executable name, type: dir /s openbazaard.exe
3. This will list a directory, and below that will show the openbazaard.exe file. Highlight and copy the DIRECTORY above the file, and type: cd directoryname, pasting in what you copied in place of directoryname.
4. Type the following command to restore your wallet seed, putting your seed words between the double quotes:

openbazaard.exe restore -m "seed words go here"

If you're on Mac, it would have this directory and restore commands instead:

cd /Applications/PhoreMarketplace.app/Contents/Resources
openbazaar-go restore -m "seed words go here"

It would be similar to Mac but slightly different if you were on Linux.

If you have any store listings, those are currently lost in the process. If you want to save them, before doing all the above you would need to copy and paste all the information to a text file so you can paste them back later, and if necessary, download any images you want to transfer.

It might be worth considering having a way to back up (export) and re-import listings, also using the GUI, but that would probably be a separate feature. I don't know if it would make sense to try to combine them, unless there was a simple "backup" command that would create a packaged version of everything needed to restore your prior Marketplace state.

Can't order items with currency set to JPY

Brief Description:

Operating System (OS and version): MacOS High Sierra
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:

1. Choose item
2. Click "BUY NOW" button

Observed Behavior:
Nothing happens.

Expected Behavior:
Go Confirm payment page(Include "PAY" button)

Additional info (links, images, etc go here):

Public builds and uploading to Github Releases

The OB client should be built automatically on tag and uploaded to Github releases.

Follower count on homepage doesn't load correctly

Brief Description: The follow count on your homepage won't load correctly until clicked

Operating System (OS and version): Windows 10 RS4

Phore Marketplace version (shown on About Phore Marketplace page in menu):
v1.3.2

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Always

Steps to reproduce:

1. Click homepage button in top left
2. Observe follow count
3. click followers tab

Observed Behavior:
Followers tab updates with correct number when pressed

Expected Behavior:
Followers tab should have correct number on homepage load

Additional info (links, images, etc go here):

Japanese item name text displays as question marks in listings view

Brief Description:

Operating System (OS and version):
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):

Steps to reproduce:

1. Find pm://QmWwa2kKKyJLrWYeRQrso6DSiis4FEy5CxkwFxc28czhfx/store/- in the listing view

Observed Behavior:

Expected Behavior:
Should show "テスト用商品 調光サングラス ロックブロス"

Following myself

Brief Description:

I have noticed sometimes when I am using a different application, I will get a notification that someone has followed me. When I check in the Phore Marketplace application, the notification shows my own peerID as following me. This often will happen multiple times within a short time span.

Operating System (OS and version): OSX High Sierra

Phore Marketplace version (shown on About Phore Marketplace page in menu): 1.3.0
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):

Steps to reproduce:
1.
2.
3.

Observed Behavior:

Expected Behavior:

Additional info (links, images, etc go here):

Marketplace wallet "need bitcoin"

Brief Description:

Operating System (OS and version): mac high sierra
Phore Marketplace version (shown on About Phore Marketplace page in menu): 1.2.2

The "receive" funds tab in the wallet shows "need bitcoin?" when it should show "need phore?". the link is correct as it takes you to the phore.io page with the listed exchanges where you can buy phore.

Ratings filtering issue

Brief Description: On the main Phore search page, the rating is set to 5 stars. If you change the rating to 1 Star, everything remains to be displayed. However selecting any other rating at this point leads to no results. This could be an issue due to the fact there are no ratings yet?

Operating System (OS and version): Windows 10
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:

1. Enter the Phore Marketplace
2. Click the radio button "One start & Up"
3. Click any other radio button
4. All listings are removed "No listings match your search criteria"

Observed Behavior:
Selecting any Rating other than One Star & Up removes all the listings.

Expected Behavior:
If the page loaded at 5 stars, clicking back to it should display all items.

Additional info (links, images, etc go here): This could be related to issue #33 where perhaps since there are NO ratings at this time, the default filters aren't working well.

Store Owner Icon on Product Pages shows default unless Refreshed

Brief Description:

Operating System (OS and version): Mac OS High Sierra 10.13.3
Phore Marketplace version (shown on About Phore Marketplace page in menu): 1.3.5
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Always

Steps to reproduce:

1. Click into a product page
2. Icon for Store Owner (top left) is showing the default silhouette avatar
3. Refresh the page and the icon loads correctly

Observed Behavior:
The icon shows default fallback icon when product page is clicked

Expected Behavior:
The icon should load the user's uploaded icon without having to click refresh

Additional info (links, images, etc go here):

The DMG installer (maybe others) still has an OpenBazaar graphic

Brief Description:

Attached screenshot of Mac dmg installer.

Operating System (OS and version):
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):

Steps to reproduce:
1.
2.
3.

Observed Behavior:

Expected Behavior:

Additional info (links, images, etc go here):

Typo in wallet tab

Brief Description:
See image.

Operating System (OS and version):
Windows 10 Build 17120.rs4_release.180309-1616

Phore Marketplace version (shown on About Phore Marketplace page in menu):
Couldn't find the about tab anywhere :(

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Always

Steps to reproduce:

1. Click on wallet tab in the marketplace application

Observed Behavior:
1 PHR = 1.70679 PHR PHR

Expected Behavior:
Not sure, maybe 1 PHR = 1.70679 USD?

Additional info (links, images, etc go here):

Update UI

Make Phore OB look unique.

Text color in "confirm Payment" windows

Brief Description:

Operating System (OS and version):
Phore Marketplace version (shown on About Phore Marketplace page in menu): v1.3.2
Hardware: Windows 8.1

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:

1. Select item
2. click "BUY NOW" button
3. click "PAY" button

Observed Behavior:
Popup a windows with "Everything look good? If yes, please proceed to the final step." in white text color.

Expected Behavior:
in black or other text color

Additional info (links, images, etc go here):

The windows name is "confirmPayment" window in en_US.json

Default currency is USD

Brief Description:

Operating System (OS and version):
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):

Steps to reproduce:
1.
2.
3.

Observed Behavior:
Default currency is set to USD

Expected Behavior:
Default currency should be PHR

Additional info (links, images, etc go here):

Suggestions & Toggling the Ratings leads to no results

Brief Description: If using Suggestions, any toggling of the ratings buttons will not allow the user to ever clear the search and get back to the main page. Only a refreshing of the phore marketplace will wipe the 'slate' clean. See steps below

Operating System (OS and version): Windows 10
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:

1. Use any 'Suggestion', click on it
2. Change the Rating to 1 Star & Up
3. Change the Rating back to 5 stars
4. Remove the suggestion name in the search box, click search
5. No matter what you do at this point, unless you reload via the Discover button in the toolbar, will always return "No listings match your search criteria"

Observed Behavior:
"No listings match your search criteria"

Expected Behavior:
After clearing out any words in the Phore search box and clicking search, it should default to the main Phore Marketplace screen.

If you don't not toggle the ratings, you can remove the search word, click the search button, and see the default page. The toggling of the ratings is screwing it up.

Additional info (links, images, etc go here):

Product Tags do not work within Search

Brief Description:

Operating System (OS and version): MacOS High Sierra 10.3.3
Phore Marketplace version (shown on About Phore Marketplace page in menu): 1.3.5
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Almost Always

Steps to reproduce:

1. Go to "Discover"
2. Click a tag next to "Suggestions" just below search bar
3. (Alternatively, you could just click the tag within a product page itself, such as: pm://QmT4DkgaJYpoU9SdE2pZ7ZXHz6gUnSo75NwAaCyojxc9kK/store/phore-t-shirt-mens

Observed Behavior:
Clicking a tag which we know exists within products does not pull any results results in the search area with the message: "No listings match your search criteria"

Expected Behavior:
Search engine should retrieve items with matching tags.

Additional info (links, images, etc go here):

Default name starts with OB

Brief Description:

Operating System (OS and version): OSX High Sierra
Phore Marketplace version (shown on About Phore Marketplace page in menu): v1.2.2
Hardware: MacBook Pro

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:
1.
2.
3.

Observed Behavior:
During initial setup, default name starts with the letters OB.

Expected Behavior:
Suggest starting default names with PM.

Additional info (links, images, etc go here):

Pay popup confirmation is empty

Brief Description: Click on pay for an item and observe an empty confirmation. See image.

Operating System (OS and version): Windows 10 RS4

Phore Marketplace version (shown on About Phore Marketplace page in menu):
1.3.2

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Always

Additional info (links, images, etc go here):

Add featured items

Allow search engines to select some items as featured.

Windows desktop notification and in-app notification for follows show different things (address vs name)

Brief Description:
See image. Not sure if this was intended to be the address or the name. The in-app notification shows the name (but it seems to be cutoff).

Operating System (OS and version):
Windows 10 RS4

Phore Marketplace version (shown on About Phore Marketplace page in menu):

Hardware:

Steps to reproduce:

1. Have someone follow you.
2. See notification in corner of windows 10. It has the address of the store that followed you.
3. See notification in the app. It has the name (but cutoff) following you.

Additional info (links, images, etc go here):

Some packages are named phoremarketplace, others are named OpenBazaar.

Brief Description:

Operating System (OS and version):
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):

Steps to reproduce:
1.
2.
3.

Observed Behavior:

Expected Behavior:

Additional info (links, images, etc go here):

double-clicking and clicking maximize window button give differential behavior

Brief Description:
differential behavior within double-clicking title bar and clicking maximize window button

Operating System (OS and version): Windows 8.1, 7
Phore Marketplace version (shown on About Phore Marketplace page in menu):
Hardware:

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Always

Steps to reproduce:

1. Double click title bar of phore marketplace application
2. clicking maximize windows button
3. The behavior are differ

Observed Behavior:
The behavior are differ.

Expected Behavior:
the behavior should be same.

Additional info (links, images, etc go here):

Fix Update Checker

The update checker should work on the correct windows.

Clicking Learn More on verified moderators not working

Brief Description:

When you click on the Learn More link in the Verified Moderators box, it displays a page on search.phore.io that says:

Cannot GET /verified_moderators.html

Japanese translation is not working