photobackup / api Goto Github PK

Currently error code 401 is used both when the server is misconfigured (no password has been set) and when the request was incomplete (not upfile was included). Server problems like the misconfigured password should really all go in the 5xx, 4xx codes are client errors.

For version 3 of the API these should really be split up.

For version 2 of the API the description of the 401 response on /test should clarify it is specifically about the server configuration and not about the client forgetting to send a password.

Sidenote: PhotoBackup/server-bottle currently does not follow the API, by responding with 401 on / if the server is misconfigured. 401 is described in the API as the error code for missing upfile. Either the Python server implementation has to be changed or the API has to be updated to add this secondary meaning for /.

Some BREAKING adjustments are needed, see issue 2 and PR3 for the discussion.