Pluggable functions non-pluggable in stubs about wordpress-stubs

[szepeviktor]

core-stubs.php

<?php

function apple(): void
{
    echo 'Apple is a fruit';
}

app.php

<?php

if (! function_exists('apple')) :

function apple(): void
{
    echo 'Apple is a juicy fruit';
}

endif;

phpstan analyse -a core-stubs.php -l max app.php

 [OK] No errors

[szepeviktor]

Thank you again for your suggestion.

is wrapped in an if ( ! function_exists ) block. The stubs for these should ideally be treated the same

Just wrap your functions overriding core functions in function_exists.

[mallardduck]

While that was one option I considered, I ruled this out as my implementation is maintained by me I'd rather mine be analysed in my project by PHPStan than use the stub implementation.

From the looks of it, this repo uses another one of @GiacoCorsiglia to generate the stubs and I'd guess this underlying library doesn't account for the functions that wp-core if wraps. So if they're active or around then maybe I could help fix that upstream.
However per your other comments though it seems they may not be as active to accept the PR?

[szepeviktor]

I'd rather mine be analysed in my project by PHPStan than use the stub implementation.

Actually PHPStan does analyze your code.

Changing app.php to

<?php

if (! function_exists('apple')) :

function apple(): void
{
    echo 'Apple is a juicy fruit';
    return $horribleError;
}

endif;

produces 2 errors

 ------ --------------------------------------------------------------------------------------
  Line   app.php
 ------ --------------------------------------------------------------------------------------
  8      Function apple() with return type void returns mixed but should not return anything.
  8      Undefined variable: $horribleError
 ------ --------------------------------------------------------------------------------------

[mallardduck]

Sorry - I may be a bit confused about PHPStan's inner workings, or poorly explained my thought/concern.

My thought was that the areas of my code/wp-core that utilize said function would analyze it differently if it associated it with the stub vs with my implementation.

However now that I write that out I realize that's an assumption I've made about how PHPStan connects/associates different areas of code during analysis.