Comments (4)
I guess we should never store a signature without a valid/empty signature hash? Now it seems that may happen.
For the scanning itself, don't know how risky this change is or if this is enough to handle faulty signatures (functions.php/row 3141):
private function splitSigParts($sig, $max = -1)
{
// PREG_SPLIT_NO_EMPTY removed
return preg_split('~(?<!\?|\<)\:~', $sig, $max);
}
Then VN[1] will be returned but as empty value, which means VN[2] will not wrongly be used as signature hash. That along with following change (functions.php/row 2534):
// Filter out faulty signatures
if (!isset($VN[1]) || empty($VN[1])) {
continue;
}
from sigtool.
Added some additional logging to missing and empty signatures during scan, which brought up the total invalid signatures:
Anti-virus: Signature errors during file scan: 83 of 35561
Last error message: Signature hash missing or empty
Last signature: � ��Vbs.Trojan.PowerShell-5705194-0:
~80 empty signatures found
from sigtool.
I've made a few minor changes to the SigTool since the time that this issue was first created, since we'd last discussed it. If you get a spare moment, would you be able to test it out again, to let me know whether these invalid signatures still persist in signature files freshly generated by SigTool as of the current latest commit? Cheers. :-)
It appears to be okay now at my end, but I'd be more confident about the problem being actually solved if it could be confirmed by way of a second opinion (after which, I could close this off, or.. if the invalid signatures still persist, I could try to explore some new avenues of testing and so on).
from sigtool.
Marking as fixed and closing.
from sigtool.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sigtool.