phpsrbija / unfinished Goto Github PK

Consider:

• Using DataTable for listing records (Page, Article's, Categories...)
• Move delete/status buttons from Edit to Index actions to be in table next to edit button.
• Exception collecting and revealing them on the template as some kind of notification.
• Adding global config module for Global site SEO meta data (title, desc, image, og:img....)
• Adding default seo input fields in modules that are exposed directly on Front.
• If it is considered at all for website to be multilang at some point. In that case it is necessary to change the logic immediately because there is not much content yet and to continue developing this way. The juniors and everyone who contributes will be able to learn a lot through a multilang system that I believe each of us regularly meets And also the content on front 'll be much organized, transparent because it is now linguistically mixed.

That's it for now :)

Consider switching to some mass mail service (mailchimp, mailgun) and subscribing through service API's.
Or implementing reCAPTCHA (similar protection system) because DB 'll be filled with spam subscriptions if not already (bots are madness :) ).

I advise using from the beginning of the project some Translation component, as from my experience, it would be much harder to implement it later.
I advice using Symfony translation component.
I will help with integration.

Consider using Twig template engine(or some other), to avoid having PHP statements in template files.
Also to get rid of PHP short tag expressions :)

Just Sing up it is free and allow this repo to be scanned. Visit link: https://styleci.io/
How to add badges: https://styleci.readme.io/docs/badges

Why styleCi:

StyleCI provides checks for both your open and closed source repos.
By analyzing every push or pull request made on your repo, 
StyleCI ensures that your code is always written against the standards you want it to be.

Proposal look:

[![StyleCI](https://styleci.io/repos/65193755/shield)](https://styleci.io/repos/65193755)

FP: Pacages\Page\Controller\PageController

....
public function edit($errors = []): HtmlResponse
{
        $id = $this->request->getAttribute('id');
        $page = $this->pageService->getPage($id);
        if ($this->request->getParsedBody()) {
            $page = new \Page\Entity\Page();
            $page->exchangeArray($this->request->getParsedBody() + (array) $page);
        }
}

Here: $page->exchangeArray($this->request->getParsedBody() + (array) $page);
ID of page is not part of Parsedbody so you will not hydrate page_id property of Page Entity class.
And if there where some errors as part of response you will get bad form action URL.

For easier project and PR tracking and categorization, would be nice to have milestones, like project versions, and also labels for easier Issues filtering, like API, UI, i18n, High Priority, etc.

Move declare(strict_types = 1); to single point.
Maybe to index.php?