pilipolio / pyrsvd Goto Github PK

What steps will reproduce the problem?
1. Install NumPy version 1.5.0rc1 or 1.5.0b2.
2. Attempt to install PyRSVD.
3. PyRSVD installer dies with a ValueError stack trace.  

What is the expected output? What do you see instead?
Expected PyRSVD install.  Got a crash with stack trace.  Problem near line 45 
in rsvd.__init__.py.

What version of the product are you using? On what operating system?
PyRSVD 0.1 and NumPy 1.5.0rc1 on Ubuntu Linux 10.04.

The attached patch fixes 2 issues:
1) it was not possible to install pyrsvd in a virtualenv as it was
always looking for numpy include files in the global python include path
- now it will try finding it in the virtualenv first
2) when the numpy package was missing a really bad and long error
information was displayed by the C compiler - now it will complain about
missing numpy

Pasting it inline as I had problems attaching a file:

Index: setup.py
===================================================================
--- setup.py    (revision 27)
+++ setup.py    (working copy)
@@ -1,9 +1,17 @@

 from distutils.core import setup
 from distutils.extension import Extension
+import os.path
+
+import numpy
+numpy_path = os.path.join(numpy.__path__[0], 'core', 'include')
+
 setup(
    name = "rsvd",
-    ext_modules = [Extension("rsvd/rsvd", ["rsvd/rsvd.c"])],
+    ext_modules = [Extension("rsvd/rsvd", ["rsvd/rsvd.c"],
+                             include_dirs=[numpy_path],
+                             ),
+                  ],
    version = "0.1",
    description="A regularized SVD solver for partial matrices",
    author='Peter Prettenhofer',

==================
I tested in on a 64bit Linux box - both on few virtualenvs and on my
system Python