pilsburgh / django-forum Goto Github PK

Include manage.py and settings.py so that it is easier to run djangoforums
as a standalone project. It's also nicer to develop with (imo).

The settings-customize.py and local_settings-customize.py files are meant
to be copied and renamed (to settings.py and local_settings.py). With these
additions it's possible to do that copying, set database settings, add a
forum in admin and immediately have a working site. Or it will be once I
submit a patch for the URLs.

Most views aren't using select_related() appropriately (mainly due to using
get_object_or_404) and as such there are too many queries.

EG in a thread view, a separate 'user' query is done for each post to show
the username.

In the forum_list.html tempalate 'forum.forum_latest_post' function is 
called 4 times, thus you get 4 identical SQL queries instead of one. This 
can be optimized using {% with... %} template funciton.

Also the same issue with thread_list.html. See the patch:

One thing I noticed was you use if user.is_authenticated: rather than if
user.is_authenticated(): in a bunch of places. I think the latter is
correct.  I'll supply a patch once the email notification is done unless
you get to it.

wouldn't it make sense if you could subscribe to a forum via RSS?  that
will  be my next goal.  let me know what you think.

What steps will reproduce the problem?
1. Follow steps in Getting Started
2. Access /forum
3. Create a new thread

What is the expected output? What do you see instead?
Expect to view the thread.  Instead get error compaining about non-
existent templatetag in "{% load markup %}

What version of the product are you using? On what operating system?
Trunk.  Ubuntu 8.04

Please provide any additional information below.
Basically in the getting started you just need to add another step.  
django.contrib.markup needs to be added to the installed settings, and the 
markdown python module needs to be installed on the system if it is not 
already.

You are using {% url formsubs %} in forum_list.html and thread.html, which
seem to not exist. 

In urls.py you have named the url as "forum_subscriptions".

ImportError at /forum/
cannot import name ugettext
Request Method:     GET
Request URL:    http://127.0.0.1:8000/forum/
Exception Type:     ImportError
Exception Value:    cannot import name ugettext
Exception Location:     F:\myapp\forum\models.py in , line 12

Is there any rationale behind naming the app "djangoforum"? "django" 
seems to be redundant here - for example,  generated table names are 
like "djangoforum_post", while "forum_post" would make more sense.

Take a look at other Django applications round here - 
django-registration, django-tagging, etc. - they do not use "django" 
prefix.

What steps will reproduce the problem?
1. follow instructions in README.txt
2. add django.contrib.markdown to INSTALLED_APPS
3. refresh forum page

What is the expected output? What do you see instead?
Forum HTML and forum content. Instead you get a traceback about markdown not 
being a 
module.

What version of the product are you using? On what operating system?
Latest SVN trunk, Rev. 22.


Please provide any additional information below.
The docs just need to be modified to read django.contrib.markup instead of 
django.contrib.markdown.

I love love forum Ross!  I would really like Sub-forums.  Is this something
you are planning on adding?

Erik

Hello, here's the Russian translation for django-forum.

Hello, I did a extension on django-forum, for use as a private forum. Forums 
can simply be 
asigned to be private by checking a Checkbox.

For me it works. Maybe also for you.

Sorry for my bad english

Index: lib/forum/feeds.py
===========================================================
========
--- .   (revision 28)
+++ .   (working copy)
@@ -47,7 +47,7 @@
         if obj:
             return Post.objects.filter(thread__forum__pk=obj.id).order_by('-time')
         else:
-            return Post.objects.order_by('-time')
+            return 
Post.objects.filter(thread__forum__is_private=None).order_by('-time')

     def items(self, obj):
         return self.get_query_set(obj)[:15]
Index: lib/forum/models.py
===========================================================
========
--- .   (revision 28)
+++ .   (working copy)
@@ -26,7 +26,8 @@
     description = models.TextField(_("Description"))
     threads = models.IntegerField(_("Threads"), default=0)
     posts = models.IntegerField(_("Posts"), default=0)
-
+    is_private = models.BooleanField('Privat', blank=True, null=True)
+    
     def _get_forum_latest_post(self):
         """This gets the latest post for the forum"""
         if not hasattr(self, '__forum_latest_post'):
Index: lib/forum/views.py
===========================================================
========
--- .   (revision 28)
+++ .   (working copy)
@@ -28,6 +28,9 @@
     f = get_object_or_404(Forum, slug=slug)

     form = CreateThreadForm()
+    
+    if f.is_private and request.user.is_staff != True:
+        return HttpResponseRedirect('/forum')

     return object_list( request,
                         queryset=f.thread_set.all(),
@@ -45,6 +48,10 @@
     posts for that thread, in chronological order.
     """
     t = get_object_or_404(Thread, pk=thread)
+    
+    if t.forum.is_private and request.user.is_staff != True:
+        return HttpResponseRedirect('/forum')
+    
     p = t.post_set.all().order_by('time')
     s = t.subscription_set.filter(author=request.user)

Setuptools-compatibility makes it much easier to use django-forum in an
automated build, or to publish as an egg on PyPI so others can just
easy_install. 

- Create a directory 'forum' underneath tunk
- Move all the current files into there
- Drop the attached setup.py into trunk (ie. into the directory above the
new forum directory) 

I did some modifications that greatly reduce a number of sql queries. The 
number of queries no longer depends on the number of threads, posts or 
users. For instance only 1 query is used to fetch all the threads along 
with their latests posts and authors. Thanks to 'select_related' django's 
method which is just genious! :)

Unfortunately some of these changes break backward-compatibility, as I 
have added a new field 'latest_post' to 'forum' and 'thread' tables. So I 
don't know if you decide to merge it, but for me it's defenitely worth to 
have.

Fixed a link problem and added some internationalization stuff. Hope you
like it hohoho. 

It would be great to be able to create forum for multiple site with one 
instance of django-forum.

I've made a patch that enable that and attached it below.

It would be great to use django.forms. So I've started the work with the 
following patch.

It could be improved and I will try to provide another patchs as soon as I have 
done it.

Many of the templates provide links to update thread subscriptions. However, 
hitting the 
updatesubs view as an AnonymousUser just gives you a message saying that you 
need to be logged 
in. It makes sense to leave that check in the view, but it's probably 
friendlier for the user to just 
hide that link from them.

Attached is diff that checks for authenticated users before showing the Update 
Subscriptions link.

Ross, thanks for putting my subscriptions patch in, but now I think I
should have really use the notifications app.  Hah!

What do you think about allowing an image to be upload and associated into
the post?

Also what do you think about supporting some kind of markdown or formatting
syntax?  Even just filtering the output through urltrunc:80|linebreaks
would be nice.

Deleting a post in admin interface deletes all the related posts, threads,
and forums.

When viewing a Thread as an AnonymousUser, I log a ProgrammingError on the 
subscriptions filter 
of the Thread object.

I'm on revision 28. I've attached a diff that would fix the problem.

non-ascii characters fail for str function. just change them with unicode

Clicking on "Forums" in the top nav sends user to <a href='{% url
forum_index %}/'> in forum_list.html. Clinks on that links result in a 404
because the user is sent to forums// instead of forum/ 

Fixed by removing extra slash from end of link:

old:
<a href='{% url forum_index %}/'>

new:
<a href='{% url forum_index %}'>

This is same as Issue 36. Sorry for recreate.

Because, it still gives me this error after get latest versions. 

Message is "Caught an exception while rendering: Reverse for 
'school.forum_index' 
with arguments '()' and keyword arguments '{}' not found."

And sometimes after click refresh button of browser, gives "Caught an 
exception while 
rendering: Could not import date_based. Error was: No module named 
date_based"

Thank you in advance.

Thread.objects.filter().order_by('-thread_latest_post')[:10]

Not sure if the above code is supposed to work or not, but it did in
previous versions.  Now I just get:

FieldError: Cannot resolve keyword 'thread_latest_post' into field. Choices
are: closed, forum, id, latest_post_time, post, posts, sticky,
subscription, title, views


Seems by using the thread_latest_post = property(_get_thread_latest_post)
pattern in the model may have broken something.  Or this may be a bug in
Django or my code?

What steps will reproduce the problem?
1. Install SVN 23 according to instructions on project home page
2. add a forum
3. navigate to localhost/forum

What is the expected output? What do you see instead?
Get the following error:

TemplateSyntaxError at /forum/

Caught an exception while rendering: Reverse for 'mysite.forumsubs' with
arguments '()' and keyword arguments '{}' not found.

Original Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/django/template/debug.py", line
71, in render_node
    result = node.render(context)
  File "/usr/lib/python2.5/site-packages/django/template/defaulttags.py",
line 378, in render
    args=args, kwargs=kwargs)
  File "/usr/lib/python2.5/site-packages/django/core/urlresolvers.py", line
252, in reverse
    *args, **kwargs)))
  File "/usr/lib/python2.5/site-packages/django/core/urlresolvers.py", line
241, in reverse
    "arguments '%s' not found." % (lookup_view, args, kwargs))
NoReverseMatch: Reverse for 'mysite.forumsubs' with arguments '()' and
keyword arguments '{}' not found.

Here is various templatetags that would be useful for django-forum :

* {% latest_posts 5 as latest %} = return the last 5 posts in the context with 
the name "latest" %}
* {% latest_for_user user 10 as user_message %} = return the last 10 posts of 
user "user" in the 
context with the name "user_message" %}
* {% forums as forums %} = return a list of the forum in the context with the 
name forums

I will try to develop some of them and provide a patch.

 When we delete this post django marks the parent forum of this item for
removal. Same for latest thread in thread model.

I'm using django-forum with mysql 5.0.44 and django 0.97.

 The possible reason is: forum use 'forum_latest_post'(thread use
'thread_latest_post') as foreign key to the last post.

I've attached patches.

http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#_nolongerinbuilt
ins


Index: models.py
===================================================================
--- models.py   (revision 14)
+++ models.py   (working copy)
@@ -9,6 +9,7 @@
 import datetime
 from django.contrib.auth.models import User
 from django.conf import settings
+from gettext import gettext as _

 class Forum(models.Model):
     """

When using the template i get the error:

Invalid block tag: 'blocktrans' with notify.txt

two fixes:

1: missing "{% load i18n %}" at the top of notify.txt

2: missing "with"

old:

{% blocktrans site.name as site_name and site.domain as domain and
thread.get_absolute_url as url %}You received this message because you
subscribed to a forum thread at {{ site_name }}.  Login at this URL to
update your subscriptions: http://{{ domain }}{{ url }}{% endblocktrans %}

new:

{% blocktrans with site.name as site_name and site.domain as domain and
thread.get_absolute_url as url %}You received this message because you
subscribed to a forum thread at {{ site_name }}.  Login at this URL to
update your subscriptions: http://{{ domain }}{{ url }}{% endblocktrans %}

The threads title is unescaped in the forum_list.html, this could lead to a
XSS attack. I'm aware that recent django versions use autoescape by
default, but I guess it won't hurt to make this change.
A similar vulnerability can be found in the breadcrumbs in thread.html
where the title is also shown.

Regards, Sean

If you are using the latest rev. of Django with Newforms-admin, you will need 
an admin.py file in 
the forum/ dir. The simplest one would look like this:

from django.contrib import admin
from forum.models import Forum, Thread, Post

admin.site.register(Forum)
admin.site.register(Thread)
admin.site.register(Post)

However, I suspect there may be a better way to make this more portable. I'm 
glad to help make 
that happen once I learn a little more about newforms-admin.

One style= attribute should be class=.  There are also two label elements
that are for elements with names but no IDs - label requires an ID or
nesting (i.e. <label>description <input/></label>).

I get an import error because '_' is used in views.py but not imported. 
Patch attached.

What steps will reproduce the problem?
1. Clicking "Post" Button on "Create Thread" without filling in title or body.
2. Clicking "Submit" Button on "Post a Reply" without filling in body.

What is the expected output? What do you see instead?
Expected output would be error messages stating that fields are required,
instead returns a ValueError "The view forum.views.reply didn't return an
HttpResponse object."

What version of the product are you using? On what operating system?
using python v2.5.2 w/ django 1.0 on linux apache install w/ mod-python

Please provide any additional information below.
Overall App is very nice..thanks!

I've made some changes to move to newforms
someone would upload these to svn?!

See the attached diff:

I've got a error on latest django trunk:

" 'blocktrans' doesn't allow other block tags (seen u'endblock') inside it"

It should be 'endblocktrans' instead of endblock there, see patch:

After install via svn i get the following template error:
'blocktrans' doesn't allow other block tags (seen u'plural') inside it

Sorry, iam new in django, don't know if its realy a bug.


line:
{% blocktrans with forum.threads as thread_count and forum.posts as
post_count %}{{ thread_count }} thread, {{ post_count }} posts{% plural
%}{{ thread_count }} threads, {{ post_count }} posts{% endblock %}

fix:
{% blocktrans with forum.threads as thread_count and forum.posts as
post_count %}{{ thread_count }} thread, {{ thread_count }} threads, {{
post_count }} posts{% endblocktrans %}

I removed "{{ post_count }} posts{% plural %}" and changed "endblock" in
"endblocktrans".

What steps will reproduce the problem?
1. Followed installation instructions.

What is the expected output? What do you see instead?
At   http://localhost:8000/forum/movies    I expect to see a forum, instead
I get a template error. See appended error message below.

What version of the product are you using? On what operating system?
django-forum SVN-release 28
Django 1.0
Ubuntu 8.04

Please provide any additional information below.

Environment:

Request Method: GET
Request URL: http://localhost:8000/forum/skits/
Django Version: 1.0-final-SVN-unknown
Python Version: 2.5.2
Installed Applications:
['django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.admin',
 'peoplecode.adresbeheer',
 'peoplecode.address',
 'peoplecode.agenda',
 'peoplecode.almanac',
 'peoplecode.budget',
 'peoplecode.edit',
 'peoplecode.event',
 'peoplecode.export',
 'peoplecode.fee',
 'peoplecode.file',
 'peoplecode.fields',
 'peoplecode.forum',
 'peoplecode.general',
 'peoplecode.importbook',
 'peoplecode.info',
 'peoplecode.invite',
 'peoplecode.login',
 'peoplecode.labels',
 'peoplecode.messages',
 'peoplecode.people',
 'peoplecode.photo',
 'peoplecode.photobook',
 'peoplecode.photogallery',
 'peoplecode.search',
 'peoplecode.sharing',
 'peoplecode.signup',
 'peoplecode.selectionfield',
 'peoplecode.usersettings',
 'peoplecode.visit',
 'peoplecode.write']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.middleware.doc.XViewMiddleware')


Template error:
In template /home/wim/peoplecode/forum/templates/forum_base.html, error at
line 4
   Caught an exception while rendering: Reverse for
'peoplecode.forum_index' with arguments '()' and keyword arguments '{}' not
found.
   1 : {% load i18n %}<html>


   2 : <head>


   3 : <title>{% block title %}{% endblock %}</title>


   4 : <link rel="alternate" type="application/rss+xml" title="All Latest
Posts via RSS" href=" {% url forum_index %} rss/" />


   5 : <link rel="alternate" type="application/atom+xml" title="All Latest
Posts via ATOM" href="{% url forum_index %}atom/" />


   6 : {% block extrahead %}{% endblock %}


   7 : </head>


   8 : <style type='text/css'><!--


   9 : body {


   10 :     font-family: Verdana;


   11 :     font-size: 10px;


   12 :     text-align: center;


   13 : }


   14 : 


Traceback:
File "/usr/lib/python2.5/site-packages/django/core/handlers/base.py" in
get_response
  86.                 response = callback(request, *callback_args,
**callback_kwargs)
File "/home/wim/peoplecode/forum/views.py" in forum
  39.                             'form': form,
File "/usr/lib/python2.5/site-packages/django/views/generic/list_detail.py"
in object_list
  101.     return HttpResponse(t.render(c), mimetype=mimetype)
File "/usr/lib/python2.5/site-packages/django/template/__init__.py" in render
  176.         return self.nodelist.render(context)
File "/usr/lib/python2.5/site-packages/django/template/__init__.py" in render
  768.                 bits.append(self.render_node(node, context))
File "/usr/lib/python2.5/site-packages/django/template/debug.py" in render_node
  71.             result = node.render(context)
File "/usr/lib/python2.5/site-packages/django/template/loader_tags.py" in
render
  97.         return compiled_parent.render(context)
File "/usr/lib/python2.5/site-packages/django/template/__init__.py" in render
  176.         return self.nodelist.render(context)
File "/usr/lib/python2.5/site-packages/django/template/__init__.py" in render
  768.                 bits.append(self.render_node(node, context))
File "/usr/lib/python2.5/site-packages/django/template/debug.py" in render_node
  81.             raise wrapped

Exception Type: TemplateSyntaxError at /forum/skits/
Exception Value: Caught an exception while rendering: Reverse for
'peoplecode.forum_index' with arguments '()' and keyword arguments '{}' not
found.

Original Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/django/template/debug.py", line
71, in render_node
    result = node.render(context)
  File "/usr/lib/python2.5/site-packages/django/template/defaulttags.py",
line 378, in render
    args=args, kwargs=kwargs)
  File "/usr/lib/python2.5/site-packages/django/core/urlresolvers.py", line
252, in reverse
    *args, **kwargs)))
  File "/usr/lib/python2.5/site-packages/django/core/urlresolvers.py", line
241, in reverse
    "arguments '%s' not found." % (lookup_view, args, kwargs))
NoReverseMatch: Reverse for 'peoplecode.forum_index' with arguments '()'
and keyword arguments '{}' not found.

What steps will reproduce the problem?
1. make a forum and a post, using a new django project

What is the expected output? What do you see instead?
TemplateSyntaxError at /forum/thread/1/
'markup' is not a valid tag library: Could not load template library from
django.templatetags.markup, No module named markup


It's an easy fix by adding django.contrib.markup to your INSTALLED_APPS,
but it should be in the instructions.

What steps will reproduce the problem?
1. View any thread.
2. See a traceback about "save() takes exactly 1 argument (3 given)".

What is the expected output? What do you see instead?
Thread HTML is expected.

Instead I see this traceback:
Traceback:
File "/home/xxxxx/lib/python2.5/django/core/handlers/base.py" in get_response
  85.                 response = callback(request, *callback_args, **callback_kwargs)
File "/home/xxxxx/webapps/str/forum/views.py" in thread
  43.     t.save()
File "/home/xxxxx/webapps/str/forum/models.py" in save
  171.         f.save()
File "/home/xxxxx/webapps/str/forum/models.py" in save
  112.         super(Forum, self).save(force_insert, force_update)

Exception Type: TypeError at /forum/thread/1/
Exception Value: save() takes exactly 1 argument (3 given)

What version of the product are you using? On what operating system?
I am currently on rev. 24 of django-forum and rev. 8066 of geodjango branch.

Please provide any additional information below.
I suspect this is a problem with my django version, but wanted to report it 
just in case.

 Index: README.txt
===================================================================
--- README.txt  (revision 13)
+++ README.txt  (working copy)
@@ -35,7 +35,7 @@
 ---------------

    1. Checkout code via SVN into your python path.
-       svn co http://django-forum.googlecode.com/svn/turnk/ forum
+       svn co http://django-forum.googlecode.com/svn/trunk/ forum
    3. Add 'forum' to your INSTALLED_APPS in settings.py
    4. ./manage.py syncdb
    5. Add FORUM_BASE='/forum' to your settings.py (no trailing slash)

I created a module that turns django-forum compatible with NewForms-Admin
branch.

In attachment.

One feature I was thinking this needs is email/sms notification.  So you
get a message when someone responds to a message/post you wrote or thread
you started.  By default you would get it and have the option to opt-out on
anything as well.

I might give this a whirl and see how far I get, let me know if you would
also like this feature or have other input.

where is it?)

return HttpResponseServerError() instead ... i think u mean this.

Allow users to host the forums at any URL they choose. This patch requires
FORUM_BASE to be set to something like '/forum' or ''.