pilzadam / mobs Goto Github PK

Hello, I've been trying to fix licensing issues in Minetest, including in multiple pull requests TenPlus1 accepted in the past year. The readme here implies you created everything other than models. Is that correct? I can't figure it out:

• Sep 21, 2012 You committed the fireball for the DM
• Sep 19, 2012 (2 days earlier) sapier committed a DM sprite (but not a fireball? I can't find it in there anywhere, and the sapier github account has no animals_modpack repo).
• The minetest.net wiki shows the sapier version using the fireball as in your repo, but I can't find a DM using it anywhere else other than in TenPlus1's mobs_monster.
  • In my license pull request to TenPlus1, I attributed sapier for the fireball--maybe that's incorrect and another change is necessary.

I am confused as to how you seem to be the first mobs mod, according to initial comments on your official thread, but that somehow mobf has commits earlier that your repo has commits--maybe you had it somewhere else before you had it on GitHub(?). So, who made the fireball?

Thanks.

it is because self.follow wasn't check for nil (1) and it reset the self.v_start (2)
causing it to always enter here (3) and never here (4)

1. mobs/api.lua

   Line 239 in c49cc47

   if self.follow ~= "" and not self.following then

2. mobs/api.lua

   Line 253 in c49cc47

   self.v_start = false

3. mobs/api.lua

   Line 351 in c49cc47

   if not self.v_start then

4. mobs/api.lua

   Line 354 in c49cc47

   else

shouldn't it be not self.disable_fall_damage?
currently, if disable_fall_damage is true then it enter the code and do damage

ps: i couldn't think of a better title :|

I would like to depend on this mod so that it can provide an API for me to create other mobs, however I don't want the user to be forced to have the mobs that are builtin to this mod.

Not sure the best way to allow my mod to disable the mobs in your mod.

Let me know your thoughts.