pingping1997 / cementat

CO2 Emission and Transportation of Austrian Cement Industry (370.062 Open Source Energy System Modelling, the 1st homework)

• 👋 Hi, I’m @Pingping1997
• 👀 I’m focusing on the integration of CCS/CCU and systems modelling.
• 👀 I’m also interested about optimization under uncertainty.
• 🌱 Optimization & Data: Julia, Python, GAMs, R, VS Code user & learner.
• 🌱 Life Cycle Assessment: Brightway, Activity-Browser, SimaPro, openLCA, econivent, prospective LCA.
• 💞️ Process systems engineering & Carbon Capture, Storage, Transportation and Utilization.
• 📫 Feel free to reach me by [email protected]

cementat's Issues

Evaluation of the first homework assignment

Overview

This is the evaluation for the first homework assignment.

There are no GitHub Actions workflows implemented in this repository to automatically execute the tests upon a pull request.

Grade

Sufficient (4)

Other comments

1. The readme is very detailed and the code looks ok at a quick glance.
2. It's better to put the author/copyright and license statement at the top of the readme.
3. You should add a requirements.txt listing the necessary packages so that a user can easily see the dependencies.
4. Your tests in Python simply checks that the R script finished without any errors - it doesn't check whether the values obtained are correct. This is not a good testing strategy.
5. You committed the py-cache folder to the repository. This makes it more complicated for a new user to identify what is relevant, and creates noise in the version history. Better to add __pycache__ to the gitignore file.