pinkgoosik / nota

Port of the NoteBlock API for fabric, play .nbs files as noteblock sounds.

Modrinth Profile | CurseForge Profile | Discord Server | WakaTime

nota's Issues

Extend Octaves Doesnt extend octaves

Using the extend octaves doesnt cause octaves to be extended outside of the vanilla range, instead playing notes outside of the range causes them to autotranspose, which is demonstrated in these clips
This is what is supposed to happen (demonstrated using a datapack export from ONBS)
https://medal.tv/games/minecraft/clips/1e7s2tPdQC9kQg/d1337Xh1xKTl?invite=cr-MSxQUVEsNDg3NzE3Nzgs
This is what happens using nota
https://medal.tv/games/minecraft/clips/1e7tS17b2Q6iYK/d13372gMcAzq?invite=cr-MSxnNnIsNDg3NzE3Nzgs
These are using the same .nbs file, and both clips have with and without textures.
The implementation is in our server utility mod, with the main being here
https://github.com/Legacy-Edition-Minigames/Server-Utils/blob/1.19.4/src/main/java/net/kyrptonaught/serverutils/noteblockMusic/NoteblockMusicMod.java
Under normal circumstances it shouldnt play anything if playing out of range notes unless you have a texture pack made for it.
An oddity i found shown below, is that setting the bool that toggles it to false causes incredibly odd shifts in the way its transposed, using sets of 11 notes instead of 22.
https://medal.tv/games/minecraft/clips/1e8xtc9Layv3m5/d1337T2CYAzw?invite=cr-MSw1dUgsNDg3NzE3Nzgs

Enhancement: Add a fade option to entity/blockpos

Fade over distance for non global playback methoods, alike a normal jukebox or noteblock.
This would be awesome so you dont just enter range and have it go instantly full volume.