GithubHelp home page GithubHelp logo

pinkgoosik / visuality Goto Github PK

View Code? Open in Web Editor NEW
30.0 30.0 15.0 272 KB

Little visual improvements by adding a bunch of new particles.

Home Page: https://modrinth.com/mod/visuality

License: MIT License

Java 100.00%
fabric minecraft mod

visuality's Introduction

visuality's People

Contributors

cccc-owo avatar cerealconjugo avatar fitfc avatar myuui avatar nezila avatar pinkgoosik avatar raymondblaze avatar rhbarber avatar spiritothawk avatar stevekung avatar yichifauzi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

visuality's Issues

Mod simply doesn't work

So I tried loading MC in with just fabric api, visuality, and cloth config but the mod still didn't work (as in there were no particles whatsoever, although everything in the mod was enabled).

There are no water splashes or mob particles or any of the mod's effects; it doesn't seem to be a mod conflict and I don't know how else to fix this.

Shiny blocks cause a particle overflow.

1.19.2, Sodium
Entering spectator and going through the world, when shiny blocks are enabled, thousands of particles overflow from far away, around the edge of the render distance.

Better Combat incompatibility

Hello!

I am developer of the Better Combat mod.
We have the following incompatibility: ZsoltMolnarrr/BetterCombat#156 (comment)

When Better Combat is installed, the entity.damage(DamageSource ...) function is only executed on the server side. But the server side cannot spawn particles.

So the only way to resolve this is to send a packet to the client with the information about particles.
I understand this would require turning your mod not purely clientside.

If this would be implemented your mod could continue to function in clientside only and in server supported modes too.

[Suggestion] More customization

The option of creating new particles
choose particles for blocks more than just sparkling textures (like the shiny ores)
and also options to change the slime particle color, for resourcepacks that change the slime color

Slime Colors

Following MarkinhosMLP's suggestion, having colored slime particles would be nice. Such as following the colored slime that VanillaTweaks has to offer, or allowing for the hue to be changed as a config setting.

[Request] Jukebox Particles

How about adding Note Particles (or something comparable/similar) to the Jukebox when it's playing a music disc?

Could look something like the note block when played, but with regular intervals, in between the particles that show up.

Add fish schools (groups of fish) like the ones in subnautica?

I have been playing subnautica lately and I noticed how some non tangible fish schools that appear at some places could make minecraft seas look more alive.
I don't know if this is possible in minecraft, but it sounds like something that suits this mod

Forge version

Many of us would be happy if it were also on Forge (Like 1.20.1)

[enhancement] bubble pop

in 1.13, the "minecraft:bubble_pop" particle appeared at the top of soul sand jets and played the
"minecraft:block.bubble_column.bubble_pop" sound. but a bug caused the particle and sound not to appear.
it adds to the ambience of the jets.

Issue loading Visuality v0.4.3 in fabric modpack

Crashes MC Launcher + Fabric when loaded. When I open MC Launcher again it gives a "1" exit code. Mods using:

Better Animation Collection v4.0.2
continuity v2.0.1 (1.19)
effective v1.3
fabric API v0.61.0
Forge Config API Port v4.2.6
illuminations v1.10.8
indium v1.0.9
Just Enough Items v11.3.0.262
lithium v0.8.3
logical zoom v0.0.17
mod menu v4.0.6
moonlight v2.0.31
phosphor v0.8.1
physics mod v2.8.13
iris v1.3.1
PuzzelsLib v4.3.9
sodium v0.4.4
supplementaries v2.2.3
toms storage v1.4.3
worldedit v7.2.12
Xaeros Minimap v22.15.1
Xaeros Worldmap v1.28.0
fabric v0.14.9

Is this due to conflicting mods or an issue with fabric or visuality?

Incompatibility with 'Luna Slimes'

https://modrinth.com/mod/luna-slimes

This is an issue I should probably be opening on the other mod's issue tracker (as that mod is more recent), but to my knowledge it has no tracker nor privately-messageable contact info, so excuse me while I use this as a place to ping @AViewFromTheTop (aka Lunade_).

The issue

Running Visuality with LunaSlimes (and nothing else besides for dependencies) causes a load-time crash due to conflicting mixins.

If it matters, and I don't think it does - I'm using Quilt, and QSL in place of Fabric API.

Logs

Log file: latest.log

Relevant portion:

[00:17:10] [main/WARN]: @Redirect conflict. Skipping lunaslimes.mixins.json:SlimeMixin from mod lunaslimes->@Redirect::stopParticles(Lnet/minecraft/class_1937;Lnet/minecraft/class_2394;DDDDDD)V with priority 1000, already redirected by visuality.mixins.json:SlimeEntityMixin from mod visuality->@Redirect::addParticle(Lnet/minecraft/class_1937;Lnet/minecraft/class_2394;DDDDDD)V with priority 1000
[00:17:10] [main/WARN]: Mixin transformation of net.minecraft.class_1621 failed
org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]

Error when using this mod on a LAN server

When i try to use this mod on a LAN server with my brother who doesn't have the mod installed (he is using Vanilla Minecraft), he gets this error when he tries to join my world:

**Connection Lost

Unsupported (vanilla?) client!
This server requires modded client to join!**

I'm using Quilt Loader on version 1.20.1 of Minecraft.

Ticking entity crash

Crash log below:

---- Minecraft Crash Report ----
// I let you down. Sorry :(

Time: 2023-07-11 11:28:50
Description: Ticking entity

java.lang.IllegalAccessError: class net.minecraft.class_1309 tried to access private field net.minecraft.class_1297.field_6002 (net.minecraft.class_1309 and net.minecraft.class_1297 are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @57175e74)
at net.minecraft.class_1309.handler$bjp002$visuality$tick(class_1309.java:6655)
at net.minecraft.class_1309.method_5773(class_1309.java:2499)
at net.minecraft.class_1308.method_5773(class_1308.java:351)
at net.minecraft.class_3218.method_18762(class_3218.java:739)
at net.minecraft.class_1937.method_18472(class_1937.java:480)
at net.minecraft.class_3218.method_31420(class_3218.java:385)
at net.minecraft.class_5574.method_31791(class_5574.java:54)
at net.minecraft.class_3218.method_18765(class_3218.java:353)
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824)
at net.minecraft.class_1132.method_3748(class_1132.java:105)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:671)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
at java.base/java.lang.Thread.run(Thread.java:833)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Server thread
Stacktrace:
at net.minecraft.class_1309.handler$bjp002$visuality$tick(class_1309.java:6655)
at net.minecraft.class_1309.method_5773(class_1309.java:2499)
at net.minecraft.class_1308.method_5773(class_1308.java:351)
at net.minecraft.class_3218.method_18762(class_3218.java:739)
at net.minecraft.class_1937.method_18472(class_1937.java:480)
at net.minecraft.class_3218.method_31420(class_3218.java:385)
at net.minecraft.class_5574.method_31791(class_5574.java:54)
at net.minecraft.class_3218.method_18765(class_3218.java:353)

-- Entity being ticked --
Details:
Entity Type: minecraft:rabbit (net.minecraft.class_1463)
Entity ID: 1
Entity Name: Rabbit
Entity's Exact location: -10.81, 111.00, 29.09
Entity's Block location: World: (-11,111,29), Section: (at 5,15,13 in -1,6,1; chunk contains blocks -16,-64,16 to -1,319,31), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,-64,0 to -1,319,511)
Entity's Momentum: 0.00, -0.08, 0.00
Entity's Passengers: []
Entity's Vehicle: null
Stacktrace:
at net.minecraft.class_1937.method_18472(class_1937.java:480)
at net.minecraft.class_3218.method_31420(class_3218.java:385)
at net.minecraft.class_5574.method_31791(class_5574.java:54)
at net.minecraft.class_3218.method_18765(class_3218.java:353)
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824)
at net.minecraft.class_1132.method_3748(class_1132.java:105)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:671)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
at java.base/java.lang.Thread.run(Thread.java:833)

-- Affected level --
Details:
All players: 0 total; []
Chunk stats: 2209
Level dimension: minecraft:overworld
Level spawn location: World: (0,118,0), Section: (at 0,6,0 in 0,7,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
Level time: 11059 game time, 16661 day time
Level name: 1.20 New
Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: true
Level weather: Rain time: 40691 (now: false), thunder time: 145097 (now: false)
Known server brands: fabric
Removed feature flags:
Level was modded: true
Level storage version: 0x04ABD - Anvil
Stacktrace:
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824)
at net.minecraft.class_1132.method_3748(class_1132.java:105)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:671)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
at java.base/java.lang.Thread.run(Thread.java:833)

[Request] configs

Could you please add configs to toggle each added particle?
I like most of them but I find the falling rocks particles distracting.

Doesn't work on 1.19.0

When trying to run Visuality on 1.19.0, it doesn't recognize any of the Fabric API mods meant for 1.19.0. Because it's not recognized, you cannot run the game without running into an error.

Not working

I have installed the mod into my modpack, but when I opened it it did not work at all. no particles were showing up! Anyone know how to fix?

does not detect fabric api and crashes?

visuality 0.5.3 cant startup minecraft 1.19 (fabric 0.14.10)

Minecraft tells me I don´t have any version of fabric api installed, when I DO have it installed, preventing me to start the game

Log:

latest.log

fabric "Incompatible mod set" report:

Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
- Install fabric-api, any version.
Unmet dependency listing:
- Mod 'Visuality' (visuality) 0.5.3 requires any version of fabric-api, which is missing!
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:190)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

[suggestion] terrarian slimes compat

the slime effect doesnt apply to modded slimes, if you add this custom colors for the particles (related to the slimes color) would be really cool

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.