pitchblackrecoveryproject / android_bootable_recovery

The heart :heart: of PBRP

Pitch Black Recovery Project (PBRP)
Based on TWRP

You can find a compiling guide here.

android_bootable_recovery's Issues

Compiling error with 'weaver'

• I am running an official build of TWRP, downloaded from https://twrp.me/Devices/
• I am running the latest version of TWRP
• I have read the FAQ (https://twrp.me/FAQ/)
• I have searched for my issue and it does not already exist

Device codename: perry
TWRP version: 3.2.3

WHAT STEPS WILL REPRODUCE THE PROBLEM?

Sync source 'twrp-7.1' branch and device trees
source build/envsetup.sh
lunch omni_device-eng
mka -j$(nproc --all) recoveryimage

WHAT IS THE EXPECTED RESULT?

Complete build

WHAT HAPPENS INSTEAD?

Build fails with error "[email protected] missing and no known rule to make it"

Build log: https://del.dog/rirupifeci

ADDITIONAL INFORMATION

These 2 commits have been identified as the additions of the calls for 'weaver', however reverting them does not solve the issue

55b0884

33d2a72

Device tree: https://github.com/RebelLion420/android_device_motorola_perry

Common tree: https://github.com/RebelLion420/android_device_motorola_msm8937-common

Kernel source: https://github.com/RebelLion420/android_kernel_motorola_msm8937

Gui: Themes

Themes are now full of device specific bugs due to different resolutions, we need to fix ->

• Theme resolution fit for every hdpi device ASAP!

• And we need a New lockscreen, the old one looks awful

Bringup Incremental MIUI OTA updates Support in PBTWRP

[BUG] SELinux Issue (plat_hwservice_contexts) [A10]

Tell Us About Your Device First

Device Codename: a50dd
Official Build of PBRP from https://pitchblackrecovery.com/#downloads: No
PBRP Version: 3.0.0

Describe The Bug

At the end of the compilation, I get a SELinux error (specifically: plat_hwservice_contexts), and the problem is not in the device tree.

Steps Needed To Reproduce The Behavior

1. Go to Pitch Black Recovery Project 10 Source Folder, clone the Device Tree
2. Run: source build/envsetup.sh; lunch omni_a50dd-eng && mka recoveryimage
3. Wait the build
4. See error

Expected Behavior

A successful build

Screenshots

https://imgur.com/oVjgDBv

Additional Context

Tested with Team Win Recovery Project 10.0, compiled normally

---

You can join our community on Telegram

• Community Group
• Test Build & Build Help Group

ld.lld: error

ld.lld: error: duplicate symbol: getdtablesize

defined at general.c:1179 (external/bash/general.c:1179)
/home/name/Android/source/android/pbrp-10.0/out/target/product/angelican/obj/EXECUTABLES/bash_intermediates/general.o:(getdtablesize)
defined at oslib.c:147 (external/bash/lib/sh/oslib.c:147)
oslib.o:(.text.getdtablesize+0x0) in archive /home/name/Android/source/android/pbrp-10.0/out/target/product/angelican/obj/STATIC_LIBRARIES/libsh_intermediates/libsh.a
clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
error.log

09:54:19 ninja failed with: exit status 1

[Feature Request] add parameters for other partitions in openrecoveryscript

Is your feature request related to a problem? If yes, please describe.

Backing up device via tasker and openrecoveryscript file in /cache
using backup SDBOM commandline

Describe the solution/feature you'd like

Adding more partitions to get a fully possible backup via commandline on my z3s

metadata
Cache
efs
sec_efs
modem
dtbo
CP Debug
Optics Image
Param
Prism Image
Super

compiling openrecoveryscript.java with more bacup parameters

Describe alternatives you've considered

none found

Add flag to Keep Encryption

@AndroiableDroid Please add flags to Disable Patching for force encryption.

Some devices have issues with decryption, and user don't wanna to decrypt your device.

When user is formatting device and flashing rom it disable force encryption if we don't select to Disable force encryption or not.

So either add flags to hide that option or disabled bu default and not patching after formatting too

Fix support for MTK devices

Currently most of the MTK devices are facing problems due to these issues :

• Current size of the recovery exceeds 16mb partition which most of the MTK devices have, PBRP_GO was made for this but still it is not as perfect as possible. (#18)
• Most of the MTK devices support older android versions (5.x-7.x), its been a while since other branches are regularly updated (They may face build errors also).
• Flashlight in many MTK devices have different path than Usual Qualcomm Devices, and often use single file path for controlling torch on/off. So, the flashlight trigger may not work in many devices.
• More coming soon...

Disable auto DM-VERITY and Forced Encryption patcher

• [ No] I am running an official build of TWRP, downloaded from https://twrp.me/Devices/
• [ Yes] I am running the latest version of TWRP
• [ Yes] I have read the FAQ (https://twrp.me/FAQ/)
• [ Yes] I have searched for my issue and it does not already exist

Device codename: PL2
TWRP version: 3.3.1

WHAT STEPS WILL REPRODUCE THE PROBLEM?

Flash a ROM. PBRP will automatically try to disable dm-verity and patch forced encryption

WHAT IS THE EXPECTED RESULT?

Nothing such should happen or users/maintainers shall be given a choice whether they want this to happen or not.

WHAT HAPPENS INSTEAD?

The PROBLEM stated above happens

Problem While Flashing Global ROMS

Am testing this recovery on My Redmi Note 5 pro.
And facing one problem with this recovery. If I flashed the MIUI China ROM which doesn't have the Google Apps. The ROM boots successfully.

But, when I flash the MIUI Global version which comes with the Google Apps. The ROM stuck on the Black Screen before the Google Sign in Configuration page.

And followed the same method on Official Recovery. The ROM boots fine and Google Setup page appears and work perfectly.

Recovery: Over-sized image

• I am running an Unofficial build of TWRP, built from source by me from This Device Tree

Device codename: Primo_RX5
TWRP version: 3.2.3-PB-v2.9.0

WHAT IS THE PROBLEM?

When building the Recovery from Latest Source, the resulting Image size is around 19MB
But many device has maximum recovery partition size of 16MB (0x1000000) only

The excess size of image can be reduced by Moving the extra Themes into /sdcard/PBRP/themes/ui.zip and Load them from there

[Feature Request]

PBRP has the ability to modify codename, can you add a tool to modify more read-only attributes?
Many official upgrade packages now recognize more than Just Codename.
This feature can be adapted to more similar models using a PBRP image.

Feature Request: GUI: move PB themes to /sdcard

• I am running an Unofficial build of TWRP
• I am running the latest version of TWRP

TWRP version: 3.2.3-PB-v2.9.0

Feature Request: GUI: move PB themes to /sdcard

Reasons for Asking:

• In some devices, PBRP Recovery Image size is exceeding their partition size (~16MB).
• But using "PB_GO := true" helps to eliminate some of the themes and save space.
• But for the users' vast personalization choice, PB themes can be moved to /sdcard, as in previous versions (i.e., v2.7.x)
• In this way, PB_GO will not be needed that much for those devices of which I stated above.
• And users can use any of the theme collections.

Compiling Error :

ERROR: ninja: error: 'magiskboot', needed by '/home/ubuntu/r/out/target/product/jalebi/obj/EXECUTABLES/recovery_intermediates/twrp.o', missing and no known rule to make it
15:10:09 ninja failed with: exit status 1

Solution :
revert this commit 👍

663d938

Feature Request

Feature Request to Add some feature like. Option to flash Magisk or any other selected zip after every OTA flash.