pitzzahh / automated-teller-machine-api

API used for making atm applications (none-web-app)

• 💻 Currently working on our capstone project
• 🔍 Need something?

Connect with me:

Languages and Tools:

---

automated-teller-machine-api's Issues

Should throw informational exception when client is not found when getClientByAccountNumber() is invoked

When the client is not found, it throws

Exception in thread "main" org.springframework.dao.EmptyResultDataAccessException: Incorrect result size: expected 1, actual 0
	at org.springframework.dao.support.DataAccessUtils.nullableSingleResult(DataAccessUtils.java:97)
	at org.springframework.jdbc.core.JdbcTemplate.queryForObject(JdbcTemplate.java:887)
	at io.github.pitzzahh.atm.dao.AtmDAOImplementation.lambda$getClientByAccountNumber$3(AtmDAOImplementation.java:81)
	at App.main(App.java:47)

which is valid but not much info about it.

If account number is not an existing client. No error thrown in getting the message

bug is in the getMessage() method of AtmDAOImplementation class

    /**
     * Function that gets the message of the loan requst of a client to the database.
     * The Function takes a {@code String}.
     * The {@code String} contains the account number of the client.
     * @return a {@code Message} object containg the message of the loan.
     * @see Function
     * @see Map
     * @see List
     * @see Message
     */
    @Override
    public Function<String, Map<String, List<Message>>> getMessage() {
        return accountNumber -> {
            var clients = getAllClients().get()
                    .entrySet()
                    .stream()
                    .map(Map.Entry::getValue)
                    .toList();
            var check = getAllLoans()
                    .get()
                    .entrySet()
                    .stream()
                    .map(Map.Entry::getValue)
                    .flatMap(Collection::stream)
                    .allMatch(a -> a.accountNumber().equals(accountNumber) && ( a.pending() && !a.isDeclined() ));
            if (check) throw new IllegalStateException("THERE ARE NO MESSAGES AT THE MOMENT");
            return getAllLoans().get()
                    .entrySet()
                    .stream()
                    .map(Map.Entry::getValue)
                    .flatMap(Collection::stream)
                    .filter(l -> !l.pending() || l.isDeclined())
                    .map(loan -> {
                        return new Message(
                                loan,
                                clients.stream()
                                        .filter(a -> a.accountNumber().equals(loan.accountNumber()))
                                        .findFirst()
                                        .get(),
                                loan.pending() && loan.isDeclined()
                        );
                    })
                    .collect(Collectors.groupingBy(message -> message.loan().accountNumber()));
        };
    }

Client can still perform functions even when account is locked

During when a client is doing something and suddenly locked the account, the client can still do something.

ADD OPTIONAL WAY TO SAVE DATA

Add an option to save data to a collection data source

Outdated comment

The comments forgetClientByAccountNumber() found in AtmDAO, AtmDAOImplementation, and AtmService does not contain the latest info about the method changes

Client has no withdraw and loan function

Bump to new version 1.0.4

Exclude some dependencies in jar

some dependencies are in the jar file like dependencies for unit testing which should not be included

Does not throw error when database information are incorrect

If username or password or any info in setting the database is not correct. It does not throw an error

loan is approved but loan amount is not added to the clients savings

the very last loan is not added to the client when approved.