GithubHelp home page GithubHelp logo

Comments (27)

goosetav avatar goosetav commented on August 15, 2024

+1 I am getting the same issue. see PR ... I'm running npm v1.3.21

the result of https://github.com/pivotal/LicenseFinder/blob/master/lib/license_finder/npm.rb#L17
is {"async"=>"~0.2", "jasmine-node"=>"~1.13"} for devDependencies which causes the exception

from licensefinder.

BrentWheeldon avatar BrentWheeldon commented on August 15, 2024

This seems to have been caused by #59, @grosser do you have any thoughts on this? Sorry, I'm not a node expert.

from licensefinder.

BrentWheeldon avatar BrentWheeldon commented on August 15, 2024

#67 fixes this, without totally removing devDependencies. I will pull that one in once it's gone through CI.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

Awesome, thanks everyone for the support and fix! Totally awesome. 😄

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

Got this error when testing out the new gem from master branch in the git repo:

 ---------- / ----------npm ERR! extraneous: [email protected] /Users/alphonse/workspace/cramerdev/supermarket/node_modules/karma/node_modules/chokidar/node_modules/recursive-readdir
npm ERR! not ok code 0

/Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/npm.rb:14:in `current_modules': Command npm list --json --long failed to execute: { (RuntimeError)
  "name": "supermarket",
  "devDependencies": {
    "chai": "~1.8.1",
    "karma": "~0.10.2",
    "karma-mocha": "~0.1.0",
    "karma-osx-reporter": "0.0.3",
    "karma-spec-reporter": "0.0.6",
    "mocha": "~1.13.0",
    "sprockets-chain": "0.0.9"
  },

I omitted this middle part, as it was just JSON from all of the dependencies.

    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:18:in `block in sync_with_bundler'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:56:in `modifying'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:6:in `sync_with_bundler'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:157:in `block (2 levels) in rescan'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:222:in `spinner'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:156:in `block in rescan'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:15:in `die_on_error'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:155:in `rescan'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/base.rb:439:in `start'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/bin/license_finder:5:in `<top (required)>'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in `load'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in `<main>'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `eval'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `<main>'

Is this part of the same issue?

from licensefinder.

goosetav avatar goosetav commented on August 15, 2024

I hit something like this yesterday as well -- I suspect its a different problem having to do with the exit code from npm.

Try running: npm list --json --long and see what the output is. For me, I was getting some warnings msgs at the end and extra output. running npm --prune before running license_finder again fixed it for me.

from licensefinder.

grosser avatar grosser commented on August 15, 2024

is the exit code also non-0 when you run it by hand and then 0 after
pruning ?
can we run npm list --json --long --prune to avoid this issue? or just
failed ? -> prune -> retry ?

On Thu, Jan 23, 2014 at 7:24 AM, Erik Gustavson [email protected]:

I hit something like this yesterday as well -- I suspect its a different
problem having to do with the exit code from npm.

Try running: npm list --json --long and see what the output is. For me, I
was getting some warnings msgs at the end and extra output. running npm
--prune before running license_finder again fixed it for me.


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33132927
.

from licensefinder.

goosetav avatar goosetav commented on August 15, 2024

Actually, I made a mistake --prune is not an option for npm list, its a top level command

is the exit code also non-0 when you run it by hand and then 0 after
pruning ?

I believe so, but I did not capture the output.

IIRC, this is the sequence I followed:
license_finder => throws exception as above
npm prune => this removes extra stuff
license_finder => works now

npm help prune says that it removes "extraneous" packages (i.e. ones not listed in package.json).

To repeat the issue, one could add a lib to package.json, run npm install, remove the lib and then run license_finder

Perhaps there is a way to differentiate between catastrophic failures and npm just being whiny?

from licensefinder.

grosser avatar grosser commented on August 15, 2024

Filtering out just being whiny would be nice, maybe the output contains
some indicator ? -> if fails + indicator -> parse anyway ?

On Thu, Jan 23, 2014 at 10:33 AM, Erik Gustavson
[email protected]:

Actually, I made a mistake --prune is not an option for npm list, its a
top level command

is the exit code also non-0 when you run it by hand and then 0 after
pruning ?

I believe so, but I did not capture the output.

IIRC, this is the sequence I followed:
license_finder => throws exception as above
npm prune => this removes extra stuff
license_finder => works now

npm help prune says that it removes "extraneous" packages (i.e. ones not
listed in package.json).

To repeat the issue, one could add a lib to package.json, run npm install,
remove the lib and then run license_finder

Perhaps there is a way to differentiate between catastrophic failures and
npm just being whiny?

Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33153588
.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

I ran npm prune and then license_finder again to follow @goosetav 's steps, and here is the error I get:

/Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:24:in `join': no implicit conversion of nil into String (TypeError)
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:24:in `find_matching_files'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:18:in `paths_for_license_files'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:12:in `find'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:48:in `license_files'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:60:in `determine_license'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:40:in `license'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:96:in `apply_better_license'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:32:in `block in save'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:118:in `_transaction'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:93:in `block in transaction'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/connecting.rb:229:in `block in synchronize'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/connection_pool/threaded.rb:104:in `hold'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/connecting.rb:229:in `synchronize'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:86:in `transaction'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:28:in `save'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:18:in `block in save_packages'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:17:in `map'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:17:in `save_packages'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:18:in `block in sync_with_bundler'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:56:in `modifying'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:6:in `sync_with_bundler'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:157:in `block (2 levels) in rescan'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:222:in `spinner'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:156:in `block in rescan'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:15:in `die_on_error'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:155:in `rescan'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/base.rb:439:in `start'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/bin/license_finder:5:in `<top (required)>'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in `load'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in `<main>'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `eval'
    from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `<main>'

Looks like a different error than before. 😄

from licensefinder.

grosser avatar grosser commented on August 15, 2024

Looks like it get's further but then cannot find the install_path -> cannot
find the licenses,
do you have dependencies listed that are not installed ?
Maybe best to revert to the old only use dependencies or exclude things
that use the short name:version format ?

On Thu, Jan 23, 2014 at 11:31 AM, Brett Chalupa [email protected]:

I ran npm prune and then license_finder again to follow @goosetavhttps://github.com/goosetav's steps, and here is the error I get:

/Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:24:in join': no implicit conversion of nil into String (TypeError) from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:24:infind_matching_files'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:18:in paths_for_license_files' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:12:infind'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:48:in license_files' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:60:indetermine_license'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:40:in license' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:96:inapply_better_license'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:32:in block in save' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:118:in_transaction'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:93:in block in transaction' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/connecting.rb:229:inblock in synchronize'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/connection_pool/threaded.rb:104:in hold' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/connecting.rb:229:insynchronize'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:86:in transaction' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:28:insave'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:18:in block in save_packages' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:17:inmap'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:17:in save_packages' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:18:inblock in sync_with_bundler'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:56:in modifying' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:6:insync_with_bundler'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:157:in block (2 levels) in rescan' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:222:inspinner'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:156:in block in rescan' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:15:indie_on_error'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:155:in rescan' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/command.rb:27:inrun'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/invocation.rb:120:in invoke_command' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor.rb:363:indispatch'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/base.rb:439:in start' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/bin/license_finder:5:in<top (required)>'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in load' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in

'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in eval' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in'

Looks like a different error than before. [image: 😄]


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33159377
.

from licensefinder.

goosetav avatar goosetav commented on August 15, 2024

maybe try this?
npm prune
npm install

license_finder

On Jan 23, 2014, at 11:41 AM, Michael Grosser [email protected] wrote:

Looks like it get's further but then cannot find the install_path -> cannot
find the licenses,
do you have dependencies listed that are not installed ?
Maybe best to revert to the old only use dependencies or exclude things
that use the short name:version format ?

On Thu, Jan 23, 2014 at 11:31 AM, Brett Chalupa [email protected]wrote:

I ran npm prune and then license_finder again to follow @goosetavhttps://github.com/goosetav's steps, and here is the error I get:

/Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:24:in join': no implicit conversion of nil into String (TypeError) from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:24:in find_matching_files'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:18:in paths_for_license_files' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/possible_license_files.rb:12:in find'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:48:in license_files' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:60:in determine_license'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package.rb:40:in license' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:96:in apply_better_license'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:32:in block in save' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:118:in _transaction'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:93:in block in transaction' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/connecting.rb:229:in block in synchronize'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/connection_pool/threaded.rb:104:in hold' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/connecting.rb:229:in synchronize'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/sequel-4.6.0/lib/sequel/database/transactions.rb:86:in transaction' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:28:in save'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:18:in block in save_packages' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:17:in map'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/package_saver.rb:17:in save_packages' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:18:in block in sync_with_bundler'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:56:in modifying' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/dependency_manager.rb:6:in sync_with_bundler'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:157:in block (2 levels) in rescan' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:222:in spinner'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:156:in block in rescan' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:15:in die_on_error'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/lib/license_finder/cli.rb:155:in rescan' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/command.rb:27:in run'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/invocation.rb:120:in invoke_command' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor.rb:363:in dispatch'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/gems/thor-0.18.1/lib/thor/base.rb:439:in start' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bundler/gems/LicenseFinder-de86f15bf104/bin/license_finder:5:in <top (required)>'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in load' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/license_finder:23:in

'
from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in eval' from /Users/alphonse/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in '

Looks like a different error than before. [image: 😄]


Reply to this email directly or view it on GitHub#65 (comment)
.


Reply to this email directly or view it on GitHub.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

I changed my package.json:

{
  "name": "supermarket",
  "dependencies": {
    "chai": "1.8.1",
    "karma": "0.10.2",
    "karma-mocha": "0.1.0",
    "karma-osx-reporter": "0.0.3",
    "karma-spec-reporter": "0.0.6",
    "mocha": "1.13.0",
    "sprockets-chain": "0.0.9"
  }
}

And it is working fine! Does it have to do with the devDependencies group?

from licensefinder.

grosser avatar grosser commented on August 15, 2024

It should not make any difference if it is devDependencies or dependencies,
but maybe npm thinks there is a difference...
so it fails when you change dependencies to devDependencies ?

On Thu, Jan 23, 2014 at 12:16 PM, Brett Chalupa [email protected]:

I changed my package.json:

{
"name": "supermarket",
"dependencies": {
"chai": "1.8.1",
"karma": "0.10.2",
"karma-mocha": "0.1.0",
"karma-osx-reporter": "0.0.3",
"karma-spec-reporter": "0.0.6",
"mocha": "1.13.0",
"sprockets-chain": "0.0.9"
}
}

And it is working fine! Does it have to do with the devDependencies group?


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33163783
.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

Changing it back to devDependencies causes it to fail, correct. It reports the latest error I posted.

edit: Give more information.

from licensefinder.

grosser avatar grosser commented on August 15, 2024

so npm has some issue with devDependencies in this abbreviated format :(

On Thu, Jan 23, 2014 at 1:22 PM, Brett Chalupa [email protected]:

Changing it back to devDependencies causes it to fail, correct.


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33169974
.

from licensefinder.

grosser avatar grosser commented on August 15, 2024

whats the output of npm list --json --long <-> anything we could catch or just broken ?

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

It is a super super long JSON response. Is that what it should be?

from licensefinder.

grosser avatar grosser commented on August 15, 2024

yep, and echo $? after it should be 0

On Thu, Jan 23, 2014 at 2:49 PM, Brett Chalupa [email protected]:

It is a super super long JSON response. Is that what it should be?

Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33178354
.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

Yup, it was 0.

from licensefinder.

grosser avatar grosser commented on August 15, 2024

so then it should not fail !? <-> is it still failing / is it running the
same command ?

On Thu, Jan 23, 2014 at 3:05 PM, Brett Chalupa [email protected]:

Yup, it was 0.


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33179654
.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

Hmm, still failing with license_finder when using devDependencies in the package.json.

If it helps debug it, the project that I am working with is open source: https://github.com/opscode/supermarket

I will have some time to dig into it tomorrow. 😄

from licensefinder.

grosser avatar grosser commented on August 15, 2024

#68

On Thu, Jan 23, 2014 at 3:24 PM, Brett Chalupa [email protected]:

Hmm, still failing with license_finder when using devDependencies in the
package.json.

If it helps debug it, the project that I am working with is open source:
https://github.com/opscode/supermarket

I will have some time to dig into it tomorrow. [image: 😄]


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33181043
.

from licensefinder.

grosser avatar grosser commented on August 15, 2024

this is not a super-nice patch, but it's better than before, so 1 small
step forward :)

btw you should fix your npm packages, not sure exactly what is wrong there
when you put them into dependencies...

On Thu, Jan 23, 2014 at 7:37 PM, Michael Grosser
[email protected]:

#68

On Thu, Jan 23, 2014 at 3:24 PM, Brett Chalupa [email protected]:

Hmm, still failing with license_finder when using devDependencies in the
package.json.

If it helps debug it, the project that I am working with is open source:
https://github.com/opscode/supermarket

I will have some time to dig into it tomorrow. [image: 😄]


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33181043
.

from licensefinder.

BrentWheeldon avatar BrentWheeldon commented on August 15, 2024

I've pulled in the patch, thanks @grosser! @brettchalupa please let us know if there's still an issue.

from licensefinder.

brettchalupa avatar brettchalupa commented on August 15, 2024

Just updated the gem from the repo and all is working well. Thank you so much for the support and fix. 😄

Changing dependencies back to devDependencies is working as well, awesome.

from licensefinder.

grosser avatar grosser commented on August 15, 2024

Just keep in mind that not-failing != working ;)
The failing devDependencies are just not being audited

On Sun, Jan 26, 2014 at 11:19 AM, Brett Chalupa [email protected]:

Just updated the gem from the repo and all is working well. Thank you so
much for the support and fix. [image: 😄]

Changing dependencies back to devDependencies is working as well, awesome.


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-33327040
.

from licensefinder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.