pixelpeter / laravel5-isocodes-validation Goto Github PK

Hi there, I was wondering if you're planning to support ZIP+4 in the package?

Currently, I have to omit the zipcode:country rule, as a ZIP+4 results in an error like "The value "12345-1234" of zipcode is not valid for "USA"."

Just here as a reference:
https://en.wikipedia.org/wiki/ZIP_Code#ZIP+4

Thanks!

Validation rule example:
'shipments.*.from.zip' => 'zipcode:shipments.*.from.country_id'

Sources:

• laravel/framework#16183
• https://github.com/laravel/framework/blob/5a11fb13d7023e05911559c99902e68f3cb95ed9/src/Illuminate/Validation/Validator.php#L489

Can You add getExplicitKeys() and replaceAsterisksInParameters() like this?

      public function validateZipcode($attribute, $value, $parameters)
   {
       $this->requireParameterCount(1, $parameters, 'zipcode');

       // replace asterisk/wildcard '*' with $attribute index, example: 'shipments.*.from.country_id' -> shipments.0.from.country_id' ($this->currentRule)
       if ($keys = $this->getExplicitKeys($attribute)) {
           $parameters = $this->replaceAsterisksInParameters($parameters, $keys);
       }
       
       $country = Arr::get($this->data, $parameters[0], $parameters[0]);

       return $this->runIsoCodesValidator(\IsoCodes\ZipCode::class, $value, $country);
   }

snake_case has been removed in laravel 5.9
I can confirm that this lib does not work with laravel 6.0
https://github.com/laravel/framework/pull/26898/files#diff-887b2fccb767c2cdab0e4d6964d55b13R830

Just installed v2.0.0, but Auto-Discovery is not working. I think you need something like this in your composer.json:

"extra": {
    "laravel": {
        "providers": [
            "Pixelpeter\\IsoCodesValidation\\IsoCodesValidationServiceProvider"
        ]
    }
}

@pixelpeter FYI we published an updated version of the package, which should work with versions of Laravel >=5, though restricted to PHP 7.4+
We'd be happy to submit a PR to update the package, if you're interested/willing to merge those few changes