One request about truetrace-unity-pathtracer

[Li-ZhuoHang]

There is author discord ID in readme. However I would suggest you to first learning basic of unity and c# programming, them shaders and compute shaders, then light transport stuffs (maybe code your first raw path tracer). Otherwise you will not make much sense out off all this, and will keep asking infinite questions. PathTracing with compute shaders is not for Novices (as you called your self), not by far.

OK, I have the basic knowledge of graphics. I mean I'm a novice in PathTracing (I only know theoretical knowledge), so I want to learn the code of pathtracing.

If you are new to path tracing/raytracing I would advice to complete these:

https://raytracing.github.io/ https://www.scratchapixel.com/lessons/3d-basic-rendering/global-illumination-path-tracing/global-illumination-path-tracing-practical-implementation

If you don't know c++, you can try to do same in Unity (will take some brain to figure out).

Then create your first compute shader: https://github.com/cinight/MinimalCompute/tree/master/Assets/ComputeUAVTexture -> this is minimal example. You must know how thread, group ids work -> https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sv-dispatchthreadid .

Then you will be able to make sense out of all this. Thats my biased opinion. Good luck on your path.

Thank you very much.

[trsh]

@805557409 what kind of pipeline should we use actually? URP, HDRP or Core?

[Li-ZhuoHang]

Is urp OK? As long as it can show good results. It's better to have some sample scenarios, because I'm a novice. thank you very much.

[trsh]

@805557409 I am also trying to play with this lib, but nothing works. I am on 2022.1.16 (HDRP). The settings from PathTracer aren't saving. I check a box, I reopen and its not checked. When I press Play, it feels I just get regular Unity rendering.

[trsh]

Core seems to work better

[Li-ZhuoHang]

Really? Do you want to create a new Cinematic Studio project? How did you do it?

[trsh]

@805557409 just create Core 3d project (no urp or hdrp), fallow the guidlines in readme, then import package and open its contained demo scene.

[Li-ZhuoHang]

OK, let me try. Can it really achieve the effect shown in the picture?

[trsh]

@805557409 Yes, but its result of accumulation. Like you wait for 3-4 sec (stationary). When you move its all noisy and current denoisers don't do a good job,

[Li-ZhuoHang]

I created the Core 3d project and fall the guidelines in readme as you said, but whenever I click play, Uniry crashes.

[trsh]

@805557409 what version of Unity do you have? P.S. those where only needed steps:

Set the Color Space to Linear through Edit Tab(Top Left) -> Project Settings -> Player -> Other Settings -> Color Space, and change from Gamma to Linear
Change the Graphics Api for Windows to DirectX12 through Edit Tab(Top Left) -> Project Settings -> Player -> Other Settings -> Untoggle "Auto Graphics API For Windows", then click the little + that appears, select "Direct3D12(Experimental)", and drag that to the top. A restart of the editor is required
Enable Unsafe Code(Its for memory management) through Edit -> Project Settings -> Player -> Other Settings -> "Allow 'unsafe' Code" (near the bottom)

Other things as by context are optional.

[Li-ZhuoHang]

It shows the error.
There are more uavs (10) than the maximum supported (8) in ComputeShader 'RayTracingShader' kernel 'kernel_ shade'.

[Li-ZhuoHang]

Could you share the complete project file? I am a novice.please

[trsh]

@805557409 author said that this error and lots of warnings, that end with dx11 are expected due some limitations of Unity, Either way, if you press Play it should run. If you focus screen (click on it) and press t, you can navigate in this play mode.

If you get this: IndexOutOfRangeException: Index was outside the bounds of the array.. Then rebuild BVH from PathTracer menu. There is a button top, left in this menu.

I am currently not by mine computer.

[Li-ZhuoHang]

Don't be in a hurry. You can upload when you are free. Thank you for your help.

[trsh]

@805557409 still doesn't work?

[Li-ZhuoHang]

Yes, it seems so far.

[crizzler]

Yes, it seems so far.

I contacted the dev and the unity crash is caused by the atmosphere generator script. Go to line 355 in the script and change the int NumScatteringOrder = 12 to something like 1. I can't go any higher than 4 with objects in the scene.

[Li-ZhuoHang]

In my AtmosphereGenerator script, NumStrateringOrder is 4. When I change it to 1, the error "There are more uavs (10) than the maximum supported (8) in ComputeShader 'RayTracingShader' kernel 'kernel_ shade'" still appears

[trsh]

Yes, it seems so far.

I contacted the dev and the unity crash is caused by the atmosphere generator script. Go to line 355 in the script and change the int NumScatteringOrder = 12 to something like 1. I can't go any higher than 4 with objects in the scene.

Interesting. I took a fresh clone this morning and I already had NumScatteringOrder = 4. Tried to change it to 1. But still having this error at runtime:

There are more uavs (10) than the maximum supported (8) in ComputeShader 'RayTracingShader' kernel 'kernel_shade'.

however, it doesn't seem to be a blocker, as the scene is rendering. But it could indicate, that some part is not working. I think Unity introduced some new limits in newer versions, that weren't there in older versions.

Dev told me that he will investigate soon :)

[Li-ZhuoHang]

How did you solve it? Is your project not working properly? I also used the scenario given by the project. I didn't change it.

[trsh]

In my AtmosphereGenerator script, NumStrateringOrder is 4. When I change it to 1, the error "There are more uavs (10) than the maximum supported (8) in ComputeShader 'RayTracingShader' kernel 'kernel_ shade'" still appears

The error is there. But the scene works :P . Doesn't it? You have to press Play.

[trsh]

Welp, the thing in the middle looks suspicious :D

[Pjbomb2]

ok so
what do you mean by completely unity project file? the reason why I dont think I have yet is cuz I still upload to github from the web, so I cant upload large files
the uav error is because unity doesnt let you dissable dx11 even if you dont use it
The numscatteringorder turs out is way more intensive than I thought, I need to add something to either spread it out over multiple frames or make it accessable from the settings...

[Li-ZhuoHang]

So can it really achieve the effect in the picture? I added a new scene according to the tutorial, but the screen seems very ordinary. I didn't add a new shader.

[trsh]

So can it really achieve the effect in the picture? I added a new scene according to the tutorial, but the screen seems very ordinary. I didn't add a new shader.

You asked this question before and I did answer -> #4 (comment)

I can not comment further, as I played only with provided scene.

[Li-ZhuoHang]

Yes, it seems so far.

I contacted the dev and the unity crash is caused by the atmosphere generator script. Go to line 355 in the script and change the int NumScatteringOrder = 12 to something like 1. I can't go any higher than 4 with objects in the scene.

@crizzler How do I contact the author?

[Li-ZhuoHang]

So can it really achieve the effect in the picture? I added a new scene according to the tutorial, but the screen seems very ordinary. I didn't add a new shader.

You asked this question before and I did answer -> #4 (comment)

I can not comment further, as I played only with provided scene.

Well, thank you all the same

[trsh]

There is author discord ID in readme. However I would suggest you to first learning basic of unity and c# programming, them shaders and compute shaders, then light transport stuffs (maybe code your first raw path tracer). Otherwise you will not make much sense out off all this, and will keep asking infinite questions. PathTracing with compute shaders is not for Novices (as you called your self), not by far.

[Li-ZhuoHang]

There is author discord ID in readme. However I would suggest you to first learning basic of unity and c# programming, them shaders and compute shaders, then light transport stuffs (maybe code your first raw path tracer). Otherwise you will not make much sense out off all this, and will keep asking infinite questions. PathTracing with compute shaders is not for Novices (as you called your self), not by far.

OK, I have the basic knowledge of graphics. I mean I'm a novice in PathTracing (I only know theoretical knowledge), so I want to learn the code of pathtracing.

[trsh]

There is author discord ID in readme. However I would suggest you to first learning basic of unity and c# programming, them shaders and compute shaders, then light transport stuffs (maybe code your first raw path tracer). Otherwise you will not make much sense out off all this, and will keep asking infinite questions. PathTracing with compute shaders is not for Novices (as you called your self), not by far.

OK, I have the basic knowledge of graphics. I mean I'm a novice in PathTracing (I only know theoretical knowledge), so I want to learn the code of pathtracing.

If you are new to path tracing/raytracing I would advice to complete these:

https://raytracing.github.io/
https://www.scratchapixel.com/lessons/3d-basic-rendering/global-illumination-path-tracing/global-illumination-path-tracing-practical-implementation

If you don't know c++, you can try to do same in Unity (will take some brain to figure out).

Then create your first compute shader: https://github.com/cinight/MinimalCompute/tree/master/Assets/ComputeUAVTexture -> this is minimal example. You must know how thread, group ids work -> https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sv-dispatchthreadid .

Then you will be able to make sense out of all this. Thats my biased opinion. Good luck on your path.

[Pjbomb2]

I think this is taken care of? If I am wrong, feel free to re-open it and let me know!