Comments (3)
Hi @prachipancholi, so the current state is that every time the action is run a list of comments will be generated and posted regardless of whether the very same comment has been posted before in the very same line. This can lead to a lot of spam.
The solve this problem, the idea is that after we have created the list of comments that need to be posted (ie non duplicate comments that are related to lines included in the pull request delta) we also need to check if there is another comment with the same content on the same line!
So I think that before posting the comments, we should fetch the existing pull request review comments and if a comment already exists on the same line then we don't post it (e.g. Remove it from the list with the comments to be posted).
Let me know if that helped you understand the problem more.
from clang-tidy-pr-comments.
Hey , I would like to contribute, can you elaborate a bit?
from clang-tidy-pr-comments.
I will try to complete it in 2-3 days. Hope it will work.
from clang-tidy-pr-comments.
Related Issues (20)
- Support Checks API HOT 2
- How to contribute to this project? HOT 16
- Ambiguous expression in example workflow config HOT 1
- Failed to match codes between repo and `fixes.yml`. HOT 3
- Posting review comments failed with error code: 403 HOT 4
- A more strict regex extracting diff info is required HOT 3
- Configuration examples not workng HOT 3
- Bug: warnings not correctly recognized HOT 3
- Wrong suggestions HOT 5
- multiline code-suggestions HOT 10
- 1.3.0 Seems to break warning without suggested replacement HOT 3
- Error appending replacements in multi-line comments HOT 13
- Example projects using clang-tidy-pr-comments HOT 3
- Approve PR when issues have been fixed HOT 11
- The logic of searching for consecutive replacements is broken HOT 4
- Failed Assertion `run_action.py:244` HOT 1
- non-docker option HOT 1
- Should "fixed" review requests get dismissed HOT 4
- Clang tidy action failing to post comments. HOT 5
- Add support form many fixes files HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clang-tidy-pr-comments.