The logic of searching for consecutive replacements is broken about clang-tidy-pr-comments

[platisd]

😫

Is there any entry for DiagnosticMesage where FilePath is kingdom.h too or is this all?

[oleg-derevenetz]

@platisd this is the entire fixes.yml as is :)

[platisd]

So, from what I understand, to reproduce this I need to return a const object and have the declaration and definition in separate files?

I.e.:

// Foo.h
struct Foo {
    const int bar();
};

// Foo.cpp
#include "Foo.h"

const int Foo::bar() {
    return 42;
}

[oleg-derevenetz]

@platisd and also we need to have an offset of the second entry to be no more than offset+length of the first entry, because that's how intersection is currently checked:

     if current_offset + current_length < next_offset - 1: 
         replacements_are_consecutive = False 
         break 

BTW this logic can recognize even fragments of the same file as "consecutive" even if they are in fact not, but they are just specified in "reverse order" for some reason.