playframework / play-java-websocket-example Goto Github PK

Because there is no backpressure involved in this implementation, it's possible to lose Websocket packets coming in when using Actors directly.

playframework/playframework#6246

Should refactor code to be in line with http://doc.akka.io/docs/akka/current/java/stream/stream-integrations.html to prevent this or at least make it clear in the documentation.

This example does not use ActorFlow:

https://github.com/playframework/play-java-websocket-example/blob/2.6.x/app/controllers/HomeController.java

It should be updated to reflect

https://www.playframework.com/documentation/2.6.x/JavaWebSockets

Hi,

When sending an invalid JSON, the flow is terminated, but the connection stays open. I do see the UserActor terminating, but the connection stays open.

Igmar

Sorry for my ignorance, but could someone explain how the syntax on line 38 of StocksActor.java works?

.<Iterable<ActorRef>>map(Collections::singletonList)

How can there be a Generic Type <Iterable<ActorRef>> after the dot operator and before the map call?

[info] Compiling 3 Scala sources and 10 Java sources to /Users/arul/github/reactive-stocks-java8/target/scala-2.11/classes...
[info] 'compiler-interface' not yet compiled for Scala 2.11.2. Compiling...
[info] LESS compiling on 1 source(s)
[info] CoffeeScript compiling on 1 source(s)
[info]   Compilation completed in 10.158 s
[error] javac: invalid source release: 1.8
[error] Usage: javac <options> <source files>
[error] use -help for a list of possible options
[error] (compile:compile) javac returned nonzero exit code
[error] application - 

! @6jliijm36 - Internal server error, for (GET) [/] ->

play.PlayExceptions$UnexpectedException: Unexpected exception[The compilation failed without reporting any problem!]
    at play.PlayReloader$$anon$1$$anonfun$play$PlayReloader$$anon$$taskFailureHandler$1$$anonfun$apply$20.apply(PlayReloader.scala:235) ~[na:na]
    at play.PlayReloader$$anon$1$$anonfun$play$PlayReloader$$anon$$taskFailureHandler$1$$anonfun$apply$20.apply(PlayReloader.scala:235) ~[na:na]
    at scala.Option.getOrElse(Option.scala:120) ~[scala-library-2.11.2.jar:na]
    at play.PlayReloader$$anon$1$$anonfun$play$PlayReloader$$anon$$taskFailureHandler$1.apply(PlayReloader.scala:235) ~[na:na]
    at play.PlayReloader$$anon$1$$anonfun$play$PlayReloader$$anon$$taskFailureHandler$1.apply(PlayReloader.scala:229) ~[na:na]
Caused by: sbt.compiler.CompileFailed: null
    at sbt.compiler.JavaCompiler$JavaTool0.compile(JavaCompiler.scala:77) ~[na:na]
    at sbt.compiler.JavaTool$class.apply(JavaCompiler.scala:35) ~[na:na]
    at sbt.compiler.JavaCompiler$JavaTool0.apply(JavaCompiler.scala:63) ~[na:na]
    at sbt.compiler.JavaCompiler$class.compile(JavaCompiler.scala:21) ~[na:na]
    at sbt.compiler.JavaCompiler$JavaTool0.compile(JavaCompiler.scala:63) ~[na:na]
[warn] play - No application found at invoker init

I just could not run any of the sample java 8 project from intellij. any idea?

in this code, how to cleanup for very slow subscribers?
// and automatic cleanup for very slow subscribers (where the browser has crashed, etc).

Hi,

On line 106 of file HomeController : https://github.com/playframework/play-java-websocket-example/blob/2.6.x/app/controllers/HomeController.java#L106, you are checking origin like that:

return origin.contains("localhost:9000") || origin.contains("localhost:19001");

If someone sends an Origin header with the value localhost:90000 it will be valid even if this is not the same origin. I understand that the port 90000 doesn't exist at all, but imagine someone uses the following code (by simply modifying the code you provide):

return origin.contains("mydomain.com");

It is still possible to do Cross-Site WebSocket Hijacking by using (buying) the domain amydomain.com.

I think it would be preferable to use the equals or equalsIgnoreCase method.

Getting 404 for
http://localhost:9000/assets/stylesheets/main.min.css
and
http://localhost:9000/assets/javascripts/index.js
When using "gradlew runPlayBinary" runs fine with "sbt run".

It is too complicated, Not suitable for learning websocket.

I get the error below when trying to compile the project.
Also, resolving and downloading is extremely sloooooow (see total time below).
Is something wrong with the repositories?

[warn] ::::::::::::::::::::::::::::::::::::::::::::::
[warn] :: UNRESOLVED DEPENDENCIES ::
[warn] ::::::::::::::::::::::::::::::::::::::::::::::
[warn] :: com.typesafe.play#sbt-link;2.3-2014-03-25-58325fd-SNAPSHOT: not found
[warn] :: com.typesafe.play#play-exceptions;2.3-2014-03-25-58325fd-SNAPSHOT: not found
[warn] ::::::::::::::::::::::::::::::::::::::::::::::
[trace] Stack trace suppressed: run last *:update for the full output.
error sbt.ResolveException: unresolved dependency: com.typesafe.play#sbt-link;2.3-2014-03-25-58325fd-SNAPSHOT: not found
[error] unresolved dependency: com.typesafe.play#play-exceptions;2.3-2014-03-25-58325fd-SNAPSHOT: not found
[error] Total time: 2247 s, completed 09.04.2014 15:19:38

Current structure is a little ...how to say, messy.