playonlinux / playonlinux_tools Goto Github PK

Recently I have played a lot with writing local PlayOnLinux scripts to install and run some closed-source homemade programs.
Thus I have some thoughts to share with @qparis and the Team:

• currently it is hard to find good example of PoL script as they are published only as forum threads (see for example https://www.playonlinux.com/en/app-3064-Microsoft_Office_2016.html where we have our efforts joint);
• there are very small amount of PoL scripts published here on GitHub - about 135 files;
• of course I have read the articles at Wiki but they are not enough for complete understanding of how things works.

So I would suggest to publish all known 1741 scripts to some specially created GitHub repository on PlayOnLinux account.
This will allow users to read and write PoL scripts more effectively using existing scripts as a correctly working basement.
I think this will allow PoL (and Phoenicis PoL) to "beat" modern Bottles or Lutris projects ;)

Why if you used the exact same string that is recommended to be used (see http://wiki.playonlinux.com/index.php/Scripting_-_Chapter_10:_Script_Translation) the script throw a warning about ?

Checking bad gettext messages
 * Please select the setup file to run.
 * Please wait while $TITLE is installed.
                        [ Warning ]

I think this must be the other way, if you use them, it's ok. If you use something similar but not equal, warn about it.

note: The playonlinux forums do not work and I don't know where else to put this bug report.

This is using the original disk to install the game that were released.

The Starcraft: Brood War install does not work. I get an error message saying that it can't find the original Starcraft install even though that game is installed. I tried installing Brood War with Starcraft in the following states.

1. Base install
2. Base install with 1.15 patch
3. Base install with 1.15.2 patch

edit:
I noticed when I inspected the Wine directories that there were two wine directories for Starcraft. This is a bug. Starcraft: Brood War is suppose to install in inside the same directory as Starcraft. It is not suppose to create its own directory. From using this in the past, it didn't use to do this. Someone must have modified the install file which is how this bug got introduced.

edit2: The only fix that needs to be done is for Starcraft BroodWar CD installation directory to be changed to the same directory that Starcraft CD installation uses. All the patches use the correct directory.

When checking if strings can be extracted by xgettext it do it without --from-code option so it assume is ASCII.

Although string must be in English this don't mean that you can't have other non-ascii characters (for example in names) and I think is safer to call it assuming is encoded in UTF-8.

So this code:

check_xgettext_ok()
{
    if [ "$(which xgettext)" != "" ]
    then
        s_echo "Checking possible to extract string"

        if xgettext -L Shell "/tmp/script" &> /dev/null
        then
            s_ok 3
        else
            s_err 3
        fi
    fi
}

should be writted as:

check_xgettext_ok()
{
    if [ "$(which xgettext)" != "" ]
    then
        s_echo "Checking possible to extract string"

        if xgettext -L Shell --from-code=UTF-8 "/tmp/script" &> /dev/null
        then
            s_ok 3
        else
            s_err 3
        fi
    fi
}

In PlayOnLinux when you go to Configure->New and go through the virtual drive creator wizard and get to the Wine version section, you are unable to select the "System" Wine version and are forced to select a specific version of Wine. Please add an option to select the system version of Wine.