plone / plone.app.collection

Collections in Plone are the most powerful tool content editors and site managers have to construct navigation and site sections.

Overview

Collections in Plone are the most powerful tool content editors and site managers have to construct navigation and site sections.

This is a brand new implementation of collections for Plone, using ajax/javascript to make a simpler, easier and streamlined user experience for using collections. Having a more lightweight backend that does not depend on many nested criteria types.

It's designed with simplicity and usability as a main focus, so content editors and site managers can create complex search queries with ease.

plone.app.collection's Issues

Huge performance issues with thumbnail_view

thumbnail_view.pt uses a complex and non-limited logic to select and show the image used as a thumb for the view and it doesn't respect the collection result limits.

That leads to huge performance issues when selecting the view on a collection that has many results and many images inside the folderish content types.

Cannot see the configured number of days in relative date criteria

If I choose a relative date criteria in my collection, example: "within the next 30 days" and save the collection and try to edit it again I cannot see the configured number of days.

The collection works correct but I am not able to see what I have configured.

Never the less I miss the word "days" as label of days field.

This depends on deprecrated product plone.act

https://github.com/plone/plone.app.collection/search?utf8=%E2%9C%93&q=plone.act

Non recursive location filter is not supported

plone.app.collection does not support non recursive filter on object location (like the old Topic type), therefore it is not possible to migrate such Topic configurations.

Test isolation problems

Uncovered by a plone.testing version from an open PR:
plone/plone.testing#19
results:
http://jenkins.plone.org/job/pull-request-5.0/902/console
related references:
plone/Products.CMFPlone#447

Wrong days in calendar widget

A colleague of mine found a minor issue with the calendar widget inside the collection: When adding a time-based search term in collections and using the calendar widget to select a date, wrong days/dates are shown.

Plone versions used
Several, all Plone 4.

Steps to reproduce

1. Add new collection
2. Add search term from the "Dates" category (e.g. "Expiration date")
3. Change date-setting to "Before date" (or something else, that brings the calendar widget up)
4. Click in the last box, calendar widget comes up, shows wrong date

September 2018

Mon	Tue	Wed	Thu	Fri	Sat	Sun
26	27	28	29	30	31	1
2	3	4	5	6	7	8
9	10	...	...	...	...	...

(today is Monday, 10th Sept.)

Additional Information
We discovered this on several sites using "German" as set language (@@language-controlpanel) and "Montag" (Monday) as first day of week (@@calendar-controlpanel). Changing these settings to English and Sunday did not effect/correct the behavior of the portlet calendar widget.

It seems to be an issue with the first day of the week. Widget expects "sunday" but "monday" is the first.
Also, seeing the collection using the settings from @@calendar-controlpanel would be nice.

zcml condition does not work

According to https://dev.plone.org/ticket/13723 the following zcml condition does not work:

 <browser:page zcml:condition="not-have Plone-43"
      name="RSS"
      permission="zope2.View"
      for="plone.app.collection.interfaces.ICollection"
      template="templates/rss.pt"
      />

This overrides the view RSS from Products.CMFPlone/browser/syndication even if Plone 4.3 is installed.

I'll try to provide a pull request.

Absolute path for Location criteria not working for multi language site

I have a plone site with two languages accessible via /de /en .
When I create a new collection and add the location criteria (absolute path) while on the English branch (i.e /en), I get no items when the absolute path specified is in the /de branch. So my question is if the absolute path for the Location criteria considers the language "base folder" as the navigation root.

This worked well with old style plone collections a.k.a Topic

Comments give error on isPrincipiaFolderish

If a collection happens to pick up a Comment/Discussion Item, it will give the following error when using for example your Thumbnail View:

     Module zope.tales.tales, line 696, in evaluate
    URL: /var/lib/zope4.3.acpt/buildout-cache/eggs/plone.app.collection-1.0.13-py2.7.egg/plone/app/collection/browser/templates/thumbnail_view.pt
    Line 12, Column 0
    Expression: <PathExpr standard:u'context/getFoldersAndImages'>
    Names:

    {'args': (),
     'container': <Collection at /clients/xxx/project-area/168-170-blenheim-rd/photos/comments>,
     'context': <Collection at /clients/xxx/project-area/168-170-blenheim-rd/photos/comments>,
     'default': <object object at 0x1f244e0>,
     'here': <Collection at /clients/xxx/project-area/168-170-blenheim-rd/photos/comments>,
     'loop': {},
     'nothing': None,
     'options': {},
     'repeat': <Products.PageTemplates.Expressions.SafeMapping object at 0xbde6470>,
     'request': <HTTPRequest, URL=http://client1.zope43.acpt.thevirtual.co.nz/clients/DAXGroup/project-area/168-170-blenheim-rd/photos/comments/thumbnail_view>,
     'root': <Application at >,
     'template': <Products.Five.browser.pagetemplatefile.ViewPageTemplateFile object at 0xa1736d0>,
     'traverse_subpath': [],
     'user': <PropertiedUser 'robyn'>,
     'view': <Products.Five.metaclass.SimpleViewClass from /var/lib/zope4.3.acpt/buildout-cache/eggs/plone.app.collection-1.0.13-py2.7.egg/plone/app/collection/browser/templates/thumbnail_view.pt object at 0xe6f1390>,
     'views': <Products.Five.browser.pagetemplatefile.ViewMapper object at 0x7f6975966490>}

    Module zope.tales.expressions, line 217, in __call__
    Module Products.PageTemplates.Expressions, line 155, in _eval
    Module Products.PageTemplates.Expressions, line 117, in render
    Module plone.app.collection.collection, line 191, in getFoldersAndImages
    Module plone.app.contentlisting.catalog, line 44, in __getattr__

AttributeError: isPrincipiaFolderish 

We found this when creating a collection by tag, as it will pick up any comments on the tagged objects as well.

Table headings in tabular view use field id's not titles

When you use the tabular view, your table headings are the id of the fields you have selected.

It would be better if the content schema is introspected and titles are used instead.

A better enhancement might be to allow the user to choose what to display (id or title) when creating/editing the collection.