poanetwork / poa-dapps-validators

DApp for a list of validators with metadata for POA Network (Core/Sokol). Validators can update metadata using DApp.

POA Network Validators DApp

Validators DApp is built for POA Network based blockchains. It gives an opportunity for the current validators of the network to set their personal information on-chain. Also, everyone can view current validators' personal data from this DApp.

Base supported networks

• Core POA network (RPC endpoint: https://core.poa.network)
• Sokol testnet (RPC endpoint: https://sokol.poa.network)
• Kovan testnet (RPC endpoint: https://kovan.infura.io/)

Supported browsers

• Google Chrome v 59.0.3071.115+

MetaMask/Nifty Wallet extensions setup

• Connect to POA Network in MetaMask extension (See POA Network on MetaMask) or in Nifty Wallet extension (See POA Network on Nifty Wallet)

Validators DApp is based on POA Network Governance contracts

Validator role

Set metadata

If you are a new validator of the POA Network and your validator node is successfully launched, you should fill your personal data. To do it you need:

• connect to the corresponding endpoint of POA Network in Metamask
• select your voting key from accounts in Metamask
• click SET METADATA in the navigation bar
• fill all fields in the form of a new validator
• click + SET METADATA button
• confirm transaction in Metamask.

That's it. After DApp will get a receipt for the transaction you'll see a success message and your personal data will be added to the list of validators.

If you need to change already submitted data you need to repeat previous instruction with the only difference your changes will be applied after two confirmations from other validators.

Confirm and finalize change in metadata

If you are an active validator of POA Network you have an ability to confirm pending changes of personal information from other validators. To do it you need:

• connect to the corresponding endpoint of POA Network in Metamask
• select your voting key from accounts in Metamask
• click PENDING CHANGES in the navigation bar. You'll see all pending changes
• find pending changes card
• click Confirm button

If you see Finalize button, then 2 confirmations are already submitted and you or any other validator might click it to apply changes of validator's personal data.

Building from source

1. npm i

2. npm start

poa-dapps-validators's Issues

(Feature) Add RPC support instead of metamask

Problem:
Validators Dapp requires metamask. Although, there aren't transactions in this dapp
Solution:
Use RPC endpoint https://core.poa.network instead of metamask

(Fix) display empty card of company type for xDai chain

Problem: Empty company-validator cards are of user type in xDai chain

Solution: Display corresponding company attributes for xDai chain for empty cards.

(Update) New style for xDai Network

We need to have separate colors and logo for xDai network in Validators DApp. Example (yellow-orange color scheme): https://blockscout.com/poa/dai

(Feature) Render validators' registered (unconfirmed) physical address from PoPA

The PR that implements #74 only retrieves & renders a confirmed address from PoPA. This issue covers retrieving & rendering a registered (unconfirmed) address.

This also aims to prioritize the address information. The following list may represent the order of how reliable the information is:

1. Confirmed physical address from PoPA.
2. Registered (unconfirmed) address from PoPA.
3. Already existing address from ValidatorMetadata.sol (fallback scenario, meant to be deprecated/dropped/hidden?)

How this is prioritization is represented on the UI needs to be defined.

Keep only last verified address displayed

There is no benefit in displaying all of the addresses in this Dapp.
I want to open this issue as a ballot for other Validator to vote to find if they agree.

ALERT: Transaction Error. Exception thrown in contract code.

Frontend (on our private network) works for both dapps (validators and voting), but when we try to submit transactions (to finalize metadata or create new ballot for voting), we get this error in Metamask:

ALERT: Transaction Error. Exception thrown in contract code.

P.S.
It used to work and we were able to set metadata for validator and also confirm it. Now, we can't finalize it and submit any transaction

Is is related to gas limit? Metamask changes? How do we fix or debug it? Also, what additional information do you need?

Change progress bar

https://kimmobrunfeldt.github.io/progressbar.js/

Current progress takes whole screen and creates unwanted flashing screen

UI Changes to make better Metadata for the Validators

There needs to be more error trapping and explicitly defined fields.

Whilst reviewing https://validators.poa.network/ for myself, I saw a number of mistakes/issues (screen shots upon request - however, if you just look you too will see these.) I too had an issue initially during Network roll as a member of the Trinity Validator Set. I believe my issue was whether or not to use a comma or semi-semicolon to separate fields.

There were obviously bigger issues in those days. However, the issues that I’m seeing are probably fixed with a small cleanup of the UI. I think having explicitly defined fields such as:

Address 1, Address 2, City, State (Drop down), ZIP, USA (automatically appended due to current requirement - but there for completeness):

Furthermore - I actually think that we ought to hook in a third party API to check and perhaps suggests an address after the user submits there work. Should the individual not take the requirement - I’d like to suggest the idea of presenting the one that the individual provided AND the API for all to see.

In the case of a minor issue, I fully expect a reasonable individual to understand. But if there’s a ‘larger’ issue - again, I trust in the individual reviewing the data to come to their own conclusions.

Call `window.ethereum.enable` only when that really needed

Problem: For a user who has installed MetaMask and opened the Validators DApp for the first time in the current browser's session, the DApp asks permissions to get access to the list of accounts in MetaMask. But the app doesn't need to know the list of user's accounts until validator's Voting Key is really needed for some operation.

Solution: call window.ethereum.enable only when DApp requires Voting Key to take some action which supposes transaction signing (when the user goes to Set Metadata page or wants to Confirm/Finalize on Pending Changes page).

UX/UI - Verify/Finalize Validator's Data

Confirming a validator's metadata: there needs to be verbiage on the 'pending changes' tab to compel another validator that is confirming and/or finalizing to either verify the information via a different channel, know that the information is correct, and/or reach out to the new validator that the information is correct.

I could see people otherwise hitting 'ok' without giving this much thought - potentially resulting in bad data and having to re-do work later down the line.

Display the network currently selected in MetaMask when first visiting

Related to @6proof's comment.

DApp should select the network currently selected in MetaMask when first visiting in the current browser's session (we could use window.sessionStorage for that). If the chosen network is not supported by DApp, POA Core should be selected by default.

Network switcher is not displayed

In an old version of the Validators DApp we had a network switcher at the top right corner which allowed us to switch between networks if MetaMask is not installed:

poa-dapps-validators/src/index.js

Lines 234 to 244 in 35d64a8

	async onNetworkChange(e) {
	this.setState({ loading: true })
	const netId = e.value
	const web3 = setWeb3(netId)
	networkAddresses({ netId }).then(async config => {
	const { addresses } = config
	await this.initContracts({ web3, netId, addresses })
	})
	}

Please return this switcher back. It seemed to be removed with the latest changes made in January 2019.

(Bug) MetaMask is locked alert, but it is not locked

(Feature) Make Validators DApp display company info for xDai Network

xDai network will have companies as validators, so UI needs to be changed to be able to display company info instead of notary info.

A company as validator will only have the next data:

• wallet address (miningKey)
• company name
• contact email
• creation date

So, the validator card for the company should look like this:

Also, the Set Metadata page must let the validator mark the Company checkbox (to let the DApp know that the validator is a company, not a notary) and enter company's contact e-mail.

The company name should be stored in the existing firstName field of ValidatorMetadata contract. There're two additional fields should be added to the contract: contactEmail (bytes32) and isCompany (bool).

(Fix) Change MoC address

poa-dapps-validators/src/contracts/Metadata.contract.js

Line 61 in b6b91ab

fullAddress: '755 Bounty Dr 202',

As is: "755 Bounty Dr 202"
Should be "755 Bounty Dr 202, Foster City"

Check (and fix) Validators DApp according to upcoming changes in MetaMask

MetaMask will have some breaking changes soon: https://medium.com/metamask/breaking-changes-to-the-metamask-inpage-provider-b4dde069dd0a

Please check Validators DApp and fix it if needed.

Display physical addresses status based on voting key

It turns out, most validators use their voting key to send postcards in PoPA.

So it would be better to fetched physical addresses based on that key (except for MoC who doesn't have voting key). If there are no addresses on that voting key or voting key doesn't exist - retry fetching by mining key.

(Fix) invalid title for dApp

Problem: invalid title for validators dApp https://github.com/poanetwork/poa-dapps-validators/blob/core/public/index.html#L23

Solution: change to actual one: PoA validators dApp

Retrieve validators' physical addresses from PoPA dapp

• Retrieve validators' physical addresses from PoPA dapp rather than from validators dapp registry.
• Display the physical address in the same way it's being displayed nowadays. Evaluate adding a green circle (or any other visual aid) to state the fact of confirmation.

Open questions may have to be addressed in new issues:

1. Display only confirmed physical addresses or can we display unconfirmed ones (with some visual aid to reflect the fact of the pending confirmation)
2. Can a validator have multiple physical addresses? How to deal with this from a frontend perspective?
3. Evaluate removing physical addresses from validators dapp registry

(Update) Don't display MoC if it's removed

Problem: if a MoC is removed from validators set, it shouldn't be displayed in the list of validators in Validators DApp. This issue relates to poanetwork/poa-network-consensus-contracts#100.

Solution: remove displaying of MoC from Validators DApp if PoaNetworkConsensus.isMasterOfCeremonyRemoved() returns true.

Confirm and Finalize buttons don't work on the `Pending Changes` page

We have a pending change for Kovan network: https://validators.poa.network/poa-dapps-validators/pending-changes

When clicking on the Confirm or Finalize button the miningkey attribute is empty for some reason:

poa-dapps-validators/src/index.js

Line 138 in ff6726a

const miningKey = event.currentTarget.getAttribute('miningkey')

It is set on the line

poa-dapps-validators/src/components/AllValidators/index.js

Line 162 in ff6726a

return React.cloneElement(child, { miningkey: validator.address })

where it is not empty.

@gabitoesmiapodo any idea how to fix this?

UX/UI - Hide "Pending Change Requested Date" row if there is no date to show

Currently, on the DApp, the "Pending Change Requested Date" is displayed even when there is no date. This should be only visible if there is info there.

The wording of that row should also change, as Pending Change Requested Date doesn't make sense. I suggest removing the word "requested" so its just Pending change date. @igorbarinov thoughts?

(Fix) Replace logos to POA Network

Problem: logos refer to Oracles
Solution: replace to POA https://transfer.sh/VS5lp/Archive.zip

Able to view and set Validator MetaData with arbitrary account ( should this only work for valid votiing key )

Sokol: https://sokol-validators.poa.network

Seems like I can access the Validator MetaData page and click "SET METADATA" with a random Sokol account.

I didn't try to "SET METADATA", as transaction will likely fail.

Coins stuck in Nifty wallet

Hey all. If any one!
Trying to send on Ethereum.
Have no probs sending ETH.
But one coin - when trying to send from Nifty to MetaMask - always gets: "Transaction Error. Exception thrown in contract code."
With a sky high gas estimation, and Not enough balance to send etc.
Am new to Nifty. Can any one say what i´m doing wrong?
Many thanks.

(UI bug) the buttons are stuck together

(Bug) Duplicate text in alert

Unexpected token : In JSON at position 3 when open https://validators.poa.network/

When open https://validators.poa.network

can be related to Nethermind as RPC nodes

(Bug) "Pending changes" page shows duplicated rows

When I create pending change I see duplicated rows: http://prntscr.com/j05jd4 - the number of duplicated rows is equal to the number of previous pending changes creations.

I.e. if I created two pending changes before and I create a new one, I will see three pending changes. And so on.

I think the reason is in the next line of src/contracts/Metadata.contract.js:

let allChanges = await this.metadataInstance.getPastEvents('ChangeRequestInitiated', {fromBlock: 0});

The ChangeRequestInitiated event is tracked from the first block.

(problem) show total number of validators

Solution: display somewhere current total number of validators
also display on each validator the index in the array of validators

(Bug) confirmation and finalization txs with invalid voting key

Problem: transactions to confirm and finalize are sent to blockchain even if a user unlocks invalid voting key

Solution: show alert on clicking to the corresponding buttons, that the current unlocked voting key is invalid

METAMASK- Used Chainswap from Eth to BSC then: ALERT: Transaction Error. Exception thrown in contract code.

Can anyone help me sort this problem? I was trying to get my COURT from the Eth chain to the BSC chain so that I can stake them for Governance. Everything went well, swapped the tokens over, but when I try to depost them in the OptionRoom dAPP gvoernance page, I get the message "ALERT: Transaction Error. Exception thrown in contract code."

So, I don't want to hit the confirm button because I'm assuming this means something has gone wrong.

(see attachment for

screenshot)

Readme.md page is missing description and purpose of the app

• What is this app about
• What you can do in the app as a validator
• What you can do in the app as a contributor/token holder
• Which networks are supported

Also, I don't understand a purpose of screenshots in Readme. The app is available using a link. How to interact with the app should be available in wiki

(Fix) Physical address confirmation status is incorrect when DApp is connected to core.poa.network

Problem: For now, Validators DApp doesn't show correct confirmation status for physical addresses - all validators display gray icon that means Unconfirmed Address. Something was broken.

Solution: Retest DApp, find the reason and fix it.

(Bug) low gas price for transactions

(Bug) Validator expiration date incorrect for different time zones

Validator in Eastern time zone set metadata expiration date to 01/31/2025 and others who have verified in a different time zone had seen 01/30/2025

This seems to be an issue with which "time" was used as a base for the expiration date. Possible to convert validator input directly to unix time for storage or to use some type of string with validation rules.

(Fix) Replace RPC endpoint for xDai testnet chain

RPC endpoint alias: https://dai-test.poa.network

(Fix) Hard code MoC metadata

Problem: MoC metadata is not showing in DApp
Solution: Hardcode MoC metadata

(Feature) Handle multiple addresses from PoPA

Issues #75 and #78 render only one address from PoPA on the UI, but the ProoOfPhysicalAddress contract can store multiple confirmed and unconfirmed physical addressed of a given validator. This ticket is meant to cover these scenarios and how the UI should render the data.

Some suggestions:

• Render the first (confirmed or unconfirmed) physical address and show a tooltip/accordeon/etc to reveal the extra addresses.
• Just a tooltip that states that the validator has multiple addresses, either confirmed or unconfirmed.
• A link to the PoPA DApp, although we should add the corresponding feature to the UI of the latter DApp.

(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask

Problem: On November 2nd, 2018 MetaMask and other DApp browsers will stop exposing user accounts by default. Instead, dapps must request access using a new provider method: provider.enable(). Detailed info is available here: https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8

Solution: Fix the code which loads DApp according to instructions from What this means for developers section of the article mentioned above.

(Testing) Cover with react component unit tests

For QA/FrontEnd devs
Please write some unit tests
While doing it, you may refactor the code because it is not efficient enough.
Consider adding mobx

(Feature) Drop or Deprecate validators' address info from ValidatorMetadata.sol

Assuming the prioritization in issue #78 has been made, this issue covers, either:

• "Stop showing the physical address metadata from ValidatorMetadata.sol" (i.e. drop its usage) and remove/hide the corresponding set Metadata form fields + a link to the PoPA DApp, or...
• "Still show the physical address metadata from ValidatorMetadata.sol but highlight the fact that it has a low priority information is unconfirmed" (i.e. eventually deprecate its usage).

After the decision has been made, update the description of the ticket with more detailed requirements.