pol0 / crunch Goto Github PK

What steps will reproduce the problem?
1. Compile crnlib using GCC 4.2 or Apple LLVM 4.1 (the compilers included with 
XCode 4.5.2)

What is the expected output? What do you see instead?
Ideally it would compile without errors, but instead I see errors in 
crn_vector.h saying "'T' does not refer to a value" using Apple LLVM 4.1, or 
"There are no arguments to '__is_pod' that depend on a template parameter, so a 
declaration of '__is_pod' must be available"

What version of the product are you using? On what operating system?
I am using Crunch SVN revision 319 on Mac OS 10.7.5

Please provide any additional information below.
It sounds like boost::type_traits wraps __is_pod in some compiler checks to 
find a compatible version, though you probably don't want to add a boost 
dependency.

What steps will reproduce the problem?

1. I have downloaded the latest version (April 2012) and the Makefile of 
http://code.google.com/p/crunch/issues/detail?id=1.
2. I went to the crnlib folder and I started make.

What is the expected output? What do you see instead?

It injured me with that words :

julien@julien-H61M-D2H-USB3:~/lib/crunch/crnlib$ make
g++ crn_arealist.cpp -o crn_arealist.o -c
In file included from crn_core.h:90:0,
from crn_arealist.cpp:4:
crn_types.h:15:31: erreur: expected initializer before ‘uint64’
crn_types.h:16:31: erreur: expected initializer before ‘int64’
crn_types.h:24:10: erreur: ‘uint64’ does not name a type
crn_types.h:25:10: erreur: ‘uint64’ does not name a type
crn_types.h:33:10: erreur: ‘int64’ does not name a type
crn_types.h:34:10: erreur: ‘int64’ does not name a type
In file included from crn_core.h:92:0,
from crn_arealist.cpp:4:
crn_traits.h:46:4: erreur: ‘__int64’ was not declared in this scope
crn_traits.h:46:4: erreur: patron de l'argument 1 est invalide
crn_traits.h:47:4: erreur: patron de l'argument 1 est invalide
In file included from crn_core.h:93:0,
from crn_arealist.cpp:4:
crn_mem.h: In function ‘T* crnlib::crnlib_new_array(crnlib::uint32)’:
crn_mem.h:132:7: erreur: ‘uint64’ was not declared in this scope
crn_mem.h:132:14: erreur: expected ‘;’ before ‘total’
crn_mem.h:133:11: erreur: ‘total’ was not declared in this scope
crn_mem.h:138:72: erreur: ‘total’ was not declared in this scope
In file included from crn_core.h:94:0,
from crn_arealist.cpp:4:
crn_math.h: At global scope:
crn_math.h:60:33: erreur: ‘crnlib::math::is_power_of_2’ declared as an 
‘inline’ variable
crn_math.h:60:33: erreur: ‘bool crnlib::math::is_power_of_2’ redeclared as 
different kind of symbol
crn_math.h:59:19: erreur: previous declaration of ‘bool 
crnlib::math::is_power_of_2(crnlib::uint32)’
crn_math.h:60:33: erreur: ‘uint64’ was not declared in this scope
crn_math.h:95:14: erreur: ‘uint64’ does not name a type
crn_math.h:206:14: erreur: ‘uint64’ does not name a type
In file included from crn_core.h:95:0,
from crn_arealist.cpp:4:
crn_utils.h:134:29: erreur: ‘crnlib::utils::write_val’ declared as an 
‘inline’ variable
crn_utils.h:134:29: erreur: ‘bool crnlib::utils::write_val’ redeclared as 
different kind of symbol
crn_utils.h:133:19: erreur: previous declaration of ‘bool 
crnlib::utils::write_val(int, void*&, crnlib::uint&, bool)’
crn_utils.h:134:29: erreur: ‘uint64’ was not declared in this scope
crn_utils.h:134:41: erreur: expected primary-expression before ‘void’
crn_utils.h:134:58: erreur: expected primary-expression before ‘&’ token
crn_utils.h:134:60: erreur: ‘buf_size’ was not declared in this scope
crn_utils.h:134:70: erreur: expected primary-expression before ‘bool’
In file included from crn_core.h:98:0,
from crn_arealist.cpp:4:
crn_win32_timer.h:7:12: erreur: ‘uint64’ does not name a type
crn_win32_timer.h:13:25: erreur: expected ‘)’ before ‘start_ticks’
crn_win32_timer.h:16:18: erreur: ‘timer_ticks’ has not been declared
crn_win32_timer.h:21:7: erreur: ‘uint64’ does not name a type
crn_win32_timer.h:24:14: erreur: ‘timer_ticks’ does not name a type
crn_win32_timer.h:25:14: erreur: ‘timer_ticks’ does not name a type
crn_win32_timer.h:26:35: erreur: ‘timer_ticks’ has not been declared
crn_win32_timer.h:29:14: erreur: ‘uint64’ does not name a type
crn_win32_timer.h:30:14: erreur: ‘uint64’ does not name a type
crn_win32_timer.h:33:7: erreur: ‘uint64’ does not name a type
crn_win32_timer.h:34:7: erreur: ‘uint64’ does not name a type
In file included from crn_core.h:101:0,
from crn_arealist.cpp:4:
crn_dynamic_wstring.h: In destructor 
‘crnlib::dynamic_wstring::~dynamic_wstring()’:
crn_dynamic_wstring.h:23:35: erreur: invalid application of ‘sizeof’ to 
incomplete type ‘crnlib_assume_failure’
crn_dynamic_wstring.h:23:35: erreur: patron de l'argument 1 est invalide
crn_dynamic_wstring.h:23:83: erreur: invalid type in declaration before ‘;’ 
token
crn_arealist.cpp: In function ‘void crnlib::area_fatal_error(const char*, 
const char*, ...)’:
crn_arealist.cpp:23:46: erreur: ‘_vsnprintf’ was not declared in this scope
make: *** [crn_arealist.o] Erreur 1


What version of the product are you using? On what operating system?

Latest version of crunch (April 2012)
Ubuntu 12.04 32bits

Please provide any additional information below.

Latest version of gcc

What steps will reproduce the problem?
1. run crunch with this syntax:
alejandro@desktop:~/X-Plane/X-Plane_10$ 
/mnt/server/xplane/proyects/pol_editor/src-1.2/crunch -file 
/home/alejandro/t.png -fileformat dds -dxt3 -mipmode Generate -outdir 
/home/alejandro/

What is the expected output? What do you see instead?
expected output: /home/alejandro/t.dds
real output: /home/alejandro/\t.dds


What version of the product are you using? On what operating system?
v1.03 Prerelease - Apr. 26, 2012
OS: Linux debian squeeze amd64


Please provide any additional information below.

See patches for details. (Names should be descriptive enough.)

What steps will reproduce the problem?
1.using makefile downloaded from issues
2.alejandro@desktop:~/crunch-src/crnlib$ make

What is the expected output? What do you see instead?
expected output: linux binary
real output:
alejandro@desktop:~/crunch-src/crnlib$ make
g++ crn_decomp.cpp -o crn_decomp.o -c
In file included from crn_decomp.cpp:6:
../inc/crn_decomp.h: In function ‘void* crnd::crnd_realloc(void*, size_t, 
size_t*, bool)’:
../inc/crn_decomp.h:2535: error: cast from ‘void*’ to ‘crnd::ptr_bits’ 
loses precision
../inc/crn_decomp.h: In function ‘void crnd::crnd_free(void*)’:
../inc/crn_decomp.h:2563: error: cast from ‘void*’ to ‘crnd::ptr_bits’ 
loses precision
../inc/crn_decomp.h: In function ‘size_t crnd::crnd_msize(void*)’:
../inc/crn_decomp.h:2577: error: cast from ‘void*’ to ‘crnd::ptr_bits’ 
loses precision
make: *** [crn_decomp.o] Error 1

What version of the product are you using? On what operating system?
last crunch source. OS: linux debian squeeze amd64

Please provide any additional information below.

error LNK2005: "bool __cdecl crnd::crnd_validate_file(void const *,unsigned 
int,struct crnd::crn_file_info *)" 
(?crnd_validate_file@crnd@@YA_NPBXIPAUcrn_file_info@1@@Z) already defined

error LNK2005: "bool __cdecl crnd::crnd_get_texture_info(void const *,unsigned 
int,struct crnd::crn_texture_info *)" 
(?crnd_get_texture_info@crnd@@YA_NPBXIPAUcrn_texture_info@1@@Z) already defined

and more more more

if I include this file in many cpp

Header dependency tracking, cleaner output.

I noticed that in inc/dds_defs.h the sizeof structure DDSURFACEDESC2 is 124 
bytes, by calculating that with sizeof(). However, in my DDS tests, where I try 
to load a single DDS file, I see a DDS header length of 120 bytes, which does 
not match the above mentioned structure.

My loader works, if I calculate fileoffsets with 120 bytes, instead of the 
mentioned 124 bytes. Hence, the question is, is the definition of 
DDSURFACEDESC2 correct, or should it be instead 120 bytes?

A sample DDS attached in this issue, what I used for testing.

What steps will reproduce the problem?
1. Run crunch_x64.exe /file a.png /out a_x64.crn /quality 255 /mipMode None 
/DXT5 /quiet
on attached image
2. crunch.exe /file a.png /out a_x86.crn /quality 255 /mipMode None /DXT5 /quiet
3.

What is the expected output? What do you see instead?
a_x86.crn must be equal to a_x64.crn but it is not. Also a_x64.crn contains a 
lot of artifacts but a_x86.crn not.


What version of the product are you using? On what operating system?
the latest trunk version

Please provide any additional information below.

Here's a patch to fix the compilation on a linux 64bits system. I've compared 
the 32 and 64 bits files produced and they have same size. Also, the dds image 
looks exactly the same. However, there are some bytes that differ but doesn't 
seem to be a major issue though.

I would find it very useful if stitching capabilities were added to the crunchD 
commandline tool.

With stitching it would be possible to use multiple separate images as manually 
generated mipmaps. This is much like what the "stitch" tool from the NVidia DDS 
commandline utilities allowed.

As an additional feature request it would be nice if stitching was also 
possible for individual channels (R,G,B and A). The idea is that one can build 
a texture using channels input from separate greyscale images. This is useful 
in cases where the contents of a texture channel should be interpreted 
differently (eg. when the alpha channel contains specularity information)

To preface this, I rarely write C++ so please review this patch carefully :) I 
tested on OSX Lion and checked the build on my CentOS 5.5 box, unfortunately I 
don't have a Windows box to test with.

To get this building on OSX a few changes needed to be made due to gcc 4.7's 
strictness and OSX's lack of support for some of the pthread functionality. 
Also to note, I was using the previously posted Makefile for building.

The highlights of this patch are:

 - Converted from unnamed semaphores to named semaphores (OSX doesn't support unnamed).
 - Converted sem_timedwait to an alert + sem_wait (sem_timedwait isn't supported on OSX).
 - Added a shim for pthread_spinlock (doesn't exist on OSX) that calls into native functions.
 - Defined uint64 as unsigned long and int64 as long to get rid of ambiguity errors on OSX.
 - Updated function calls in crn_sparse_array to work with gcc 4.7.2's new two-phase lookup rules.

Not really correct on amd64, and breaks things nicely on non-x86.

With this and my other patches, particularly issue #13 (on which this has a 
hard dependency), it's possible to compile and run crunch on, for example, ARM. 
I've had it running, albeit slowly, on my Raspberry Pi.

I made a Makefile to build on Linux (meant to be put in /crnlib dir). Attached, 
I hope it's useful.

Running the following:

crunch -file btn_colony.dds -fileformat dds -A8R8G8B8 -out test.dds -mipMode 
None

on the attached file results in the following error:

crunch: Advanced DXTn Texture Compressor - http://code.google.com/p/crunch      

Copyright (c) 2010-2012 Rich Geldreich and Tenacious Software LLC               

crnlib version v1.01 x86 Built Apr 15 2012, 18:14:02                            


Reading source texture: "btn_colony.dds"            
Error: Failed reading source file: "btn_colony.dds" 

I was using crnlib SVN rev 319 for a game jam project 
https://github.com/David20321/JamForLeelah and ran into some small issues 
compiling a program using crn_decomp.h on Mac OS 10.7.5.

I just had to add some standard library includes: in crn_decomp.h I added 
<string.h> for memset and memcpy, and I used dlmalloc.c to get 
'malloc_usable_size', since it is apparently not part of the Mac malloc.h. In 
crnlib.h I added <stddef.h> to get a definition for NULL. Also as mentioned in 
other issues, __is_pod doesn't work with some compilers, so I just defined it 
to false.

I have attached a patch file with all the changes I made make it work, but 
ideally small parts of the code could be rewritten to not rely on 
malloc_usable_size() or __is_pod(), since they are not reliable across 
platforms and compilers.

How to do a realtime compression to a DXT1 crn?

Thanks in advance,
Arthur