polarstoat / stardew-crop-data Goto Github PK

This is how the game parses the data and can be seen in Object.cs::Object().

The crop.seed property for Coffee Bean contains the same data as crop, as the Coffee Bean crop is its own seed.

Should the crop.seed property somehow point to it's parent, or should the duplicated data be left?

{
  "433": {
    "name": "Coffee Bean",
    "description": "Plant in spring or summer to grow a coffee plant. Place five beans in a keg to make coffee.",
    "id": 433,
    "category": "Seeds -74",
    "cropsTilesheetIndex": 40,
    "seasons": [
      "spring",
      "summer"
    ],
    "growthStages": [
      1,
      2,
      2,
      3,
      2
    ],
    "regrowTime": 2,
    "sellPrice": 15,
    "healthRestored": -300,
    "scythe": false,
    "trellis": false,
    "yield": {
      "minimum": 4,
      "maximum": 6,
      "levelIncrease": 10,
      "extraChance": 0.02
    },
    "seed": {
      "name": "Coffee Bean",
      "description": "Plant in spring or summer to grow a coffee plant. Place five beans in a keg to make coffee.",
      "id": 433,
      "category": "Seeds -74",
      "sellPrice": 15,
      "healthRestored": -300
    },
    "flowerColors": []
  }
}

It could be useful to support extracting the data in languages other than English. This could be as simple as changing which ObjectInformation.xnb file is loaded, as the other translations appear to be in the same Data directory with localisation information appended to the filenames:

ObjectInformation.de-DE.xnb
ObjectInformation.es-ES.xnb
ObjectInformation.fr-FR.xnb
ObjectInformation.hu-HU.xnb
ObjectInformation.it-IT.xnb
ObjectInformation.ja-JP.xnb
ObjectInformation.ko-KR.xnb
ObjectInformation.pt-BR.xnb
ObjectInformation.ru-RU.xnb
ObjectInformation.tr-TR.xnb
ObjectInformation.xnb
ObjectInformation.zh-CN.xnb

This could be a good feature for major version v2, which may also include a CLI.

Implement checks to ensure that the format of the Stardew Valley data files is exactly as expected. This way users can be sure that the data they receive is valid, despite whether stardew-crop-data has been confirmed to work with a particular version of Stardew Valley.

The checks should include the length and types of data that is parsed.