GithubHelp home page GithubHelp logo

thunderlink's Introduction

ThunderLink

PLEASE NOTE: This add-on is currently maintained by @mikehardy and others at https://github.com/mikehardy/thunderlink

Current versions from that repository appear to have fixed all known regressions that accumulated over time as thunderbird was updated, and work well with all major operating systems, so the add-on works as it did when it was first created.

Please use that repository to report feature requests or issues, or submit pull requests.

Thanks!

thunderlink's People

Contributors

enigmasolved avatar mikehardy avatar riedel avatar simonthum avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

thunderlink's Issues

Feature Request: Ability to Move the Email to a Defined Folder when Custom String is Created

This is similar to #4 and #9. I could see it being useful to define that a given TL/Custom String have a folder associated with it, such that when that TL is created for a message the message is moved to the defined folder. Note that this would be specific to the particular Custom String that was called (ie, similar to how you can now define a different Tag for each Custom String).

Personally I don't have a pressing need for this feature at the moment. It is something I am toying with using for certain Custom Strings (eg, moving certain items to a Postponed folder). I think there are some instances where Tagging fully achieves what I want, and that there may be some instances where moving the message to a defined folder would better achieve my goal.

This is low priority feature for me currently as I'm unsure yet how much I'll use it, but I could see it being useful to others so thought I'd go ahead and put it on the list. :)

Strings not visible in settings

On windows 7 x64 but not linux gentoo (probably also a different TB: Win7 is 38.1, Linux is probably older), I cannot see the strings configured. I seem to be able to change them and creating a link works as expected, but they're not visible in the dialog at all.

Message not selected when not in Inbox

It seems that if Thunderlink is set to select a message when opening a thunderlink, it is only selected if it is located in the Inbox. If Thunderlink is set to open the message in a new window, it works as expected.

Feature Request: Open email in new window when loading link

This already seems to happen when Thunderbird is not running. However, I normally have some sort of workflow going in the main Thunderbird window, and I'd love for a thunderlink to open a new window for the linked email so that the main window is not disturbed.

Not working with Seamonkey 2.40

Hello, does anybody know why Thunderlink is not working with Seamonkey Mail V 2.40 ?
With not working I mean that when opening the xpi file with Seamonkey, nothing happens and the plugin is not installed.
Can this be forced ? I would love to be able to make links from Freeplane to emails in Thunderbird.

Cheers
Oliver

Drag/Drop thunderlinnk

Dear,

First of all my utmost appreciation for a piece of software that I use daily !

I was wondering if it would be possible to change the drag/drop behaviour of thunderbird such that drops - external to thunderbird - are dropped as thunderlinks ?

Thanks

Feature Request: Ability to Add More Custom Strings

(This is continuing a dialog begun via email.)
It's be great to have the ability to add an arbitrary number of Custom Strings. Personally, I might have use for 10-20 custom strings, but I'd recommend coding things to be able to handle up to 50 just to catch most use case scenarios.

Recent merges

Hi,

please not that my PR #25, since it came from master, got updated to contain lots of stuff that perhaps shouldn't have been merged. Notably, I added a -simon to the version to avoid ambiguities and added packaged versions thereof.

You may want to get rid of that.

README file is ambiguous

The installation instruction for Ubuntu Natty-and-newer is ambiguous:

  1. then, make a copy of your ~/.local/share/applications/thunderbird.desktop and name it thunderbird-tl.desktop
  2. Change the line that starts with Exec=thunderbird %u... to Exec=thunderbird -thunderlink '%u'...
  3. and the line that starts with MimeType=... to MimeType=x-scheme-handler/thunderlink; this entry for Thunderbird will thus serve only for handling ThunderLinks.

In bullets 3. and 4. it is not clear whether it is the original thunderbird.desktop file which should be edited, or the new thunderbird-tl.desktop file

Please clarify the licence, is it GPL or MPL-2.0?

Hello,

From the licence file in the repository it looks like this project is using MPL-2.0, but when opening the source code each file has the GPL header.

Can you clarify your position on the licence? I'm happy to create a pull request containing the needed change, but I would need to know the adequate licence for that :)

Thank you for your great plugin πŸ™

Feature Request: Ability to Customize Hotkeys for each Custom String

(This is continuing a dialog begun via email.)

It is fantastic that you're adding custom strings and adding Hotkeys. Eventually it would be really nice to be able to define/override Hotkey settings. There are a number of reasons for this. One is that one may not actually need Hotkeys for every Custom String (but only for the very frequently used ones). Additionally, the current setup ties the Hotkey combos to the order the Custom Strings are in, and this may not always make the most sense for certain ways of organizing one's Custom Strings.

Display problems of readme.md: registry code invalid

Dear developers,

I report on my problems to register the thunderlink:// protocol in Windows using the described procedure in the file readme.md as displayed on https://github.com/poohsen/thunderlink (the problem comes from the displaying, as will be explained). I managed to solve them for me, but other users might get stuck. The problems are all related to the registry file contents described. The comments should be valid for the 32 and 64 bit version. I am working on Win7 64 bit using Firefox and Notepad++, if relevant.

When you install Thunderlink from inside Thunderbird, you can see the about-text as on addons.mozilla.org, but you can not mark or copy it. You are looking for a way to get the .reg text to register the protocol in windows, as described. So you find the clickable link to the github page, where the readme.md is displayed, containing the same code. Hurray.

However, it seems that this file is parsed by github before displaying it, and thus the Registry code displayed becomes crippled:

  1. The word REGEDIT4 is displayed "syntax highlighted", a bit like a button, which might lead people to forget copying it when copying the text underneath; however, it is necessary to have a valid .reg file. If it is copied, it is preceded by a space. This seems not to cause problems, but is probably not intended (the file should start with REGEDIT4).
  2. Each valuename=value pair has to start in a new line. Otherwise, they are just silently ignored when running the .reg, so people will not realize where the problem comes from. However, on github, the newlines without empty line are removed, leading to two value pairs behind the first key and one value pair behind the last key. If copied to a .reg file, it runs, but does not do the actual job.
  3. The path in the last valuename=value pair contains backslashes that are correctly escaped as double backslashes in readme.md. However, the double backslashes are reduced to single backslashes when displayed on github, thus making the path invalid for the .reg file.

If you can not easily change this behaviour or the format of the readme.md file (to be displayed differently), I suggest you to put a warning before the code segments to not copy them from the github displayed version. You might include an url leading the user to the site https://addons.mozilla.org/en-US/thunderbird/addon/thunderlink/ where the code is formatted correctly for copy/paste.

Thanks for your work,
Best regards,
NΓΈk

Open thunderlink from Thunderbird Browser tab

Is there a way to open a thunderlink within a Thunderbird browser tab? I am able to click on the link, and the focus moves away from the tab (to nowhere), but the message is not opened. It works outside of Thunderbird, just not inside of it. I'm on Win 7 64-bit, Thunderbird 31.4.

Feature Request: Ability to Define a Thunderbird Tag that is Applied to the Email when Custom String is Created

(This is continuing a dialog begun via email.)

It could be nifty to be able to define a Thunderbird Tag that would be applied to the message in conjunction with a given custom ThunderLink being created. In other words, with each custom ThunderLink settings there could be an additional option to define a Tag to be applied to the message. This can be useful for enabling the user to clearly mark that they've "connected" a given message to whatever other system they're using (eg, they've created a Task for the message).

To further clarify: The idea is that for some custom ThunderLinks I (or a given user) may wish to "mark" the message they just created the ThunderLink for, as way of letting them know that they've already done something with that message.

For example, there are some emails that I want to create a ToDo (or Task) for some future date. In essence, I want to schedule when I will come back to this email and take care of it (eg, respond to it, do something required for it, etc.). However, I would like to somehow mark the message indicating to myself that I've already looked at it and that my ToDo/Task that I have created (outside of Thunderbird, but which contains the ThunderLink I created) will remind me of when I need to come back to this message. When I have a lot of emails I can't always remember which ones I've "scheduled" and then I can end up looking at the same message multiple times uneccessarily.

So the benefit of this feature is very much dependent on the user being consistent. It won't do much good if they Tag a message when creating a ThunderLink, but don't follow through with Pasting the ThunderLink wherever they intended to. But as long as one follows through I think it can serve as a visual indicator to them that they have "linked" (so to speak) that message with someother program.

In my case I might actually create multiple custom links that are identical except that one TL Tags the message and one does not. That way I would only choose to create the TL that will Tag the message (on TL creation) when I want that visual indicator (eg, I'm creating a Task for scheduling when to come back to the message), and for instances where I just want to be able to get back to the message at some point for reference, but am not scheduling it per se, I don't need to Tag it (but I might need the same custom link string if I'm using it in the same software).

Can't click thunderlink in MLO

On TB 31.0, Win 7 64 -
Followed instructions to install both FF plugin and registry entries.
Pasting a Thunderlink into a note field in MLO does not show up as a clickable link and not sure why.

In troubleshooting verified:
Thunderlinks open when pasted in FF bar
Thunderlinks do not work correctly when called from a command line if TL is surrounded by single quote (as per the examples) - throws error dialog "Couldn't find an email message for Thunderlink"
Thunderlinks DO work from cli if wrapped with double quote or no quotes at all.

How to proceed?
Thanks.

Below is the conversation thread I had with Cristoph by email for reference.


On 8/28/2014 4:52 PM, Christoph Zwirello wrote:

Hi,

please file an issue at https://github.com/poohsen/thunderlink re the MLO integration.
I'll ask Sean to take a look at it and give his input.

Can you also try step 1) with double quotes and with no quotes at all around the thunderlink? I can see the single quotes in your screenshot and I shouldn't be able to.

fyi: I'm on holidays as of now and I won't be answering any more emails until tuesday.

c

Am 28.08.2014 22:04 schrieb Joel Azaria:

Hi Cristoph,

I am absolutely certain that a different email was selected (I was
viewing yours and the thunderlink was to something else)
I don't remember if I restarted TB immediately after install, but it
has been restarted a few times since including one machine restart
yesterday.

To be sure, I just uninstalled TL, restarted TB, reinstalled TL,
restarted TB. Same results, same error from command line, still works
from FF.

So, how to proceed?

Thanks,
J.

On 8/28/2014 2:46 PM, Christoph Zwirello wrote:

This is really odd. Normally, if there are issues with the protocol registration, 1) would work but 2) wouldn't.
To be sure: are you 100% positive that TB is actually selecting the email? Or was it maybe already selected in your tests? If you select another email, then repeat test 2), can you see TB switch to the email from the thunderlink?

The test in 1) doesn't use the windows protocol registration at all. This is TB/TL only and if it's not working, then sth. is really wrong. Did you restart TB after you installed TL?

c.

Am 28.08.2014 20:38 schrieb Joel Azaria:

Forgot screenshot-----

image

Thanks Cristoph.

Perhaps thunderbird issue, perhaps not. My assumption is that the
.reg file should register a handler in windows for the thunderlink://
protocol - is that right? If so, then my guess is that it may not
have registered correctly or similar.

Regards your test requests:
For 1) - I get an error "couldn't find an email message.." See screenshot

For 2) - it works as intended. When I hit enter I get a dialog asking
me to choose the app to open this link with (T-bird already listed and
first) and when I click ok it focuses T-bird and focuses the intended
email message. So then it appears the FF handler plugin is working
right but the Windows handler is not.

My guess is if the Windows handler was working, the MLO should/would
recognize the thunderlink:// as a valid linkable/clickable link. Of
course if you wouldn't mind checking with the user that has gotten it
working, that would also be appreciated.

Thanks,
Joel.

On 8/25/2014 8:25 AM, Christoph Zwirello wrote:

Hi Joel,

sounds like an MLO issue, IMO. I can ask another user who I know has
managed to get it to work with MLO.
To be sure TL is actually working fine, can you:

  1. call thunderbird from the command line using the -thunderlink
    option and a valid thunderlink enclosed in single quotes? If running,
    TB should select the email, else it should start with just the email
    window and display the email contents

  2. what do you get if you paste the TL into the FF address bar?

c.

Am 25.08.2014 14:04 schrieb Joel Azaria:

Hi Cristoph,

Great idea for an extension. If I can get it to work it will be even
better :D

I installed the extension in TB, installed the FF plugin and pasted
and ran a .reg as advised (running W7 64).
I can successfully copy a link but when I paste it into
MyLIfeOrganized, it doesn't 'linkify'. Not sure what I'm doing wrong
or how to check.
Is there another step I need for MLO or can you please advise how to
troubleshoot/proceed?

Thanks,
Joel.

Some thunderlinks fail, due to .desktop file error

Hi

Thanks for making this super useful add-on. I find it really useful.
I have come across an issue, and I think I have the solution.
In short I thing the .desktop file needs to have

Exec=thunderbird -thunderlink '%u'
instead of
Exec=thunderbird -thunderlink %u

Details:

Thunderbird is failing to find an email. The email is in an IMAP mailbox, and exists.
If I make a new thunderlink the link is
thunderlink://[email protected]
If I then search for that link it fails to find it with the message:
"Couldn't find an email message for ThunderLink
thunderlink://messageid=010c01d1dc25790e090wiki-solutions.com"
You will see that the $ and @ symbols are missing in the message.
I'm using VimWiki, and pass requests to xdg-open and can confirm that the same error is produced by:
xdg-open thunderlink://[email protected]
I also confirm that other messages are opening correctly, for example:
thunderlink://[email protected] I've traced it down to the lack of single quotes, since when added, this works: thunderbird -thunderlink 'thunderlink://[email protected]'
So I changed the Exec line in the file "/usr/share/applications/thunderbird-tl.desktop" to this:

Exec=thunderbird -thunderlink '%u'

And that seems to have solved the problem.

Also, I thought it may be useful for other vimwiki users to have this bit of code, which, once placed in their .vimrc file will enable thunderlinks to work in the way they would expect. I've made a gist that you may want to put somewhere useful.

https://gist.github.com/artumi-richard/f5545b104e97a9ae444404d9b98f4b95

Thanks

Feature Request: Ability to Define Hotkey Sequences that are Sent to the OS After Custom String is Called

(This is continuing a dialog begun via email.)

I'm not even sure if this is possible. It would be convenient to have the ability to define a Hotkey Combo that is Sent to the OS by ThunderLink after creating the ThunderLink string. This would be so that invoking the creation of a ThunderLink string could culminate in ThunderLink executing a keyboard command for another application so that then all the user has to do is paste their custom string into that application. Currently, I have to create the ThunderLink string, invoke the proper Hotkeys for another application (in my case, MyLifeOrganized), then paste the ThunderLink string into that application. Adding the requested feature would remove several of those steps.

Feature Request: also accept message-URIs

Is it possible also to accept the message-URI scheme as used by Apple Mail, i. e. links of the form message://<Message-ID> or message:<Message-ID> such that links embedded in mails can be at least also used by people using Apple Mail?

Feature Request: Additional Option to Open in New Tabbed (or 3 Pane) Window

This is maybe a little bit unusual (or an edge case), and I'd actually be happy to do most of the code myself (and do a Pull Request), but I'm currently stuck (which I'll describe more about below). But first, a bit more on what I'm trying to achieve.

There are two (maybe more?) kinds of new mail windows that Thunderbird creates. One is the kind which ThunderLink currently initiates, which I've seen referred to as a standalone window in Thunderbird documentation. The other kind is what I call a "tabbed window" (or in Thunderbird documentation, a 3pane window). A tabbed or 3pane window includes the folder structure (usually on the left-hand side), but with the message being the selected tab.

Normally when you Open Message in New Window you get the standalone kind of window. But if you already have a message open in a tab and you select Move to New Window you will get a 3pane window instead. In general I have preferred the standalone format (it is cleaner in appearance). But I've found that there are some reasons I'd like to switch to using the 3pane window format instead (if it can be achieved relatively easily).

Here are some relevant bits of Thunderbird code:
replaceTabWithWindow:
https://mxr.mozilla.org/comm-central/source/mail/base/content/messenger.xul#231
https://mxr.mozilla.org/comm-central/source/mail/base/content/tabmail.xml#792

duplicateTabIn:
https://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser.js#7049

displayMessage (and related) helper functions:
https://mxr.mozilla.org/comm-central/source/mail/base/modules/MailUtils.js#98
Which is what Thunderlink uses:
https://github.com/poohsen/thunderlink/blob/master/components/thunderlinkCommandLineHandler.js#L117

My thinking is that I may be able to use one of the helper functions to do what I want:
https://mxr.mozilla.org/comm-central/source/mail/base/modules/MailUtils.js
And I suspect the key may be in sending something for the optional variable aViewWrapperToClone which is in several of these functions. Where I'm stuck is that I don't yet comprehend how or what to pass for that variable in order to tell Thunderbird I want a 3pane window. For example, once I know what to pass in, the following addition to Thunderlink (along related code) may achieve my goal: MailUtils.openMessagesInNewWindows([msgHdr], aViewWrapperToClone_ToGet3PaneWindow);.

So if anyone knows what I need to pass in for that variable aViewWrapperToClone in order to indicate I want to clone a 3pane view, that would be super helpful! Then I can likely do the rest on my own (hopefully) and submit a pull request to merge in the addition (for others benefit).

Thanks in advance to any who offer help! :)
Sean

New Lines not working in Windows 7 Pro, x64.

(This is continuing a dialog begun via email.)
Windows 7 Pro, x64. Thunderbird 24.0. ThunderLink 0.09.

I can see in prefs.js where the \n have been created, but they are treated as just text characters and not true CR``LF characters (per how they're displayed in Notepad++). I understand this works fine on Linux, so something is amiss either on Windows or perhaps with my particular installs. I just a little Google searching and here are a few potentially relevant pages and then my conclusions:
http://stackoverflow.com/questions/4997743/copying-formated-text-into-clipboard
http://social.msdn.microsoft.com/Forums/vstudio/en-US/ba3693ee-1c26-42c3-8ab4-aea32f558347/copying-text-to-clipboard-lost-formatting

Based on the above I tried changing the \n to \r\n (while Thunderbird is closed!) and then opened TB and tried that particular ThunderLink and the New Lines worked! I'm not sure though why the TB multi-line text box doesn't already store the data that way in the first place. Or maybe there is something not working right when the data is saved to string to be stored in prefs.js? Interestingly enough, if I copy one of the other custom strings (that are stored with just \n) out of the text box itself it does copy correctly with the New Line.

Sean

Email Subject's with Unusual Characters can Produce Strange Results

(This is continuing a dialog begun via email.)

Windows 7 Pro, x64. Thunderbird 24.0. ThunderLink 0.09.

An email with the following characters in it produced a string that looked like it was base64 encoded (instead of displaying the correct email subject): ’ β„’

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.