GithubHelp home page GithubHelp logo

pop-os / desktop-widget Goto Github PK

View Code? Open in Web Editor NEW
42.0 10.0 34.0 719 KB

Pop Desktop Settings Widget

License: GNU Lesser General Public License v3.0

Makefile 1.05% Rust 37.33% C 1.24% Fluent 56.49% FreeMarker 3.89%

desktop-widget's Introduction

Pop Desktop Settings Widget

A GTK widget for Pop!_OS shared between GNOME Initial Setup and GNOME Settings.

desktop-widget's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

desktop-widget's Issues

Dock Options feature and copy organization

  • Change Show Dock to Enable Dock
  • Move Show Dock on Display from Dock Options to the bottom of "Dock Visibility"
  • Change Show Mounted Volumes to Show Mounted Drives
  • Enable Show Mounted Drives by default.

With this, appearance panel can't shrink to too narrow a width

I noted this wasn't working quite correctly. When the window is make too narrow, Gnome Control Center collapses the panel and shows the list of panel, and when switching back to the Appearance panel, it can't shrink as narrow as most panels.

After some testing, it seems the GtkStackSwitcher in the title bar is the cause. Not sure what alternative would be better here.

Settings interface not matching Workspace configuration

pop-cosmic 0.1.0161954124721.04~a407611

How to reproduce:

  1. Set workspaces to static and logout and back in.
  2. Re open settings.

The workspace radio button is marked to "dynamic" though the interface is still set static with the correct number of desktops.

Screenshot from 2021-04-27 13-12-03

When opened in G-C-C, the window cannot shrink to a manageable height

I haven't measured the exact size, but when the Appearance section is focused in Settings, the window grows to extraordinary size and cannot be shrunk to a more normal size. I believe putting the window contents into a ScrolledWindow would probably fix this issue.

image

This window does not fit on a 1920x1080p monitor, and hides the dock placement settings from view entirely unless the user drags the window up with Super+Click (and knows about this functionality).

Super key does not open launcher in VM

When setting the Super Key Action to Launcher, nothing happens when it is pressed.

Screenshot from 2022-01-07 21-58-05

Pop!_OS Info

NAME="Pop!_OS"
VERSION="21.10"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 21.10"
VERSION_ID="21.10"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=impish
UBUNTU_CODENAME=impish
LOGO=distributor-logo-pop-os

Missing Translations

As #47 (and #48) is only specific to some part of the translation, I wanted to create a more generic issue. Here are my findings:

Desktop menu item and its title is not translatable

image

Theme options are not translatable

image

Dock Size (will be addressed by #47 and #48)

image

Translations not working

On 22.04, I don't see any translations showing up. For example, trying to test #90, I installed that branch, created a new user via G-C-C, set the new user's account to French via the Users panel in G-C-C, and logged in with that user. I see some strings translated (such as the name of the section in the sidebar), but the strings within the page are not translated:

Screenshot from 2022-04-11 11-11-32

The same thing is happening in 21.10 with the Polish translation from #89:

image

Can't change Dock to autohide in Gnome Control Center - Cosmic

Described here: pop-os/cosmic#91

From gnome-control-center:

(gnome-control-center:762447): dconf-DEBUG: 11:56:28.687: watch_fast: "/org/gnome/shell/extensions/pop-cosmic/" (establishing: 2, active: 0)
(gnome-control-center:762447): dconf-DEBUG: 11:56:28.689: watch_fast: "/org/gnome/shell/extensions/multi-monitors-add-on/" (establishing: 0, active: 0)
11:56:28.0730                 cc-window:    DEBUG: Time to open panel 'Desktop': 0,151022s
11:56:28.0730                 cc-window:    DEBUG: Added 'wifi' to the previous panels
11:56:28.0740          network-cc-panel:    DEBUG: Disabling periodic Wi-Fi scan
11:56:28.0741          network-cc-panel:    DEBUG: Disabling periodic Wi-Fi scan
(gnome-control-center:762447): dconf-DEBUG: 11:56:42.962: change_fast
(gnome-control-center:762447): dconf-DEBUG: 11:56:49.923: change_fast
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Can\'t set readonly key", filename: "/build/pop-desktop-widget-I2xd9r/pop-desktop-widget-0.1.0~1624553447~21.04~6469854/vendor/gio/src/auto/settings.rs", function: "gio::auto::settings", line: 453 }', src/lib.rs:481:55
stack backtrace:

Can I fix that? Or config de dock from command line?

Thanks!

Internationalization

I'd like to take this opportunity to thank you for enabling us to configure more of our desktop experience without having to install arbitrary extensions.
I use my desktop environment in Turkish language. There seems to be a few problems in GNOME Settings in terms of i18n and there is no translation at all inside Desktop menu.
I checked the source code but couldn't find anything that may be the starting point for the translation part. Unfortunetely I'm not able to write Rust atm. (I also don't know about various GTK related stuff that I saw inside the code which makes it a lot harder)
I guess there is no translation support at the moment but if you happen to be providing the translation files, I'd more than happy to translate it into Turkish. Thanks!

Expose options to disable/enable pressure requirement for dock/hot corner

Distribution (run cat /etc/os-release):

NAME="Pop!_OS"
VERSION="21.04"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 21.04"
VERSION_ID="21.04"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=hirsute
UBUNTU_CODENAME=hirsute
LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy $PACKAGE NAME):

pop-cosmic:
Installed: 0.1.0162629704321.042b297b4
Candidate: 0.1.0
162629704321.042b297b4
Version table:
*** 0.1.0162629704321.04~2b297b4 1001
1001 http://ppa.launchpad.net/system76/pop/ubuntu hirsute/main amd64 Packages
1001 http://ppa.launchpad.net/system76/pop/ubuntu hirsute/main i386 Packages
100 /var/lib/dpkg/status

Issue/Bug Description:

When using Pop OS Cosmic in a Virtual Machine(In this case VMware fusion, but get the same behavior in workstation) if the dock is set to intelligently hide and a window overlaps it a user cannot bring the dock up by moving the mouse to the dock area on the screen. See the screenshot as you get a window expansion cursor. I have confirmed this is an issue in VMware Workstation and Fusion however not an issue on a native install.

Screen Shot 2021-07-20 at 11 08 19 AM

Steps to reproduce (if you know):

Install Pop OS 21.04 in VM.
Set Dock to intelligent hide.
Allow window to overlap dock.
Move mouse cursor to dock location in order to unhide it.

Expected behavior:

Dock appears when mouse over.

Other Notes:

"Multi-monitor behavior" likely infeasible

There's an upstream issue about this. This blog post about Gnome 40 specifically mentions that the behavior here is unchanged.

As far as I can tell there is currently no way to provide the "Displays have separate workspaces" mode (extension, gsettings, etc.). And since workspaces are part of Mutter, it probably cannot be done just with shell extensions. Modifying Mutter to support it is likely complicated, and too much trouble at least if upstream is not interested in the same behavior.

So it would be nice to support, but we may have to remove the setting unless someone has an idea about how this could work.

GIS pages not showing translations

desktop-widget pages in GIS are showing up in English, even if the user account is set to a different language with a translation available:

gis1

Non-desktop-widget pages are showing in the correct language:

Bildschirmfoto von 2021-08-10 09-21-17

This is recreatable with at least German and Portuguese (both of these have their Settings -> Desktop translations working.) Does https://github.com/pop-os/gnome-initial-setup need some kind of initialization like other apps have needed, or is something else going wrong?

Build failing?

After pull request #59 the project is not building anymore.

$ make                       
cargo build --release
    Updating git repository `https://github.com/pop-os/theme-switcher`
error: failed to get `pop-theme-switcher` as a dependency of package `pop-desktop-widget v0.1.2 (/home/cap/dev/cappp/desktop-widget)`

Caused by:
  failed to load source for dependency `pop-theme-switcher`

Caused by:
  Unable to update https://github.com/pop-os/theme-switcher?branch=gtk-rs-0.14#01421df5

Caused by:
  object not found - no match for id (01421df5a4d172d15a0a99c182e7bf1ba05d092f); class=Odb (9); code=NotFound (-3)
make: *** [Makefile:31: target/release/pop-desktop-widget] Erro 101

image

After installing the options do not appear in settings

I installed this configuration options in order to be able to configure Cosmic dock i installed before.
I ran through the commands:
git clone https://github.com/pop-os/desktop-widget
cd desktop-widget
make
sudo make install
installation was successful but options did not appear in the settings menu even after restart.
I'm using Arch Linux with Gnome 41 on Wayland

expose click-action options

issue:

There is no way to customize the click-action of cosmic-dock from GCC > Desktop > Dock panel

suggestion:

Implement a GtkComboText in Dock and present the choice of Click-action.

suggested ui screenrecord:

Note: Screenrecord based on patched GCC, you can find it on ubuntu/impish branch on gcc-modified

Peek.2021-06-30.21-52.mp4

Thanks!

Custom dock size loses focus when size matches other options

When using the custom size option for the dock the radio button jumps from "custom" to the appropriate size if the number in the spin button is the same as one of the defaults. This loss of focus feels wrong even if its technically kind of cool.

To witness the issue simple pick one of the smaller sizes for the doc. Then select custom and go up to the next available size using the spin button. You will lose focus at the moment you hit the next options size and must click custom again to continue.

In some ways I like the interaction with the user, but if this is on purpose instead of a bug maybe we can change the font of the non-custom option instead of pulling the users away from the option they are currently on?

Naming Mismatch in Widget (maybe gnome-control-center).

Mentioned in pop-os/gnome-control-center#187

Issue

There is a disconnect between what we search for and the naming structure within the widget and gnome-control-center.

In GCC the settings for Cosmic is titled "Desktop", but searching for Desktop takes you to Desktop-->Background.

Searching for Cosmic will bring you to Desktop-->General, but without an option called "Cosmic" in GCC how will the user know to search for it?

Suggestions

Either within the widget or GCC the option should match the title.

  1. Background should got to Desktop-->Background and Desktop should go to Desktop-->general. Cosmic should be dropped or used as a keyword.
  2. We change the top level menu item from Desktop to Cosmic and change Background to Desktop.
  3. A mixture of 1 and 2.

I lean toward suggestion 1 as Desktop is more descriptive than Cosmic and options should match their intended use.

Desktop subcategories not searchable in launcher/applications menu

For other multi-page Settings categories such as Privacy, the subcategories (Location Services, Thunderbolt, etc) are returned as search results in the Pop Shell launcher and the GNOME Shell applications menu.

For the Desktop category, I'm not able to search for Appearance, Dock, or Workspaces. The Desktop section does appear if I search for Background, but it looks like that's only because the Desktop section's description text includes the word "background."

failed to get `gtk-extras` as a dependency of package `pop-desktop-widget v0.1.2

I cloned the desktop-widget and tried to build it. It is similar to #68 but with a different cause by reason. I am using Debian 11 with Gnome 3.38.5 using Wayland.

dale@debian11:~/Git/desktop-widget$ make
cargo build --release
Updating git repository https://github.com/pop-os/gtk-extras
error: failed to get gtk-extras as a dependency of package pop-desktop-widget v0.1.2 (/home/dale/Git/desktop-widget)

Caused by:
failed to load source for dependency gtk-extras

Caused by:
Unable to update https://github.com/pop-os/gtk-extras?branch=gtk-rs-0.14#590a8b61

Caused by:
object not found - no match for id (590a8b6166b3c52d9446a661f55b025814a18dd4); class=Odb (9); code=NotFound (-3)
make: *** [Makefile:31: target/release/pop-desktop-widget] Error 101
dale@debian11:~/Git/desktop-widget$

Undesired Applications shortcuts

I found these applications shortcuts yesterday in cosmic 21.04

Screenshot from 2021-07-15 11-38-38
You can fix this by adding this line to their respective .desktop shortcuts

NoDisplay=true

edit these 4 shortcuts by adding that line:

sudo nano /usr/share/applications/gnome-background-panel-workspaces.desktop
sudo nano /usr/share/applications/gnome-background-panel-dock.desktop
sudo nano /usr/share/applications/gnome-background-panel-appearance.desktop
sudo nano /usr/share/applications/gnome-background-panel-cosmic.desktop

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.