popupmaker / popupmaker-extension-boilerplate Goto Github PK

My feeling is that most extensions will not need an extensive setup routine, and even when they do, it'll usually be done at page load. So my suggestion is that the admin boilerplate JS be simplified to just

(function () {
  "use strict";
  jQuery( function ($) {
    if ($('body.post-type-popup form#post').size() === 0) return;
    // do whatever
  });
}());

The boilerplate as it is now is not very useful. It is both bloated and lacking at the same time. There is typically a lot of removal of code & extensive file building required after initial setup before a product can even become a reality.

Plans

Build a fully functional multi faceted boilerplate with a little bit of every type of extension we currently have including:

• Mailing list integration
• New Triggers
• Extra Global Settings
• Extra Theme Settings
• Extra Popup Metaboxes
• Extending existing settings
• Adding additional admin pages to our menus
• Custom Admin / Site CSS & JS files

Once this is done, a build process will be built to optionally enable/disable each of these items. The build will also collect plugin details and replace prefixes automatically. Once build is finished it will be saved in its own folder with the collected plugins slug. After build is complete the extension will be a raw & ready to add in your customizations. This means that within minutes a new extension can be ready for building, and the focus is only on the new functionality.

@fpcorso Thoughts?

Change https://github.com/PopupMaker/PopupMaker-Extension-Boilerplate/blob/master/plugin-name/includes/class.extension-activation.php#L37

to

    $plugin_path = array_filter( explode( '/', str_replace('\\', '/', $plugin_path ) ) );