GithubHelp home page GithubHelp logo

portapps / brave-portable Goto Github PK

View Code? Open in Web Editor NEW
301.0 14.0 34.0 649 KB

🚀 Brave web browser portable for Windows

Home Page: https://portapps.io/app/brave-portable/

License: MIT License

Go 97.27% Inno Setup 2.73%
brave portable windows golang portapps

brave-portable's Introduction

GitHub release Total downloads Build Status Go Report
Become a sponsor Donate Paypal

Notice of Non-Affiliation and Disclaimer

Portapps is not affiliated, associated, authorized, endorsed by, or in any way officially connected with Brave™, or any of its subsidiaries or its affiliates.

The official Brave™ website can be found at https://brave.com.

The name Brave™ as well as related names, marks, emblems and images are registered trademarks of their respective owners.

About

Brave™ portable app made with 🚀 Portapps.
Documentation and downloads can be found on https://portapps.io/app/brave-portable/

Contributing

Want to contribute? Awesome! The most basic way to show your support is to star the project, or to raise issues. If you want to open a pull request, please read the contributing guidelines.

You can also support this project by becoming a sponsor on GitHub or by making a Paypal donation to ensure this journey continues indefinitely!

Thanks again for your support, it is much appreciated! 🙏

License

MIT. See LICENSE for more details.
Rocket icon credit to Squid Ink.

brave-portable's People

Contributors

crazy-max avatar dependabot-preview[bot] avatar dependabot[bot] avatar github-actions[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

brave-portable's Issues

NativeMessagingHost seems broken after v0.67.124-28

Behaviour

Portable Brave is unable to bind itself to KeePassXC using the ad-hoc extension

Steps to reproduce this issue

  1. Have both KeePassXC running and configured to enable browser integration and related browser extension installed
  2. Connect the KeePassXC extension to the KeePass Database
  3. Have some credentials stored in password manager for some page.
  4. Shutdown the browser and restart it

Expected behaviour

The password manager is still found as running by the extension which can discuss with it.

Actual behaviour

The extension is unable to bind itself with the password manager and shows it via its toolbar icon and error message in the related dropdown.

Configuration

App release / arch (ex. 1.0.0-2 win64) : v0.67.124-28 (OK) / v0.68.131-29 (KO) / v0.68.132-30 (KO)

Operating system (ex. Windows 10 Pro 64 bits) : Microsoft Windows [version 10.0.16299.15]

Winver screenshot : is it really needed?

Screenshots

n/a

Logs

This is more a browser issue than a launcher one, but as you already made what was needed in the browser itself to have it portable.

This seems related to brave/brave-browser#5074

A script to set default file and protocol associations

I am not using the bug template, as this is just a question / possibly feature request, and I am not even sure if this is wanted.

I have written this script to add Brave portable to the default programs list so that it can be associated with the supported files and protocols. The script is loosely based on https://raw.githubusercontent.com/henrypp/chrlauncher/master/bin/SetDefaultBrowser.bat, but I have simplified and rewritten the code to both register and de-register Brave portable from the default programs list (if already registered). This way, running the script for the first time will register Brave as the default browser, and then running it again will de-register it, which I believe suits the "portable" status of the application.

The script is as follows. Please feel free to use it if you find any need for it.

set-default-browser.cmd

@echo off
cls

set "program_name=Brave portable"
set "program_name_short=brave-portable"
set "program_description=Brave portable on Windows by Portapps"
set "program_client=StartMenuInternet"
set "program_path=%~dp0%program_name_short%.exe"
set "program_icon=\"%program_path%\",0"
set "program_arguments=\"%program_path%\" \"%%1\""

>nul 2>&1 reg add "HKLM" /f || (
  echo ERROR: Insufficient privileges. Please run the script as Administrator.
  echo;
  pause
  exit /b
)

>nul 2>&1 reg query "HKLM\Software\RegisteredApplications" /v "%program_name_short%"

if %errorlevel% equ 0 (
  echo;Removing default associations for %program_name%...
  echo;

  2>nul reg delete "HKLM\Software\RegisteredApplications" /v "%program_name_short%" /f
  2>nul reg delete "HKCR\%program_name_short%HTML" /f
  2>nul reg delete "HKCR\%program_name_short%URL" /f
  2>nul reg delete "HKLM\Software\Clients\%program_client%\%program_name_short%" /f
) else (
  echo;Adding default associations for %program_name%...
  echo;

  2>nul reg delete "HKLM\Software\RegisteredApplications" /v "%program_name_short%" /f
  reg add "HKLM\Software\RegisteredApplications" /v "%program_name_short%" /t REG_SZ /d "Software\Clients\%program_client%\%program_name_short%\Capabilities" /f

  2>nul reg delete "HKCR\%program_name_short%HTML" /f
  reg add "HKCR\%program_name_short%HTML" /v "" /t REG_SZ /d "%program_name% Document" /f
  reg add "HKCR\%program_name_short%HTML\DefaultIcon" /v "" /t REG_SZ /d "%program_icon%" /f
  reg add "HKCR\%program_name_short%HTML\shell\open\command" /v "" /t REG_SZ /d "%program_arguments%" /f

  2>nul reg delete "HKCR\%program_name_short%URL" /f
  reg add "HKCR\%program_name_short%URL" /v "" /t REG_SZ /d "%program_name% Protocol" /f
  reg add "HKCR\%program_name_short%URL" /v "EditFlags" /t REG_DWORD /d "2" /f
  reg add "HKCR\%program_name_short%URL" /v "FriendlyTypeName" /t REG_SZ /d "%program_name% Protocol" /f
  reg add "HKCR\%program_name_short%URL" /v "URL Protocol" /t REG_SZ /d "" /f
  reg add "HKCR\%program_name_short%URL\DefaultIcon" /v "" /t REG_SZ /d "%program_icon%" /f
  reg add "HKCR\%program_name_short%URL\shell\open\command" /v "" /t REG_SZ /d "%program_arguments%" /f

  2>nul reg delete "HKLM\Software\Clients\%program_client%\%program_name_short%" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%" /v "" /t REG_SZ /d "%program_name%" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\DefaultIcon" /v "" /t REG_SZ /d "%program_icon%" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\shell\open\command" /v "" /t REG_SZ /d "\"%program_path%\"" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\InstallInfo" /v "IconsVisible" /t REG_DWORD /d "1" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\Capabilities" /v "ApplicationIcon" /t REG_SZ /d "%program_icon%" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\Capabilities" /v "ApplicationName" /t REG_SZ /d "%program_name%" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\Capabilities" /v "ApplicationDescription" /t REG_SZ /d "%program_description%" /f
  reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\Capabilities\StartMenu" /v "%program_client%" /t REG_SZ /d "%program_name_short%" /f
  for %%a in (htm html pdf shtml svg webp xht xhtml) do reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\Capabilities\FileAssociations" /v ".%%a" /t REG_SZ /d "%program_name_short%HTML" /f
  for %%a in (ftp http https mailto webcal urn tel smsto sms nntp news mms irc) do reg add "HKLM\Software\Clients\%program_client%\%program_name_short%\Capabilities\URLAssociations" /v "%%a" /t REG_SZ /d "%program_name_short%URL" /f

  %windir%\system32\control.exe /name Microsoft.DefaultPrograms /page pageDefaultProgram\pageAdvancedSettings?pszAppName=%program_name_short%
)

echo;
pause
exit /b

1.17.73-67 not work on Windows 10

Behaviour

Steps to reproduce this issue

  1. download brave-portable-win64-1.17.73-67.7z
  2. unpack to replace old version
  3. start

Expected behaviour

brave start

Actual behaviour

nothing happen

Configuration

**brave-portable-win64-1.17.73-67.7z or win32 version

Operating system (ex. Windows 10 Pro 64 bits) : Windows 10 Ent x64

Winver screenshot : Microsoft Windows [Version 10.0.19042.662]

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Join the log file log\[appname]-portable.log to this issue.

Tor in Brave doesn’t work

Behaviour

Steps to reproduce this issue

  1. Just try to open a tor webpage in a brave-tor-window

Expected behaviour

Open the webpage

Actual behaviour

Only loads it with a backward turning circle.

Configuration

App release / arch: 1.18.78

Operating system: Windows 10 Education 64 bit)

Brave hangs on "Save and fill payment methods" page, can crash

First, I am NOT running a vanilla Win10. So the first thing someone should do it test to see if this happens on a vanilla Win10. If not, then it's just me.

Settings > scroll down to "Additional Settings" > Autofill > Payment Methods
When I enter the page, Brave hangs after about 5 seconds.
I get a Win10 Blue rotation circle for about a minute.
If, after the hang clears, I slide the "Save and fill payment methods" to OFF, everything works as it should.

But, If, before the 5 second hang, I move the "Save and fill payment methods" to OFF, then Brave locks up. (Win10 white screen, app not responding.)

Configuration

brave-portable-win64-1.1.23-44, running in a Comdo sandbox. NOT set as default browser.

Win10 64 Home, 1903, Many components removed via NTLite. Lots of Services disabled.

  1. No cummulative updates.

brave-portable.log

Upgrade to the next generation of Brave browser (brave-core)

Some caveats to note before an upgrade to the next generation of Brave browser.

Passwords are not saved

Brave (as Chromium) stores passwords in such a way that they are encrypted in a way tied to current PC. While the passwords are not kept or left behind on the PC itself, they won't be retrievable when you move to a new PC.

Certificates not portable

Brave (as Chromium) has no certificate manager. It uses Windows certificates manager. So, any certificates you install through the Brave interface are stored on the current local machine and will not be portable.

Some settings and extensions are locked per machine

Brave (as Chromium) locks specific settings to a given PC. This behavior is by design by the Chromium team. If you would like this changed, please open an issue on the brave-core repository. A suggested workaround is to sign in to Brave Safe Storage to restore all settings and extensions but this is not available on the current release of Brave.

And as stipulated in this thread :

Brave reset my browser settings

Sometimes, programs that you install can change your Brave settings without you knowing. For your safety, the browser checks if your settings have been changed every time you launch Brave. If Brave notices that something’s not right in your settings, it will automatically go back to the original settings.

Settings that might automatically get reset

  • Default search engine
  • Homepage
  • Startup pages
  • Pinned tabs
  • Extensions

These issues are specific to Brave due to Chromium's design and not something we can work around without fixes to brave-core.

Import profile data from Muon

The current stable release (0.55) cannot handle migration of profile data from Muon but there is a work in progress. See brave/brave-core#729

Linked threads

Not Portable

Hi Max,

This one also writes to appData:
AppData\Local\BraveSoftware\Brave-Browser*

Again, anyway to set the path in the config?

Is it really portable?

After using it, I have found a Brave-Browser directory inside Appdata/Local folder. I would expect that a portable app does not write anything in the host calculator...

I have also found an HKCU\Software\BraveSoftware key in the register...

Extensions got broken

Behaviour

Steps to reproduce this issue

  1. Install some extension from the store into portable-brave (eg. uBlock Origin)
  2. Update your portable-brave to latest version
  3. Starting Brave on Another PC from USB.

Expected behaviour

Browser run as usual

Actual behaviour

All tabs is rendering with a "Aw, Snap!" message and you're notified that the extension crashed

Configuration

App release : 1.1.23-44

Operating system : Windows 10 Pro 64 bits

Winver screenshot :

Microsoft Windows [version 10.0.17763.914]

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:109 > --------
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:110 > Operating System: Windows 10.0.17763
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:111 > Starting Brave 1.1.23-44 (portapps 1.31.0)...
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:112 > Release date: 2019/12/24 17:02:03
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:113 > Publisher: CrazyMax (https://github.com/portapps/brave-portable)
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:114 > Root path: C:\Dev\_D_\Apps\brave-portable
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:118 > Loading main configuration...
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/config.go:57 > read config:
common:
  args:
   - --allow-file-access-from-files
  env: {}
  app_path: ""
app:
  cleanup: true

Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:123 > Decoding app configuration...
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:129 > Configuration:
common:
  args:
  - --allow-file-access-from-files
  env: {}
  app_path: ""
app:
  cleanup: true

Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:152 > Process: C:\Dev\_D_\Apps\brave-portable\app\brave.exe
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:153 > Args (config file): --allow-file-access-from-files
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:154 > Args (cmd line): 
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:155 > Args (hardcoded): --user-data-dir=C:\Dev\_D_\Apps\brave-portable\data --disable-brave-update --no-default-browser-check --disable-logging --disable-breakpad --disable-machine-id --disable-encryption-win
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:156 > Working dir: C:\Dev\_D_\Apps\brave-portable\app
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:157 > App path: C:\Dev\_D_\Apps\brave-portable\app
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:158 > Data path: C:\Dev\_D_\Apps\brave-portable\data
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:171 > Launching Brave...
Wed, 08 Jan 2020 10:57:28 CET INF C:/portapps_opt/gopath/pkg/mod/github.com/portapps/[email protected]/portapps.go:179 > Exec C:\Dev\_D_\Apps\brave-portable\app\brave.exe --allow-file-access-from-files --user-data-dir=C:\Dev\_D_\Apps\brave-portable\data --disable-brave-update --no-default-browser-check --disable-logging --disable-breakpad --disable-machine-id --disable-encryption-win
[19244:20484:0108/105730.771:ERROR:rewards_service_impl.cc(202)] Failed to read file: C:\Dev\_D_\Apps\brave-portable\data\Default\ledger_state
[19244:8328:0108/105731.864:ERROR:brave_referrals_service.cc(224)] Failed to parse referral headers response

add other stability channels

I wanted to try out synchronization but it is nowhere to be found in the latest portapps release. From my understanidng it is only available in the betas/nightly. Is it feasible to add a build with sync v2 ? thanks & gj

question: is the project still on?

I particularly like the project, I believe you are doing a spectacular job, however, I would like to know if the project is still functioning. I hope everything is fine with you and have a good day.

cheers!

Don't create shortcuts in Start Menu/Programs

Behaviour

Brave portable keeps creating a shortcut in Start Menu/Programs on every launch. The shortcut is then removed upon closing Brave portable. The shortcut is not removed if Brave portable has crashed or the process has been killed forcefully.

Steps to reproduce this issue

  1. Launch Brave portable.
  2. A shortcut to brave-portable.exe is created in Start Menu\Programs.
  3. Close Brave portable.
  4. The shortcut has been deleted.

or

  1. Launch Brave portable.
  2. A shortcut to brave-portable.exe is created in Start Menu\Programs.
  3. Kill brave-portable.exe with taskkill /im brave-portable.exe.
  4. Close Brave portable.
  5. The shortcut remains.

Expected behaviour

With all the respect for your work, I do not believe that a portable application should create such a shortcut at all. Portable applications, by definition, are likely to be launched from a USB device on different machines, and I would expect them not to place any files in the host OS, unless absolutely necessary.

Actual behaviour

The Start Menu shortcut is recreated again and again with no option to configure the behaviour, apart from removing the related code

brave-portable/main.go

Lines 46 to 73 in d6970ff

// Copy default shortcut
shortcutPath := path.Join(os.Getenv("APPDATA"), "Microsoft", "Windows", "Start Menu", "Programs", "Brave Portable.lnk")
defaultShortcut, err := assets.Asset("Brave.lnk")
if err != nil {
Log.Error().Err(err).Msg("Cannot load asset Brave.lnk")
}
err = ioutil.WriteFile(shortcutPath, defaultShortcut, 0644)
if err != nil {
Log.Error().Err(err).Msg("Cannot write default shortcut")
}
// Update default shortcut
err = shortcut.Create(shortcut.Shortcut{
ShortcutPath: shortcutPath,
TargetPath: app.Process,
Arguments: shortcut.Property{Clear: true},
Description: shortcut.Property{Value: "Brave Portable by Portapps"},
IconLocation: shortcut.Property{Value: app.Process},
WorkingDirectory: shortcut.Property{Value: app.AppPath},
})
if err != nil {
Log.Error().Err(err).Msg("Cannot create shortcut")
}
defer func() {
if err := os.Remove(shortcutPath); err != nil {
Log.Error().Err(err).Msg("Cannot remove shortcut")
}
}()

and recompiling Brave portable from source.

Configuration

App release / arch (ex. 1.0.0-2 win64) : 0.67.124-28 win64

Operating system (ex. Windows 10 Pro 64 bits) : Windows 7 Enterprise x64

Winver screenshot :

image

Logs

brave-portable.log

Default browser: Problem with profiles.

Hi!:
Thank you for your excellent work. I really like this browser and I needed the portable version.

However I have a problem. When I put Brave as a default browser and want to open a link from another program (suppose Thunderbird for emails) Brave opens another "empty" profile without access to my addons, tabs, etc. From "brave://version" I see that the Profile Path of both Brave browsers is different. And Windows is slowly filled with garbage, which I supposedly want to avoid using portable applications.
I want Brave to always open with my personalized profile and that everything is "self-contained" in your folder.

This I could solve in Firefox by accessing "about: profiles" and managing the profile that interested me. But in Brave/Chrome I found no way to modify this.

I was testing from the YAML file (https://portapps.io/doc/configuration/) but maybe because of my ignorance I had no positive results.
I do not think it is that complicated. Any idea how to solve this?

Thanks in advance!.

0.25.2-40 not fully portable

I am a fan of the .25 version, I do not like .55, not only for the look but mostly I need session tabs.
So, I would appreciate solving issues on .25 also.
TIA

Behaviour

0.25.2-40 Creates a brave directory under user/AppData/Roaming

Steps to reproduce this issue

  1. install
  2. make active some extensions
  3. look under Roaming

Expected behaviour

Full portable means all stuff is computer indepedent, so all should be packed together

Tell me what should happen

Actual behaviour

Tell me what happens instead

Configuration

App release / arch (ex. 1.0.0-2 win64) :
0.25.2-40

Operating system (ex. Windows 10 Pro 64 bits) :
win 10 64 pro
Winver screenshot :

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Join the log file brave-portable.log to this issue.

Windows defender complains from trojan horse

@crazy-max

As from today Windows Defender started to quarantine brave-portable.exe (w10@x64). Sad news...

bravetrojan

my brave-portable.exe (x64) SHA-256 is
8ED6CA07C7B5664865B608D583F5B7443EEC6ECC92AEBB51BC8C4019DA2C83AC

as per http://onlinemd5.com/

as per virustotal is mostly clean (same as downloaded x64 exe, one is signaling malware); can you recheck that your brave-portable.exe has same hash?

I trust is just a false positive, but it is sad news if Windows Defender has identified that file as a trojan. Can you review the code to see if you can identify the offending section and avoid that nuisance?

TIA

Feedback on releases

I will be providing feedback of my experiences with the releases, feedback on the portable and its installation, not feedback related to the brave-core itself.

The backlog... I have tried most of the portable releases @wx64 based on brave-core post portabilization patch. Most ok.

yml settings no applying?

Behaviour

Steps to reproduce this issue

  1. Edit brave-portable.yml to add disable_log: true under common
  2. App still create the sample.yml and the log folder and collect logs under logs folder

Expected behaviour

Upon deletion the log folder should not be recreated if the flag disable_log: true is set

Actual behaviour

sample.yml gets created every time the app is run even if its renamed to follow https://portapps.io/doc/configuration/

Configuration

App release / arch (ex. 1.0.0-2 win64) : 1.2.43 release 46

Operating system (ex. Windows 10 Pro 64 bits) : Windows 10 Pro 64 bits

Winver screenshot : Version 1809 OS Build 17763.1158

Logs

This is what i need to remove all together, its causing permission issues when i deploy an app that includes brave portable, the .log file under log folder cause the app not to open, i need to be able to open brave without generating logs

other releases?

@crazy-max
Looks that brave-core has stopped evolving x.62, with a mad-hurry releases of nighlys x.66 and devs x.65 and also betas x.64 in the last two weeks.

Would you know if they skipped x.63?
Could you make, if not to effort for you, a special release of portable using beta-x.64 or dev-x.65, just to play a bit?

TIA
CT

Move hardcoded flags to brave-portable.yml file, and allow to modify them

Behaviour

Brave portable is compiled with specific flags hardcoded.

brave-portable/main.go

Lines 35 to 44 in d6970ff

app.Args = []string{
"--user-data-dir=" + app.DataPath,
"--disable-brave-update",
"--no-default-browser-check",
"--allow-outdated-plugins",
"--disable-logging",
"--disable-breakpad",
"--disable-machine-id",
"--disable-encryption-win",
}

Because of that, the browser is always launched with these flags with no option to configure them by the user.

Steps to reproduce this issue

  1. Launch Brave portable.
  2. Brave portable is launched with 8 flags hardcoded, despite them not being listed in the brave-portable.yml file.

Expected behaviour

In my opinion, it would be beneficial to move these flags from the actual code to the brave-portable.yml file. This way it would be possible to freely modify them for one's own needs. Such an approach is used in chrlauncher, where all the switches are listed and read from an .ini file as follows.

ChromiumCommandLine=--user-data-dir=..\profile --no-default-browser-check --allow-outdated-plugins --disable-logging --disable-breakpad

Moving the flags to brave-portable.yml would make Brave portable more flexible and customisable, which I believe is a good thing and beneficial for the users.

Actual behaviour

The switches

--user-data-dir
--disable-brave-update
--no-default-browser-check
--allow-outdated-plugins
--disable-logging
--disable-breakpad
--disable-machine-id
--disable-encryption-win

are hardcoded in brave-portable.exe with no option to configure (or remove) them manually.

Configuration

App release / arch (ex. 1.0.0-2 win64) : 0.67.124-28 win64

Operating system (ex. Windows 10 Pro 64 bits) : Windows 7 Enterprise x64

Winver screenshot :

image

Logs

brave-portable.log

McAfee LiveSafe false positives

Hi Max,

love to be able to use Brave portable but I am running into false positives with McAfee LiveSafe.
When I use the installer I get the following
virus

And when I use the 7z archive I get:
virus2

I hope you can do something with this.

cheers
Nico

Add additional switches to reduce cache files creation

Behaviour

Chromium by default creates tons and tons of cache files. Not only do they take disk space, but also writing such a large number of files to weak flash memory (e.g. on typical USB flash drives, or SD cards) reduces its lifespan. In addition, it can also be detrimental for performance, as such a flash memory is often too slow to write a large number of small files fast enough, especially since Windows disables write cache for USB devices by default.

Steps to reproduce this issue

  1. Launch Brave portable.
  2. Browse the Internet for some time.
  3. Open the data\Default folder.
  4. Various cache folders (e.g. Code Cache, GPUCache, Media Cache) will be filled with files downloaded by the browser from the visited websites.

Expected behaviour

A portable application, by definition, is likely to be launched from a USB device (e.g. a flash drive, an SD card, etc.) whose lifespan is much shorter than standard HDDs or SSDs. For a portable application, I would expect it to take such an environment into account and write as few files as possible to prolong the flash memory lifespan.

I would suggest adding switches such as:

--aggressive-cache-discard
--disk-cache-size=1 (impossible to disable completely)
--media-cache-size=1 (impossible to disable completely)
--disable-gpu-program-cache
--disable-gpu-shader-disk-cache
--v8-cache-options=none (the worst one, responsible for the Code Cache folder which gets filled with tens of thousands of cached JavaScript files taking hundreds of MBs of disk space)

Following #25, I would suggest to have these switches added to brave-portable.yml instead of hardcoding them, so that the user would be able to modify them at will.

Actual behaviour

Brave portable creates as many cache files as any other Chromium based browser.

Configuration

App release / arch (ex. 1.0.0-2 win64) : 0.67.124-28 win64

Operating system (ex. Windows 10 Pro 64 bits) : Windows 7 Enterprise x64

Winver screenshot :

image

Logs

brave-portable.log

updating to 0.55 fails

Behaviour

tried to update from .22 to .55 and lost all configuration and information.
Had a backup ;-)

Steps to reproduce this issue

  1. Install 0.22
  2. pin some tabs, make some bookmarks
  3. update to 0.55 using exe

Expected behaviour

Tell me what should happen

Actual behaviour

Tell me what happens instead

Configuration

App release / arch (ex. 1.0.0-2 win64) :
win64
Operating system (ex. Windows 10 Pro 64 bits) :
W10P64 18xxx
Winver screenshot :

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Join the log file brave-portable.log to this issue.

Can't run setup portable file

Behaviour

Setup portable file

Steps to reproduce this issue

  1. Open setup portable file "brave-portable-win64.exe" (already move setup file into root partition folder, permisson is ok)
  2. Window errors appearance

Expected behaviour


Actual behaviour

Setup can't open

Configuration

App release / arch (ex. 1.0.0-2 win64) :
0.66.100-25 portable / win 64
Operating system (ex. Windows 10 Pro 64 bits) :
Window 7 Pro 64 bits

Winver screenshot :

image

Screenshots

image

Logs

brave-portable.log

Please update

The latest brave version is 1.23.71, so please update.
Thank you.

Cookies, passwords and settings not saved across computers

Behaviour

Steps to reproduce this issue

1.Log in to any site.
2.Starting Brave on Another PC from USB.

Expected behaviour

Be logged in.

Actual behaviour

Not logged in.

Configuration

**App release ** : update from 0.68.142-34 to 0.69.132-35

**Operating system ** :Windows 10 home 64bit ver.1903


I think the cookies are probably initialized.

It is the same symptom even if I update to 0.69.135-36.

However, even if I use the 0.68.142-34 version, the same symptoms are occurring now, so it may be because of my environment.

It used to work fine.

Thanks.

Portable Brave Update Issue

Everytime if there is new update, we have to download it separately and overwrite on the existing locations. Can you do something about it like portableapps are doing, they have a software which updates the instances on their particular locations. This will not only be helpful for brave but also for all other portapps you provide as well.
It will take the portapps to next level.

Some suggestions for .61x installation/update

Seems there will be a long update road until brave-core 1.0RC... Some increase of efficiency would be welcomed:

A) when launched, it selects a default directory for installation; would like that proposed installation in the directory where the .exe is located and that /brave-portable is not appended authomatically.

B) Would like to launch a silent update, to update previous version located in the directory where install exe is located. .exe could detect that there is already a previous version installed in that directory and just question if update or not; after yes, no more questions...

C) I ususally delete locales that I do not use. Update should not create those back...

I notice to quirks that probably are related to base sw:
1- tab content is not refreshed after browser execution. Refresh needs to be pressed
2. there is no way to limit number of tabs as there was in previous non core versions.
3. when there are too many open tabs, last ones are not shown...

TIA
CT

Issue with 0.62.37-12

@crazy-max

When updating from 27-11 (do not know other situations)

First run after update ends bad (flash and exit). A second run is needed to get browser running and then tabs that were open before update are lost; besides, history cannot be opened to recover not opened tabs.

Thanks!
CT

Brave Rewards not working (no ads)

One of the main benefits of Brave browser is to earn BAT with Brave Rewards, but it does not work with the portable version.

Wanted ads are shown as notifications, but I still got none in the last few days. Users with the non-portable App had the same issue when Brave did no appear in the Windows Action Center, when it was not listed under notifications

Problem was solved for them when they triggerd a notification manuelly e.g. @ https://www.bennish.net/web-notifications.html, after that Brave appeard in the list of apps with notifications. The portable version does not appear in the list. Another way was to force notifications by going to brave://flags/ and set #enable-native-notifications to enabled. But Brave is still not shown in the notifications list of windows and no ads are shown.

In your Modfications list you write: A shortcut is created at launch to allow native notifications and removed when Brave™ is closed
Can not confirm that, Bug? That is way no ads are shown?

Tested 1.5.115-51 and 1.4.96-50 Win64

Regards

Command Failed

Behaviour

Steps to reproduce this issue

1.Download 7z brave-portable-win64-1.20.110-71
2. click brave-portable
3. get error

Expected behaviour

opens app

Actual behaviour

"Command failed"

Configuration

App release / arch (ex. 1.0.0-2 win64) : brave-portable-win64-1.20.110-71

Operating system (ex. Windows 10 Pro 64 bits) : win 10 x64 2004

Winver screenshot :
image

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Screenshots

image

If applicable, add screenshots to help explain your problem.

Logs

Join the log file log\[appname]-portable.log to this issue.

New flags

Can you add a feature that highlights flags that are new to the latest version?

Here's the script I use currently (in the console of the flags page):

//88.1.20.110

////////// REPLACE 'old' with new's version's (`copy(old)` in the console), after the code is run ////////////////////////////

////////// PASTE everything below here into the console ////////////////////////////

let old=[
  "#enable-webrtc-remote-event-log",
  "#enable-webrtc-hide-local-ips-with-mdns",
  "#enable-login-detection",
  "#enable-preconnect-to-search",
  "#bypass-app-banner-engagement-checks",
  "#load-media-router-component-extension",
  "#cast-media-route-provider",
  "#enable-tls13-early-data",
  "#enable-force-dark",
  "#omnibox-local-zero-suggest-frecency-ranking",
  "#omnibox-suggestion-button-row",
  "#omnibox-pedal-suggestions",
  "#omnibox-drive-suggestions",
  "#block-insecure-private-network-requests",
  "#read-later",
  "#scrollable-tabstrip",
  "#enable-pixel-canvas-recording",
  "#enable-parallel-downloading",
  "#enable-storage-pressure-event",
  "#detect-target-embedding-lookalikes",
  "#enable-accessibility-live-captions",
  "#enable-sxg-prefetch-cache-for-navigations",
  "#enable-autofill-account-wallet-storage",
  "#happiness-tracking-surveys-for-desktop-devtools-issues-cookies-same-site",
  "#happiness-tracking-surveys-for-desktop-demo",
  "#happiness-tracking-surveys-for-desktop-migration",
  "#happiness-tracking-surveys-for-desktop-settings",
  "#happiness-tracking-surveys-for-desktop-settings-privacy",
  "#destroy-profile-on-browser-close",
  "#remote-copy-receiver",
  "#remote-copy-image-notification",
  "#remote-copy-persistent-notification",
  "#remote-copy-progress-notification",
  "#file-handling-api",
  "#enterprise-realtime-extension-request",
  "#form-controls-dark-mode",
  "#color-picker-eye-dropper",
  "#cookies-page-redesign",
  "#global-media-controls-modern-ui",
  "#global-media-controls-picture-in-picture",
  "#global-media-controls-seamless-transfer",
  "#global-media-controls-overlay-controls",
  "#win-use-native-spellchecker",
  "#turn-off-streaming-media-caching-on-battery",
  "#turn-off-streaming-media-caching-always",
  "#back-forward-cache",
  "#enable-heavy-ad-intervention",
  "#enable-ftp",
  "#raw-clipboard",
  "#enable-user-data-snapshot",
  "#media-history",
  "#permission-chip",
  "#enable-media-feeds",
  "#enable-media-feeds-background-fetch",
  "#conversion-measurement-api",
  "#safety-check-chrome-cleaner-child",
  "#chrome-cleanup-scan-completed-notification",
  "#enable-lite-video",
  "#enable-incognito-shortcut-on-desktop",
  "#enable-tab-search",
  "#window-naming",
  "#enable-browsing-data-lifetime-manager",
  "#privacy-advisor",
  "#sct-auditing",
  "#detect-form-submission-on-form-clear",
  "#shutdown-support-for-keepalive",
  "#permission-predictions",
  "#brave-ntp-branded-wallpaper",
  "#brave-ntp-branded-wallpaper-demo",
  "#brave-speedreader",
  "#brave-sync-v2",
  "#brave-super-referral",
  "#brave-ephemeral-storage",
  "#temporary-unexpire-flags-m86",
  "#temporary-unexpire-flags-m87",
  "#ignore-gpu-blocklist",
  "#disable-accelerated-2d-canvas",
  "#overlay-strategies",
  "#tint-composited-content",
  "#show-overdraw-feedback",
  "#ui-disable-partial-swap",
  "#enable-webrtc-capture-multi-channel-audio-processing",
  "#enable-reader-mode",
  "#enable-webrtc-hybrid-agc",
  "#enable-webrtc-use-min-max-vea-dimensions",
  "#extensions-on-chrome-urls",
  "#show-autofill-type-predictions",
  "#smooth-scrolling",
  "#sms-receiver-cross-device",
  "#enable-quic",
  "#disable-javascript-harmony-shipping",
  "#enable-javascript-harmony",
  "#enable-experimental-webassembly-features",
  "#enable-webassembly-baseline",
  "#enable-webassembly-lazy-compilation",
  "#enable-webassembly-simd",
  "#enable-webassembly-threads",
  "#enable-webassembly-tiering",
  "#enable-future-v8-vm-features",
  "#enable-gpu-rasterization",
  "#enable-experimental-web-platform-features",
  "#top-chrome-touch-ui",
  "#webui-tab-strip",
  "#disable-accelerated-video-decode",
  "#disable-accelerated-video-encode",
  "#debug-packed-apps",
  "#username-first-flow",
  "#enable-show-autofill-signatures",
  "#wallet-service-use-sandbox",
  "#enable-web-bluetooth-new-permissions-backend",
  "#overscroll-history-navigation",
  "#pull-to-refresh",
  "#enable-touch-drag-drop",
  "#enable-suggestions-with-substring-match",
  "#device-discovery-notifications",
  "#force-enable-privet-printing",
  "#enable-webgl-draft-extensions",
  "#enable-zero-copy",
  "#enable-vulkan",
  "#override-language-prefs-for-href-translate",
  "#override-site-prefs-for-href-translate",
  "#enable-native-notifications",
  "#in-product-help-demo-mode-choice",
  "#disable-threaded-scrolling",
  "#isolate-origins",
  "#site-isolation-trial-opt-out",
  "#allow-previews",
  "#ignore-previews-blocklist",
  "#enable-data-reduction-proxy-server-experiment",
  "#enable-noscript-previews",
  "#enable-resource-loading-hints",
  "#enable-previews-coin-flip",
  "#enable-google-srp-isolated-prerender-probing",
  "#enable-google-srp-isolated-prerenders",
  "#enable-google-srp-isolated-prerender-nsp",
  "#allow-insecure-localhost",
  "#enable-desktop-pwas-local-updating",
  "#enable-desktop-pwas-app-icon-shortcuts-menu",
  "#enable-desktop-pwas-tab-strip",
  "#enable-desktop-pwas-tab-strip-link-capturing",
  "#enable-desktop-pwas-migration-user-display-mode-clean-up",
  "#enable-desktop-pwas-run-on-os-login",
  "#use-sync-sandbox",
  "#media-router-cast-allow-all-ips",
  "#global-media-controls-cast-start-stop",
  "#allow-all-sites-to-initiate-mirroring",
  "#enable-migrate-default-chrome-app-to-web-apps-gsuite",
  "#enable-migrate-default-chrome-app-to-web-apps-non-gsuite",
  "#web-share",
  "#webxr-incubations",
  "#webxr-multi-gpu",
  "#webxr-runtime",
  "#system-keyboard-lock",
  "#disallow-doc-written-script-loads",
  "#enable-autofill-credit-card-upload",
  "#force-ui-direction",
  "#force-text-direction",
  "#PasswordImport",
  "#enable-experimental-accessibility-language-detection",
  "#enable-experimental-accessibility-language-detection-dynamic",
  "#enable-experimental-fling-animation",
  "#enable-web-payments-experimental-features",
  "#enable-web-payments-minimal-ui",
  "#enable-debug-for-store-billing",
  "#enable-debug-for-secure-payment-confirmation",
  "#fill-on-account-select",
  "#enable-generic-sensor-extra-classes",
  "#enable-autofill-credit-card-ablation-experiment",
  "#gdi-text-printing",
  "#new-usb-backend",
  "#omnibox-clobber-triggers-contextual-web-zero-suggest",
  "#omnibox-on-device-head-suggestions-incognito",
  "#omnibox-on-device-head-suggestions-non-incognito",
  "#omnibox-on-focus-suggestions-contextual-web",
  "#omnibox-trending-zero-prefix-suggestions-on-ntp",
  "#omnibox-experimental-keyword-mode",
  "#omnibox-short-bookmark-suggestions",
  "#omnibox-tab-switch-suggestions",
  "#omnibox-keyword-search-button",
  "#omnibox-refined-focus-state",
  "#omnibox-rich-autocompletion",
  "#omnibox-rich-autocompletion-min-char",
  "#omnibox-rich-autocompletion-show-additional-text",
  "#omnibox-rich-autocompletion-split",
  "#omnibox-rich-autocompletion-promising",
  "#omnibox-bookmark-paths",
  "#force-color-profile",
  "#force-effective-connection-type",
  "#forced-colors",
  "#memlog",
  "#memlog-sampling-rate",
  "#memlog-stack-mode",
  "#omnibox-ui-sometimes-elide-to-registrable-domain",
  "#omnibox-ui-reveal-steady-state-url-path-query-and-ref-on-hover",
  "#omnibox-ui-hide-steady-state-url-path-query-and-ref-on-interaction",
  "#omnibox-max-zero-suggest-matches",
  "#omnibox-ui-max-autocomplete-matches",
  "#omnibox-max-url-matches",
  "#omnibox-dynamic-max-autocomplete",
  "#omnibox-bubble-url-suggestions",
  "#omnibox-webui-omnibox-popup",
  "#force-empty-CORB-and-CORS-allowlist",
  "#cross-origin-opener-policy-reporting",
  "#cross-origin-opener-policy-access-reporting",
  "#cross-origin-isolated",
  "#delay-async-script-execution",
  "#delay-competing-low-priority-requests",
  "#intensive-wake-up-throttling",
  "#tab-groups-auto-create",
  "#tab-groups-collapse",
  "#tab-groups-collapse-freezing",
  "#scrollable-tabstrip-buttons",
  "#side-panel",
  "#promo-browser-commands",
  "#ntp-iframe-one-google-bar",
  "#ntp-one-google-bar-modal-overlays",
  "#ntp-repeatable-queries",
  "#ntp-webui",
  "#ntp-modules",
  "#ntp-recipe-tasks-module",
  "#ntp-shopping-tasks-module",
  "#enable-pointer-lock-options",
  "#enable-new-download-backend",
  "#tab-hover-cards",
  "#tab-hover-card-images",
  "#installed-apps-in-cbd",
  "#enable-network-logging-to-file",
  "#enable-web-authentication-cable-v2-support",
  "#force-preferred-interval-for-video",
  "#accessible-pdf-form",
  "#pdf-form-save",
  "#pdf-honor-js-content-settings",
  "#pdf-viewer-update",
  "#print-with-reduced-rasterization",
  "#use-xps-for-printing",
  "#use-xps-for-printing-from-pdf",
  "#enable-windows-gaming-input-data-fetcher",
  "#enable-lazy-image-loading",
  "#enable-lazy-frame-loading",
  "#autofill-enable-toolbar-status-chip",
  "#unsafely-treat-insecure-origin-as-secure",
  "#treat-unsafe-downloads-as-active-content",
  "#allow-sxg-certs-without-extension",
  "#enable-sxg-subresource-prefetching",
  "#compositor-threaded-scrollbar-scrolling",
  "#calculate-native-win-occlusion",
  "#use-multilogin-endpoint",
  "#enable-new-profile-picker",
  "#enable-profiles-ui-revamp",
  "#use-angle",
  "#click-to-call-ui",
  "#restrict-gamepad-access",
  "#shared-clipboard-ui",
  "#sharing-qr-code-generator",
  "#enable-gpu-service-logging",
  "#hardware-media-key-handling",
  "#d3d11-video-decoder",
  "#autofill-use-improved-label-disambiguation",
  "#installable-ink-drop",
  "#enable-md-rounded-corners-on-dialogs",
  "#enable-new-badge-on-menu-items",
  "#strict-origin-isolation",
  "#enable-skia-renderer",
  "#enable-portals",
  "#enable-portals-cross-origin",
  "#enable-autofill-credit-card-authentication",
  "#storage-access-api",
  "#same-site-by-default-cookies",
  "#enable-removing-all-third-party-cookies",
  "#cookies-without-same-site-must-be-secure",
  "#enable-unsafe-fast-js-calls",
  "#allow-sync-xhr-in-page-dismissal",
  "#enable-sync-requires-policies-loaded",
  "#form-controls-refresh",
  "#audio-worklet-realtime-thread",
  "#safe-browsing-enhanced-protection-message-in-interstitials",
  "#cookie-deprecation-messages",
  "#enable-autofill-credit-card-upload-feedback",
  "#font-access",
  "#font-access-chooser",
  "#global-media-controls-for-cast",
  "#safety-tips",
  "#enable-defer-all-script",
  "#enable-defer-all-script-without-optimization-hints",
  "#decode-jpeg-images-to-yuv",
  "#decode-webp-images-to-yuv",
  "#dns-httpssvc",
  "#web-bundles",
  "#enable-autofill-upi-vpa",
  "#quiet-notification-prompts",
  "#abusive-notification-permission-revocation",
  "#passwords-account-storage",
  "#passwords-account-storage-iph",
  "#autofill-always-return-cloud-tokenized-card",
  "#impulse-scroll-animations",
  "#percent-based-scrolling",
  "#scroll-unification",
  "#elastic-overscroll-win",
  "#enable-de-jelly",
  "#heavy-ad-privacy-mitigations",
  "#autofill-enable-virtual-card",
  "#freeze-user-agent",
  "#run-video-capture-service-in-browser",
  "#legacy-tls-enforced",
  "#enable-media-foundation-video-capture",
  "#color-provider-redirection",
  "#trust-tokens",
  "#copy-link-to-text",
  "#app-cache",
  "#enable-autofill-cache-server-card-info",
  "#autofill-enable-sticky-payments-bubble",
  "#enable-experimental-cookie-features",
  "#autofill-enable-google-issued-card",
  "#dice-web-signin-interception",
  "#new-canvas-2d-api",
  "#enable-translate-sub-frames",
  "#autofill-enable-card-nickname-management",
  "#conversion-measurement-debug-mode",
  "#client-storage-access-context-auditing",
  "#autofill-enable-card-nickname-upstream",
  "#autofill-enable-offers-in-downstream",
  "#schemeful-same-site",
  "#lite-video-default-downlink-bandwidth-kbps",
  "#lite-video-force-override-decision",
  "#edit-passwords-in-settings",
  "#mixed-forms-disable-autofill",
  "#mixed-forms-interstitial",
  "#h264-decoder-is-buffer-complete-frame",
  "#content-settings-redesign",
  "#enable-avif",
  "#passwords-weakness-check",
  "#well-known-change-password",
  "#sync-autofill-wallet-offer-data",
  "#enable-oop-print-drivers",
  "#use-serial-bus-enumerator",
  "#mute-notifications-during-screen-share",
  "#enable-ephemeral-guest-profiles-on-desktop",
  "#desktop-in-product-help-snooze",
  "#kaleidoscope-ntp-module",
  "#insert-key-toggle-mode",
  "#use-first-party-set",
  "#check-offline-capability",
  "#use-dev-updater-url",
  "#brave-adblock-cosmetic-filtering",
  "#brave-ipfs",
  "#disable-webrtc-hw-decoding",
  "#disable-webrtc-hw-encoding",
  "#global-media-controls-for-chromeos",
  "#notification-scheduler-debug-options",
  "#double-buffer-compositing",
  "#enable-bluetooth-spp-in-serial-api"
];

let lks=[...document.getElementsByTagName('A')].filter(function (lk) {
   return lk.innerText.startsWith('#');
});

let old1=lks;

let ttl=[];
let nde=[];
for(let k=0; k<lks.length; k++){
ttl.push('#'+lks[k].parentElement.parentElement.parentElement.id);
nde.push(lks[k].parentElement.parentElement.parentElement);
}

for(let k=0; k<ttl.length; k++){
if(old.includes(ttl[k])){
nde[k].style.visibility="hidden";
}
}

//Get current '#' flag names

old=[];

for(let k=0; k<old1.length; k++){
old.push('#'+old1[k].parentElement.parentElement.parentElement.id);
}

copy(old);

Brave portable link gets deleted from Windows start menu

Behaviour

Brave start menu link is created on start but then deleted when the app exits.

Steps to reproduce this issue

  1. Start Brave portable with this app.
  2. Open Windows start menu: Brave portable link appears in the menu.
  3. Exit Brave.
  4. Open Windows start menu: Brave portable link disappeared.

Expected behaviour

Tell me what should happen

Brave portable start menu link persists so it can be used to launch Brave again.

Actual behaviour

Tell me what happens instead

Brave link deleted from Windows start menu.

Question: is brave also forcing logging to google?

Behaviour

As explained here.
https://techcrunch.com/2018/09/26/google-to-give-chrome-users-an-opt-out-to-forced-login-after-privacy-backlash/?guccounter=1

Steps to reproduce this issue

Expected behaviour

Tell me what should happen

Actual behaviour

Tell me what happens instead

Configuration

App release / arch (ex. 1.0.0-2 win64) :

Operating system (ex. Windows 10 Pro 64 bits) :

Winver screenshot :

Open a command prompt and type winver then take / save the screenshot of the window and drag the image file in this issue. For example: http://bit.ly/2vA5sxR

Screenshots

If applicable, add screenshots to help explain your problem.

Logs

Join the log file brave-portable.log to this issue.

Brave crash

Hello,
both Brave 0.25 x32 or x64 builds fail to start on Win10Pro on a network drive:
NFO : 2018/11/07 13:54:40.121244 main.go:51: --------
INFO : 2018/11/07 13:54:40.198243 main.go:52: Starting Brave...
INFO : 2018/11/07 13:54:40.198243 main.go:53: Current path: M:\portapps\brave-portable
INFO : 2018/11/07 13:54:40.199244 sys.go:190: Create folder M:\portapps\brave-portable\data...
INFO : 2018/11/07 13:54:40.205246 electron.go:10: Lookup app folder in: M:\portapps\brave-portable\app
INFO : 2018/11/07 13:54:40.208244 electron.go:14: Electron app folder found: app-0.25.2
INFO : 2018/11/07 13:54:40.209247 exec.go:29: Process: M:\portapps\brave-portable\app\Brave.exe
INFO : 2018/11/07 13:54:40.210247 exec.go:30: Args:
INFO : 2018/11/07 13:54:40.210247 exec.go:31: Working dir: M:\portapps\brave-portable\app\app-0.25.2
INFO : 2018/11/07 13:54:40.211248 exec.go:32: Data path: M:\portapps\brave-portable\data
INFO : 2018/11/07 13:54:40.212247 exec.go:34: Launch Brave...
INFO : 2018/11/07 13:54:40.212247 exec.go:41: Exec M:\portapps\brave-portable\app\Brave.exe
[10132:17088:1107/135442.851:ERROR:browser_gpu_channel_host_factory.cc(132)] Failed to launch GPU process.
Crash reporting enabled
[10132:17088:1107/135451.550:ERROR:browser_gpu_channel_host_factory.cc(132)] Failed to launch GPU process.
Window crashed. Reloading...
[10132:21848:1107/135451.582:ERROR:gpu_process_transport_factory.cc(1007)] Lost UI shared context.
Window crashed. Reloading...
Window crashed. Reloading...
Window crashed. Reloading...
Window crashed. Reloading...
Window crashed. Reloading...
Window crashed. Reloading...
(node:10132) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 notification-response listeners added. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 notification-response listeners added. Use emitter.setMaxListeners() to increase limit
at _addListener (events.js:262:19)
at EventEmitter.addListener (events.js:279:10)
at WebContents.win.webContents.on (M:\portapps\brave-portable\app\app-0.25.2\resources\app.asar\app\browser\windows.js:350:19)
at emitOne (events.js:96:13)
at WebContents.emit (events.js:191:7)
Window crashed. Reloading...
Window crashed. Reloading...

hogging CPU until I kill it.
Fresh install !

brave-portable.exe is getting flagged as trojan/virus (again)

Both McAfee and Windows Defender flag the latest couple of releases as Trojan:Win32/Detplock (Windows Defender) and an unknow trojan Aurora (McAfee).

I'm using brave-portable-win64-1.2.43-46.7z as a test case.
I saw that this issues has been popping with the wrapper in the past, so I guess it's a false positive (hopefully).

See Virustotal results here, yesterday it was only 2 engines:
https://www.virustotal.com/gui/file/cd368f482dc2eb4d99e698a2731069c8c388cdcf90b79660b9986121d251e0c3/detection

Portability question

@crazy-max

While we wait for the patch to brave-core, and that they deploy the sessions feature, I kept using 0.25.

I have a portability issue. It happens at least in 0.25.302-44 .

I opened in a session tab a gmail session (log in) and closed the browser. Configured to NOT deleting anything and re-opening same taps as when closed.
Reopening the browser works perfect. Gmail session kept.

If I zip all the folder containing all of the portable browser, unzip open it in another computer, and open the browser, session information is lost. Perhaps it is gmail that detects the change? In any case this makes the experience not fully portable. Is there any solution? I understand that working in a dead release has no much interest... but I suspect that session control will take its time... and it is essential to have several open sessions in parallel.

On another record... it is possible to use two brave portables at the same time without interference one to the other?

Thanks in advance,
CT.

app_path relative paths do not work.

trying to set relative path to binaries directory like f.e. "app1" or f.e. "..\app", but it do not work. It feature need for multple instances of brave with one binaries source.
Another solution is pass config file into run command f.e.:
brave-portable.exe -myconfig1.yml
brave-portable.exe -myconfig2.yml
last option will be better, i can just change user data directory

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.