poteto / ember-deep-set

Deeply set values on an Ember Object or POJO

ember-deep-set's Issues

Promise support

Explain reason to use over Ember.set

It isn't immediately obvious from the README why someone would want to use ember-deep-set over Ember.set.

Maybe add some rationale about why folks should care?

👋 Please provide a changelog

Hi @poteto 👋

It would be useful to get the list of changes and bugfixes between versions, with migrations notes or recommendations if any. For now we have to search in the code or the Git history for API changes, and it can take some time when you have a lot of dependencies to update.

Please publish a GitHub release for the lastest versions (0.2.0, 0.1.4) with some explanations like about what changed and the recommendations to migrate and/or provide a CHANGELOG.md file.

See for example https://keepachangelog.com/en/1.0.0/

Thank you. ❤️

warnings issued by outdated version of ember-cli-babel

ember-cli-babel warnings in ember build are occurring like so:

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.4 located: /Users/0xadada/mirai-audio/mir/node_modules/ember-i18n-changeset-validations/node_modules/ember-deep-set/node_modules/ember-cli-babel

upgrading to a new version of ember-cli-babel will fix this.

deepSet where path leading up to key contains non-objects

Hey @poteto, sorry to bother you –

I'm running into this issue where I want to deepSet a key, but the path leading up to that key contains non-objects. Here's an example:

let o = { foo: 'bar' };
deepSet(o, 'foo.bar.baz', 'something'); // will currently error

Lodash's _.set implementation will overwrite the 'bar' string, and I'm thinking we could follow that behavior.

It's easy for me to work around this in ember-changeset (see here), but would you like to add this behavior to ember-deep-set as well? If not, it's no big deal.