ppfeufer / aa-fleetpings Goto Github PK

When creating pre pings with the pre ping option selected the title of the ping is misleading indicating also that the flee is already up. Reformatting this phrase or removing it will reduce confusions between pre pings and actual fleet pings

Hi,

I have setup a few fleet types for our fleet ping but it seems that they are now gone in the Admin panel.
Any idea on how we could fix this?

... so the junior/traning FC can't ping fur Supers and Titans for example

i have had a few corp mates annoying me with this and they want to add a feature where they can select "Mining Fleet" As an option for the Fleet Type selection. is it possible you can add this simple humble request for me so i can shut up my corp mates ? :) i told them to just edit the text themselfs before they paste it but nopp, too hard for them to do -.-

Double quotes in fields cause pings not no pass to discord. Should sanitize all fields and remove weird and possible harmful characters.

Noticed when tried to add ingame channel name in additional details in double quotes.

Context

In which context would you expect your suggested feature to be useful?
Quickly responding to situations without having to prefill all the info, such as ess defense, quick response fleet to a coalition fleet, etc, the templates would ideally be pre-configured by the individual auth owners

Describe the feature you have in mind

A clear and concise description of what you want to happen.
When you first go into the fleet pings module, there would be buttons that would either auto-post or prefill the form for you depending on pre determined values

Additional context

Add any other context or screenshots/mockups about the feature request here.

Checkbox to create SRP link when SRP is active for a fleet and formup time is set to "NOW"

No Permission Check for SRP Link Checkbox.

Hello,

juste a little update for your plugin , if it's possible can you add a duration time on the plugin ?

thx

Ability to select multiple ping targets in the ping to ping multiple groups with one message. Would be helpful in an area where SIGs are used and fleet is relevant to both. Maybe also add the ability to select multiple ping channels while you are on it.

Context

Add the creation of ESI FATLinks through allianceauth-afat module when creating a ping.

Describe the feature you have in mind

Add a checkbox or button (similar to SRP checkbox) to allow auto-creation of ESI Fatlinks from a formatted ping.
Fleet Name & Fleet Type are already populated within both modules.
Obviously the FC Name would need to be activated from the ESI Character Select screen.
When the check box for ESI FATLink is checked, after a user has clicked "Create Ping", open a new browser tab of the ESI Character Select page.
The character selected on that screen would dictate the FC the FATLink is under (not the FC name in Fleet Pings).

Since each FATLink uses a unique Callback key, the callback would need to be processed locally within the Fleet Pings module, unless there was some way to to have AFAT do the processing of the callback creation?
https://[URL].com/fleet-tracker/fatlink/create/esi-fatlink/callback/[CALLBACKKEY]/

Thanks in advance for looking into this feature request!

We are trying to keep the amount of pings to minimum on our discord and would prefer to have a no ping target option as well on the default options. This would allow us to send pre pings without pings :)

Also the ability to select the default option for ping target and ping channel would be awesome or ability to disable format ping for me option as we have no use for this

Edit: And yes for anyone who wants to do this until and if this is implemented you can always do these changes locally on the template files until that

There is an condition check missing from the preping option to create optimer. We do not have the optimer plugin active so it is a bit misleading. A simple check to fix this :)

Would be nice to be able to clear up the our Discord server. Have the ability to be able to DM Fleet pings to a selected states in AA so that members can decide to mute or not

Context

Currently the app only supports pinging targets that are groups. It does not support custom discord roleIDs or states (which are also auto synced as groups to discord)

Describe the feature you have in mind

In the ping targets configuration, you should have the option to see states as a choice of roles to pick from, as well as potentially a way to have a custom discord roleID you would like pinged.

Additional context

My main group of members use the state "Corp Member" (renamed from member) as all their base roles throughout 3rd party tools. (Discord, wikijs, etc)

The app however only currently lets me select from groups themselves, even though states are essentially treated as groups by every other external 3rd party app such as discord.

Rather then having a link to the timezone conversion page (or just dealing with EVE time conversions which some people seem to have trouble with) using the Discord timestamp conversion would show the time in the viewers current timezone.

Not sure if it can be used in embeds. But entering <t:1649212436:F> in Discord for myself returns "Wednesday, 6 April 2022 10:33"
The relative flag can also be used to return "in 32 minutes" <t:1649215376:R> and updates as time goes on (See https://hammertime.djdavid98.art/ for available formats).

I'm envisioning the pings to be updated to show:

Formup EVE Time: 2022-04-12 10:00 ( <t:1649757600:R> ) - relative timestamp (in 6 days)
Formup Local Time: <t:1649757600:F> - Full timestamp of Tuesday, 12 April 2022 18:00 )

... so the junior/traning FC can't ping for CTA with max capital support for example

Context

In which context would you expect your suggested feature to be useful?

Seeing the relative time is quite nice, esp when you expect a fleet later this afternoon but you've missed that the date is for tomorrow (based on real events).

Describe the feature you have in mind

A clear and concise description of what you want to happen.

When generating the ping text, just append the relative time to the end of the local time string.

**Formup (Local Time):** <t:1710532800:F> <t:1710532800:R>

Additional context

Add any other context or screenshots/mockups about the feature request here.

1st has a space between, 2nd doesn't.

Bug Description

When trying to use < or > in the Fleet comms, Doctrine, or Formup Location fields (tested FC name, Fleet name, and Additional information fields and they don't exhibit this behavior), it toggles into a weird encoding loop.
Test text> dje

Steps to Reproduce

Steps to reproduce the behavior:

1. Click into one of the affected fields.
2. Press Shift+. to insert a >
3. Watch as each key press (including releasing . and Shift are converted into >)

Expected behavior

>

Screenshots

If applicable, add screenshots to help explain your problem.

Please complete the following information:

• App Version: (will get from site host)
• Alliance Auth Version: (will get from site host)
• Browser and Version: Chrome 123.0.6312.58

Additional context

Oh whoa it does it for ' as well.

The only way to escape this mode is to triple-click left-mouse until you've highlighted all text, then backspace to delete.

Bug Description

After the 2.22.1 update fixing the dropdowns, the fields that are supposed to be selectable dropdowns are instead acting as text box search fields. When selecting the field, nothing happens until text is typed in to bring up the list of available selections from the admin pages.

Steps to Reproduce

Steps to reproduce the behavior:

1. Start creating fleet ping
2. Try to drop down and select an option for Formup Location, Fleet Comms or Doctrine.
3. Selections do not show up until text is input into the field

Expected behavior

Would be great to have similar functionality to previous versions that had selectable options regardless if text was typed in the field.

Screenshots

Please complete the following information:

• App Version: 2.22.3
• Alliance Auth Version: 3.4.0
• Browser and Version: Chrome 114.0.5735.110 64-bit

While reviewing the fix for the Discord migration bug I noticed that this app does not check for installed apps correctly. Directly accessing INSTALLED_APPS is strongly discouraged. To ensure that this fix works reliably Django's apps API should be used instead.

From the official docs here:

Your code should never access INSTALLED_APPS directly. Use django.apps.apps instead.

Bug Description

When using a custom ping target, the @group doesn't actually get auto linked to create the ping.

Steps to Reproduce

Steps to reproduce the behavior:

1. Create custom ping target
2. Go to Fleet pings app
3. Design a fleet ping and add your custom ping group to the fleet notification
4. Ping goes out normally except the @ target isn't auto linked.
   Our last known good fleet ping was on the 18th.

Expected behavior

When a ping goes out using the ping group, it auto links the group properly.

Screenshots

Please complete the following information:

• App Version: 2.13.1
• Alliance Auth Version: 2.11.2
• Browser and Version: Brave V1.37.116

Additional context

If I copy and paste from the "Formatted Ping Text" into the channel it works properly.

Bug Description

Updating from 2.4.4 to 2.5 removes the additional ping targets from the dropdown list.

Add a setting that would change the frontend drop down to fetch from fittings plugin without having to create new doctrines in auth with this plugin.