practical-python-org / zorakbot Goto Github PK

Seems when a message is deleted, there is a validation error writing to the DB

Has everything to do with adding ID of RSS entry to Mongo, and reading that ID from Mongo.

Cogs need to be cleaned up and larger cogs need to be split into smaller parts

TOML, .py, .pyw, .txt, .csv ,.xslx are all fine. but block .exe files and such

Doesn't delete after send
(easy fix)

We create new instances of bot all over the place. This should not be the case, as we already have an instance of bot in the main, and we should use this everywhere.

We experience an error when attempting to update the running prod contianers.

When rebuilding the zorak_bot container from a new image, the container does not have permissions to read from the existing mongo container.

[Some-USERr@###-###-##-##]$ docker-compose -f dc-prod.yaml up -d Building zorak error checking context: 'no permission to read from '/srv/prod/db/WiredTiger.turtle''. ERROR: Service 'zorak' failed to build : Build failed

Currently the fix is to open the permissions on the db folder, which allows all users access, but I dont like this.

Possible solution is to run the containers both as the same user from the dockerfile

Needs a good cleaning

The "about me" and the help command are out of date + need updating. We should move this info into a TOML to pave the way for it to be added to a database.

          is this behaviour intended? even if a user is an admin, if any of the roles they have are not admin values it would still send a message right? meaning every user that has a non-admin role would have this logging occur

if you wanted to NOT show admins, you should instead do a check like
is_admin = any(role.id in admin_roles.values() for role in message_before.author.roles)
and then compare against this variable

Originally posted by @Crambor in #86 (comment)

In a channel name, that updates with joins and leaves.

Just a shower thought.

The verification button in the verification channel needs to be re-created on every restart of the bot. We can, and should make this a persistent button

https://guide.pycord.dev/interactions/ui-components/buttons#persistent-views

might be more dynamic to use member.guild instead of self.bot.get_guild here

Originally posted by @Crambor in #86 (comment)

HAS BEEN HOTFIXED, but need to be updated in the next release

File "/zorak_bot/cogs/verification_on_verified.py", line 46, in verify_button_callback If you have any questions, feel free to post your question in {bot.get_channel(normal_channel['new_to_python']).mention} or {bot.get_channel(normal_channel['python_help_1']).mention} AttributeError: 'NoneType' object has no attribute 'mention'

Remove {bot.get_channel(normal_channel['new_to_python']) and update TOML files

Need to update a few items in the welcome message.

• Roles needs to be /roles
• Website needs proper link
• email doesn't seem to work
• invite link doesnt seem to work

Always defaults to test_server.

This would be a series of simple commands, such as:
/birthday add {date}
/birthday update {date}
/birthday - perhaps shows the next birthday on the server
/birthday list - shows a list of birthdays (paginated) in order of closest-first

When creating a ticket, an error is thrown:
Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/discord/ui/view.py", line 414, in _scheduled_task await item.callback(interaction) File "/src/cogs/general_tickets.py", line 30, in button_callback support = await self.bot.fetch_channel(mod_channel["server_support"]) AttributeError: 'make_a_ticket' object has no attribute 'bot'

and the ticket is not created

Refactor logging in-server using the audit log, rather than listeners for a more accurate logging experience.

dont forget to add Maszi's logging handler in there.

It's because the logger for tickets reads the Audit Log for threads being created.
Like this, created a log item for a ticket, even though it's not:

https://discord.com/channels/900302240559018015/1055501831800889454/1072137049378922566

Possible fix: Add a condition that checks for [Ticket} in the title of the thread before logging

Currently we have a "Python level" role, as well as a "country" role.

This should be handled by Zorak.

#59

Ignoring exception in on_message_edit Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/discord/client.py", line 377, in _run_event await coro(*args, **kwargs) File "/src/cogs/logging_message_edit.py", line 44, in on_message_edit await logs_channel.send(f"{username.mention}", embed=embed) File "/usr/local/lib/python3.9/site-packages/discord/abc.py", line 1606, in send data = await state.http.send_message( File "/usr/local/lib/python3.9/site-packages/discord/http.py", line 366, in request raise HTTPException(response, data) discord.errors.HTTPException: 400 Bad Request (error code: 50035): Invalid Form Body In embeds.0.fields.0.value: Must be 1024 or fewer in length. In embeds.0.fields.1.value: Must be 1024 or fewer in length.

Message edits that are more than 1024 characters throw an error. This can be handled by breaking the text into blocks of 1024 chars, and adding new feilds for every block.

Users should be able to use a slash command that provides an embed with the top 20 point earners in the server