preble / libpinproc Goto Github PK

Working on building libpinproc with current MSYS2/MinGW64 configuration, and the latest cmake version is generating these errors:

CMake Deprecation Warning at CMakeLists.txt:9 (cmake_policy):
  The OLD behavior for policy CMP0012 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


CMake Deprecation Warning at CMakeLists.txt:13 (cmake_policy):
  The OLD behavior for policy CMP0015 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

As recommended by @jabdoa2, we need to clean up our error reporting.

• Code in libpinproc shouldn't be printing anything out at all, unless it's a debug build.
• The two programs using libpinproc (pinprocfw, pinproctest) should consistently use stderr for error reporting and stdout for information.

Multiple users have reported issues with the verify stage of a pinprocfw update failing. It's unknown whether the writes are failing or the reads are failing.

First step could be to provide additional error information on the verify to see what exactly is failing.

But another step might be to try re-reading data if a read fails. Or reading back each page as it's written and re-writing any failed pages.

This appears to be affected P3-ROC only. Any users who have experienced trouble installing should comment on this issue with information on the build they used, and whether it was a P-ROC or P3-ROC.

We should be able to use GitHub actions to build libraries for distribution so others don't need to. We can then tag specific commits as "official" releases.

I'd like to see automated builds for the libraries used in PinMAME, but we could also identify common platforms and have automated libpinproc builds feed into automated pypinproc builds if that makes it easier for developers to start coding in MPF, SkeletonGame and other platforms.