pressly / imgry Goto Github PK

View Code? Open in Web Editor NEW

156.0 156.0 15.0 27.27 MB

On-demand image sizing+delivery for responsive applications

License: MIT License

Makefile 1.35% Go 96.67% Shell 1.98%

imgry's People

Contributors

Stargazers

Watchers

Forkers

cinderalla sethdford chrisemoulton saj1th bobquest33 sebito91 aminur stalinkay dmitrymomot forkkit lesichkovm ignitewind valsor iq-scm

imgry's Issues

Performance and memory management improvements

Fast gif resize

imgry/imagick/imagick.go

Lines 195 to 199 in f7a2a8c

 // TODO: instead of Coalesce, better to change the offsets. 

 // This is required for animated image resizing 

 if !sz.Flatten && i.mw.GetNumberImages() > 1 { 

 i.mw = i.mw.CoalesceImages() 

 }

Metrics

Let's switch to https://github.com/armon/go-metrics and push out statsd metrics to localhost. Our sysdig-agent will pick up metrics sent to localhost (it's already setup in dashboard).

New op: fitted

Change timer granularity

Cover images are not centered

When using op=cover with a different dimension compared to original image, the processed image is not cropped from the center.

This seems to be a regression.

Example

Original:

https://s3.amazonaws.com/pressly-imgrydb/beta/uploads/4497b7d7d324fd0361f9280a93145f8d.jpg

Processed:

https://imgry.pressly.com/fetch?url=https%3A%2F%2Fs3.amazonaws.com%2Fpressly-imgrydb%2Fbeta%2Fuploads%2F4497b7d7d324fd0361f9280a93145f8d.jpg&format=jpeg&size=750x922&op=cover

--oom-kill-disable=true for docker container run

Docker image fails to build

This was with:

Docker version 1.9.1, build a34a1d5

The ADD command fails with an error, it's like it does not honour redirections properly.

Documentation

Is it possible you can give some installation instruction and configuration options (how to use it with s3) etc.,

I have never used Go, but it this is like install on a server and forget, it would be great!

lg/heartbeat repositories no longer exist for goware github user

imgry/server/server.go

Lines 7 to 8 in 641520a

 "github.com/goware/heartbeat" 

 "github.com/goware/lg"

Re-enable metricsmgr

Because github.com/pressly/chainstore/metricsmgr needed some changes and was temporary removed.

if image url redirected, imgry won't be able to fetch the image

the following url fails to load by imgry https://www.pressly.com/images/pressly.png.

Imagick reference is broken

Hey @pkieltyka, it looks like, with your latest commit, the github.com/gographics/imagick was updated to a reference that does not exist:

git diff a983e5c52dd277be3e78a150828fd4cf2805c6dd abd012e0f4c546fc0394e3ba1d1ccb24e32021d4

And now the make deps script fails:

# cd /home/vagrant/go/src/github.com/gographics/imagick; git checkout 5f86f7c1a891
error: pathspec '5f86f7c1a891' did not match any file(s) known to git.

Probably glock failed to sync dependencies for some reason?

When UDP write fails go-metrics goes to sleep

Use github.com/goware/go-metrics instead or armon's, that one does not sleep on errors.

Create a better health check

checking if go process is alive is not enough

	// TODO: instead of Coalesce, better to change the offsets.
	// This is required for animated image resizing
	if !sz.Flatten && i.mw.GetNumberImages() > 1 {
	i.mw = i.mw.CoalesceImages()
	}

pressly / imgry Goto Github PK

imgry's People

Contributors

Stargazers

Watchers

Forkers

imgry's Issues

Example

Recommend Projects

Recommend Topics

Recommend Org

Jobs