prestashopcorp / avalaratax Goto Github PK

I catch this message "Invalid classname" after installing a specific module on my local PrestaShop from avalaratax.php.

Could you please, manage correctly the error your module can provide. After this, we will be able to validate your pull request.

Thank you,

@alex974 sent us this:

In avalaratax.php , method public function validateAddress(Address $address) , one issue i got is that it doesn't tell the customer a warning for choosing the wrong state(it does warn for zip code country etc) , but at the same time avalara call do return the right state.

The issue is that Avalara doesn't warn you nor does it change your state in you address and that lead a wrong address being save and again even tough the avalara call will return the rigth state if it was California and you put Colorado , California is return(just for avatax) but user keep the colorado state save in his address .

That can quickly create issue it you use any other module like i don't know UPS , FEDEX, DHL or even for invoice , if you manually ship because you are using a wrong address.

What i did which is super ugly but work is add
if the current state different than the return state , i set a warning to true
if ($avalaraAddress->getRegion() != $addresses->ValidAddress->getRegion()) {
$warning = true;
}
//then in resultcode
if($warning) {
$buffer['ResultCode'] = 'Error';
$buffer['Messages']['Name'][] = Tools::safeOutput('Wrong state');
$buffer['Messages']['Summary'][] = Tools::safeOutput('The State you selected does not match your address');
}

In avalaratax.php line 1398, it uses table name ps_order_detail instead of '._DB_PREFIX_.'order_detail

@shaabans noted:

Many users are getting an error that looks just like this:

http://forge.prestashop.com/browse/PNM-2641

The "fix" at the bottom of that thread has been tested and works. We're still unable to consistently recreate the error. A scenario that causes this 100% of the time would be very helpful, we're working on this now!

@alex974 replied:

I registered an account because i have wait too much bug with this module and i wanted to report them to help
Regarding this error , like your link find out , the problem come from the setDiscount of the getTax method in Avalaratax.php.

The real problem has nothing to do with the memory,if you debug it , you realize very quickly that it's just an infinite loop . You are in Gettax() , here setdiscount call the following
$params['cart']->getOrderTotal(true, Cart::ONLY_DISCOUNTS)); And somehow after going to a lot and lot of code getOrderTotal do call Gettax() again.

Very shortly that give , gettax()->getOrderTotal()->gettax()->getOrderTotal->gettax() until yea you run out of memory eventually .

I will try to provide a scenario i do have some order that hit 100% this errors.

In avalaratax.php line 271

$this->_erroors[] instead of $this->_errors[]

Module not working with Prestashop 1.7.3.2

Please help.

Need to handle exemptions (either using entity/use code dropdown or exemption number) as described here:

http://developer.avalara.com/api-docs/designing-your-integration/handling-tax-exempt-customers

I'm running Avalara - AvaTax v3.5.7 on Prestashop 1.6.1.4 and when I tried to configure the module I see that the module is looking for shop/modules/avalaratax/sdk/classes/AvaCert2Svc/ConfigureMessage.class.php, but I can't see it under the module anywhere. I also looked in github and this file doesn't exist. Any help would be appreciated.

Hard coded database prefixes are forbidden, you should use 'DB_PREFIX' instead

Will avalaratax support multiple shop ?

It seem it doesn't because query at line 1336 in avalaratax.php does not filter by shop_id
this query result have two line for one product if it is in 2 shop_id

You confirm ?

thanks

Tax rates doubled.
Any suggestions on how to fix this?

Prestashop: 1.6.1.13
Avatax: Current / Just installed it.

Test transaction @ 1,913.37
Tax shows: 348.24 which is exactly double what it should be.

Rate verified @ state website = 0.091
https://webgis.dor.wa.gov/taxratelookup/SalesTax.aspx

@Quetzacoalt91 we would like to ask your assistance on the following major issue that is causing the module to fail with the latest releases of PS:

We recently became aware of an issue that is causing Avalara's AvaTax module to fail when used with PS version 1.6.0.10 or above. We've tracked down the specific update that appears to be causing the problems, and would like to ask for your advice on the best resolution path.

The AvaTax module overrides the file /classes/tax/Tax.php, and provides an updated version of the getProductTaxRate function, which retrieves the proper tax rate. It appears that, as of commit 97ac180921a0d2ff62e2925dac4287fcada0910f that the getProductTaxRate is no longer used (or at least used much less often).

Can you confirm if getProductTaxRate is no longer being used, and offer us a hint based on the current system and your development as to the best function for us to override if we'd like to modify default taxes?

@rGaillard suggested that a more elegant way to handle tax is to avoid overrides altogether and instead to create a TaxManagerModule instead of overrides. From inspecting the code, it appears that this would be implemented via using the "taxManager" hook in the module to setup our own TaxManagerModule, which would extend TaxManagerModuleCore, and that we would then need to create a new TaxCalculator that extends TaxCalculatorCore and, in particular, overrides the TaxCalulatorCore->getTaxesAmount method.

Can you offer further advice or point us toward documentation / examples?